From 1c4224e3d7c796313f8bb99d39dcc0fc8437c7a6 Mon Sep 17 00:00:00 2001
From: Raoul Snyman <raoul@snyman.info>
Date: Fri, 18 Oct 2019 16:54:00 +0000
Subject: [PATCH] Skip certain tests if we're running on GitLab or AppVeyor

---
 .gitlab-ci.yml                                            | 8 ++++----
 .../openlp_plugins/presentations/test_pdfcontroller.py    | 4 +++-
 tests/interfaces/openlp_plugins/bibles/test_lib_http.py   | 4 +++-
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 5edb7301e..b36b4cbf4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -17,7 +17,7 @@ test-debian:
   before_script:
     - sh scripts/generate_resources.sh
   script:
-    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings --ignore tests/functional/openlp_plugins/presentations/test_pdfcontroller.py --cov openlp --cov-report term
+    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings --cov openlp --cov-report term
     - mv .coverage linux.coverage
   artifacts:
     paths:
@@ -29,7 +29,7 @@ test-ubuntu:
   before_script:
     - sh scripts/generate_resources.sh
   script:
-    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings --ignore tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
+    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings
 
 test-fedora:
   stage: test
@@ -37,7 +37,7 @@ test-fedora:
   before_script:
     - sh scripts/generate_resources.sh
   script:
-    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings --ignore tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
+    - xvfb-run -s '-screen 0 1024x768x24' pytest-3 --color=no --disable-warnings
 
 test-arch:
   stage: test
@@ -45,7 +45,7 @@ test-arch:
   before_script:
     - sh scripts/generate_resources.sh
   script:
-    - xvfb-run -s '-screen 0 1024x768x24' pytest --color=no --disable-warnings --ignore tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
+    - xvfb-run -s '-screen 0 1024x768x24' pytest --color=no --disable-warnings
 
 test-macos:
   stage: test
diff --git a/tests/functional/openlp_plugins/presentations/test_pdfcontroller.py b/tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
index 714f6fe48..c9f9e195f 100644
--- a/tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
+++ b/tests/functional/openlp_plugins/presentations/test_pdfcontroller.py
@@ -25,7 +25,7 @@ import os
 from pathlib import Path
 from shutil import rmtree, which
 from tempfile import mkdtemp
-from unittest import TestCase
+from unittest import TestCase, skipIf
 from unittest.mock import MagicMock, patch
 
 from PyQt5 import QtCore, QtGui
@@ -49,6 +49,7 @@ SCREEN = {
     'number': 1,
     'size': QtCore.QRect(0, 0, 1024, 768)
 }
+IS_CI = 'GITLAB_CI' in os.environ or 'APPVEYOR' in os.environ
 
 
 def get_screen_resolution():
@@ -114,6 +115,7 @@ class TestPdfController(TestCase, TestMixin):
         # THEN: The name of the presentation controller should be correct
         assert 'Pdf' == controller.name, 'The name of the presentation controller should be correct'
 
+    @skipIf(IS_CI, "This is failing on CI, skip until we can figure out what the problem is")
     def load_pdf(self, exe_path):
         """
         Test loading a Pdf using the PdfController
diff --git a/tests/interfaces/openlp_plugins/bibles/test_lib_http.py b/tests/interfaces/openlp_plugins/bibles/test_lib_http.py
index 0fa4a1f12..dd090c526 100644
--- a/tests/interfaces/openlp_plugins/bibles/test_lib_http.py
+++ b/tests/interfaces/openlp_plugins/bibles/test_lib_http.py
@@ -28,8 +28,10 @@ from unittest.mock import MagicMock
 from openlp.core.common.registry import Registry
 from openlp.plugins.bibles.lib.importers.http import BGExtract, BSExtract, CWExtract
 
+IS_CI = 'GITLAB_CI' in os.environ or 'APPVEYOR' in os.environ
 
-@skipIf(os.environ.get('GITLAB_CI'), 'Skip Bible HTTP tests to prevent GitLab CI from being blacklisted')
+
+@skipIf(IS_CI, 'Skip Bible HTTP tests to prevent GitLab CI from being blacklisted')
 class TestBibleHTTP(TestCase):
 
     def setUp(self):