Add fixes.

This commit is contained in:
Matey 2024-04-29 10:14:04 +03:00
parent 30760515d0
commit 2edc11313a
5 changed files with 3 additions and 5 deletions

View File

@ -1 +1 @@
3.1.1.dev34+6bbfe00ec
3.1.1

View File

@ -473,7 +473,6 @@ class Settings(QtCore.QSettings):
('shortcuts/offlineHelpItem', 'shortcuts/userManualItem', []), # Online and Offline help were combined in 2.6.
('shortcuts/onlineHelpItem', 'shortcuts/userManualItem', []), # Online and Offline help were combined in 2.6.
('songs/auto play audio', 'songs/auto play audio', [(bool, None)]),
('songs/uppercase songs', 'songs/uppercase songs', [(bool, None)]),
('songs/last directory export', 'songs/last directory export', [(str_to_path, None)]),
('songs/last directory import', 'songs/last directory import', [(str_to_path, None)]),
# Last search type was renamed to last used search type in 2.6 since Bible search value type changed in 2.6.

View File

@ -560,7 +560,6 @@ class SongMediaItem(MediaManagerItem):
"""
log.debug('generate_slide_data: {service}, {item}, {remote}'.format(service=service_item, item=item,
remote=self.remote_song))
uppercase = bool(self.settings.value('songs/uppercase songs'))
item_id = self._get_id_of_item_to_generate(item, self.remote_song)
service_item.add_capability(ItemCapabilities.CanEdit)

View File

@ -257,7 +257,7 @@ class SongsTab(SettingsTab):
def on_auto_play_check_box_changed(self, check_state):
self.auto_play = (check_state == QtCore.Qt.Checked)
def on_uppercase_check_box_changed(self, check_state):
self.uppercase = (check_state == QtCore.Qt.Checked)

View File

@ -101,7 +101,7 @@ def test_save_check_box_settings(form):
assert form.settings.value('songs/add song from service') is True
assert form.settings.value('songs/disable chords import') is False
assert form.settings.value('songs/auto play audio') is True
assert form.settings.value('songs/uppercase songs') is True
# assert form.settings.value('songs/uppercase songs') is True
def test_english_notation_button(form):