openlp
/
openlp
mirror of https://gitlab.com/openlp/openlp.git
1
0
Fork 1
Code Issues Projects Releases Wiki Activity

fixing tests

This commit is contained in:
Mateus Meyer Jiacomelli 2022-11-21 11:46:43 -03:00
parent 2f3a575e7c
commit b9d507b455
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/openlp_core/display/test_window.py
View File

@ -381,6 +381,7 @@ def test_after_loaded_callback(display_window_env, mock_settings):
# THEN: The after_loaded_callback should be called
mocked_after_loaded_callback.assert_called_once()
@patch.object(time, 'time')
def test_run_javascript_no_sync_no_wait(mock_time, display_window_env, mock_settings):
"""

14
tests/openlp_core/ui/test_mainwindow.py
View File

@ -771,9 +771,9 @@ def test_screen_changed_modal(mocked_warning, main_window):
@patch('openlp.core.ui.mainwindow.QtWidgets.QMessageBox.warning')
def test_screen_changed_modal_sets_timestamp_before_blocking_on_modal(mocked_warning, main_window):
def test_screen_changed_modal_sets_timestamp_after_blocking_on_modal(mocked_warning, main_window):
"""
Test that the screen changed modal latest shown timestamp is set before showing warning message, so
Test that the screen changed modal latest shown timestamp is set after showing warning message, so
that duplicate modals due to event spamming on 'config_screen_changed' in less than 5 seconds is mitigated.
"""
# GIVEN: a newly opened OpenLP instance, mocked screens, renderer and an special QMessageBox warning handler
@ -781,19 +781,13 @@ def test_screen_changed_modal_sets_timestamp_before_blocking_on_modal(mocked_war
main_window._preview_controller = MagicMock()
main_window._renderer = MagicMock()
def resets_timestamp(*args, **kwargs):
nonlocal main_window
main_window.screen_change_timestamp = None
mocked_warning.side_effect = resets_timestamp
# WHEN: we trigger a 'config_screen_changed' event
Registry().execute('config_screen_changed')
# THEN: main_window.screen_change_timestamp should be "None", indicating that timestamp is set before
# THEN: main_window.screen_change_timestamp should have a timestamp, indicating that timestamp is set after
# the blocking modal is shown.
mocked_warning.assert_called_once()
assert main_window.screen_change_timestamp is None
assert main_window.screen_change_timestamp is not None
@patch('openlp.core.ui.mainwindow.QtWidgets.QMessageBox.critical')