openlp
/
openlp
mirror of https://gitlab.com/openlp/openlp.git
1
0
Fork 1
Code Issues Projects Releases Wiki Activity

[translations] If you do a format check, make it influence the return code of the script

This commit is contained in:
Raoul Snyman 2015-12-23 23:51:00 +02:00
parent af85a931b4
commit eebe9ed6b9
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
scripts/translation_utils.py
View File

@ -51,6 +51,7 @@ import base64
import glob import glob
import json import json
import os import os
import sys
import urllib.error import urllib.error
import urllib.parse import urllib.parse
import urllib.request import urllib.request
@ -300,6 +301,7 @@ def check_format_strings():
This method runs through the ts-files and looks for mismatches between format strings in the original text This method runs through the ts-files and looks for mismatches between format strings in the original text
and in the translations. and in the translations.
""" """
is_ok = True
path = os.path.join(os.path.abspath('..'), 'resources', 'i18n', '*.ts') path = os.path.join(os.path.abspath('..'), 'resources', 'i18n', '*.ts')
file_list = glob.glob(path) file_list = glob.glob(path)
for filename in file_list: for filename in file_list:
@ -317,14 +319,17 @@ def check_format_strings():
print_verbose('parsed numerusform: location: %s, source: %s, translation: %s' % ( print_verbose('parsed numerusform: location: %s, source: %s, translation: %s' % (
location, org_text, num.text)) location, org_text, num.text))
if num and org_text.count('%') != num.text.count('%'): if num and org_text.count('%') != num.text.count('%'):
is_ok = False
print_quiet( print_quiet(
'ERROR: Translation from %s at line %s has a mismatch of format input:\n%s\n%s\n' % ( 'ERROR: Translation from %s at line %s has a mismatch of format input:\n%s\n%s\n' % (
location, line, org_text, num.text)) location, line, org_text, num.text))
else: else:
print_verbose('parsed: location: %s, source: %s, translation: %s' % (location, org_text, translation)) print_verbose('parsed: location: %s, source: %s, translation: %s' % (location, org_text, translation))
if org_text.count('%') != translation.count('%'): if org_text.count('%') != translation.count('%'):
is_ok = False
print_quiet('ERROR: Translation from %s at line %s has a mismatch of format input:\n%s\n%s\n' % ( print_quiet('ERROR: Translation from %s at line %s has a mismatch of format input:\n%s\n%s\n' % (
location, line, org_text, translation)) location, line, org_text, translation))
return is_ok
def process_stack(command_stack): def process_stack(command_stack):
@ -335,6 +340,7 @@ def process_stack(command_stack):
``command_stack`` ``command_stack``
The command stack to process. The command stack to process.
""" """
is_success = True
if command_stack: if command_stack:
print_quiet('Processing %d commands...' % len(command_stack)) print_quiet('Processing %d commands...' % len(command_stack))
for command in command_stack: for command in command_stack:
@ -351,10 +357,11 @@ def process_stack(command_stack):
elif command == Command.Create: elif command == Command.Create:
create_translation() create_translation()
elif command == Command.Check: elif command == Command.Check:
check_format_strings() is_success = check_format_strings()
print_quiet('Finished processing commands.') print_quiet('Finished processing commands.')
else: else:
print_quiet('No commands to process.') print_quiet('No commands to process.')
return is_success
def main(): def main():
@ -411,11 +418,13 @@ def main():
command_stack.append(Command.Update) command_stack.append(Command.Update)
command_stack.append(Command.Generate) command_stack.append(Command.Generate)
# Process the commands # Process the commands
process_stack(command_stack) return process_stack(command_stack)
if __name__ == '__main__': if __name__ == '__main__':
if os.path.split(os.path.abspath('.'))[1] != 'scripts': if os.path.split(os.path.abspath('.'))[1] != 'scripts':
print('You need to run this script from the scripts directory.') print('You need to run this script from the scripts directory.')
else: else:
main() if not main():
sys.exit(1)