openlp
/
openlp
mirror of https://gitlab.com/openlp/openlp.git
1
0
Fork 1
Code Issues Projects Releases Wiki Activity

reflect settings change on style_combo_box

This commit is contained in:
STEPHANVS 2022-05-12 01:13:57 +02:00
parent bf646820b4
commit ffaa131d8a
No known key found for this signature in database
GPG Key ID: 4EFE47E471FD62A9
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openlp/plugins/bibles/lib/mediaitem.py
View File

@ -297,6 +297,9 @@ class BibleMediaItem(MediaManagerItem):
visible = self.settings.value('bibles/second bibles')
self.general_bible_layout.labelForField(self.second_combo_box).setVisible(visible)
self.second_combo_box.setVisible(visible)
layout_style = self.settings.value('bibles/verse layout style')
if layout_style is not None:
self.style_combo_box.setCurrentIndex(layout_style)
def initialise(self):
"""

23
tests/openlp_plugins/bibles/test_mediaitem.py
View File

@ -250,9 +250,10 @@ def test_config_update_show_second_bible(media_item):
Test the config update method
"""
# GIVEN: An instance of :class:`MediaManagerItem` and mocked out settings class with known values
media_item.settings.value = lambda key: {'bibles/second bibles': True}[key]
media_item.settings.value = lambda key: {'bibles/second bibles': True, 'bibles/verse layout style': 0}[key]
media_item.general_bible_layout = MagicMock()
media_item.second_combo_box = MagicMock()
media_item.style_combo_box = MagicMock()
# WHEN: Calling config_update()
media_item.config_update()
@ -266,9 +267,10 @@ def test_config_update_hide_second_bible(media_item):
Test the config update method
"""
# GIVEN: An instance of :class:`MediaManagerItem` and mocked out settings class with known values
media_item.settings.value = lambda key: {'bibles/second bibles': False}[key]
media_item.settings.value = lambda key: {'bibles/second bibles': False, 'bibles/verse layout style': 0}[key]
media_item.general_bible_layout = MagicMock()
media_item.second_combo_box = MagicMock()
media_item.style_combo_box = MagicMock()
# WHEN: Calling config_update()
media_item.config_update()
@ -277,6 +279,23 @@ def test_config_update_hide_second_bible(media_item):
media_item.second_combo_box.setVisible.assert_called_once_with(False)
def test_config_update_set_layout_style(media_item):
"""
Test the config update method
"""
# GIVEN: An instance of :class:`MediaManagerItem` and mocked out settings class with known values
media_item.settings.value = lambda key: {'bibles/second bibles': True, 'bibles/verse layout style': 1}[key]
media_item.general_bible_layout = MagicMock()
media_item.second_combo_box = MagicMock()
media_item.style_combo_box = MagicMock()
# WHEN: Calling config_update()
media_item.config_update()
# THEN: style_combo_box should set the currentIndex to 1
media_item.style_combo_box.setCurrentIndex(1)
def test_initalise(media_item):
"""
Test the initalise method