openlp/tests/functional/openlp_plugins/bibles/test_opensongimport.py

420 lines
18 KiB
Python
Raw Normal View History

# -*- coding: utf-8 -*-
2019-04-13 13:00:22 +00:00
##########################################################################
# OpenLP - Open Source Lyrics Projection #
# ---------------------------------------------------------------------- #
# Copyright (c) 2008-2019 OpenLP Developers #
# ---------------------------------------------------------------------- #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
# the Free Software Foundation, either version 3 of the License, or #
# (at your option) any later version. #
# #
# This program is distributed in the hope that it will be useful, #
# but WITHOUT ANY WARRANTY; without even the implied warranty of #
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
# GNU General Public License for more details. #
# #
# You should have received a copy of the GNU General Public License #
# along with this program. If not, see <https://www.gnu.org/licenses/>. #
##########################################################################
"""
This module contains tests for the OpenSong Bible importer.
"""
from unittest import TestCase
2018-10-02 04:39:42 +00:00
from unittest.mock import MagicMock, call, patch
from lxml import objectify
2016-08-18 06:31:36 +00:00
2017-10-07 07:05:07 +00:00
from openlp.core.common.registry import Registry
2016-08-18 06:31:36 +00:00
from openlp.plugins.bibles.lib.bibleimport import BibleImport
2017-12-28 08:27:44 +00:00
from openlp.plugins.bibles.lib.importers.opensong import OpenSongBible, get_text, parse_chapter_number
from tests.helpers.testmixin import TestMixin
2017-12-22 22:21:38 +00:00
from tests.utils import load_external_result_data
2017-12-22 21:20:49 +00:00
from tests.utils.constants import RESOURCE_PATH
2018-10-02 04:39:42 +00:00
2017-12-22 21:20:49 +00:00
TEST_PATH = RESOURCE_PATH / 'bibles'
class TestOpenSongImport(TestCase, TestMixin):
"""
Test the functions in the :mod:`opensongimport` module.
"""
def setUp(self):
2016-09-02 14:23:20 +00:00
self.find_and_create_book_patch = patch.object(BibleImport, 'find_and_create_book')
self.addCleanup(self.find_and_create_book_patch.stop)
self.mocked_find_and_create_book = self.find_and_create_book_patch.start()
self.manager_patcher = patch('openlp.plugins.bibles.lib.db.Manager')
2016-08-18 06:31:36 +00:00
self.addCleanup(self.manager_patcher.stop)
self.manager_patcher.start()
self.setup_application()
self.app.process_events = MagicMock()
Registry.create()
Registry().register('application', self.app)
2016-05-31 21:40:13 +00:00
def test_create_importer(self):
"""
Test creating an instance of the OpenSong file importer
"""
# GIVEN: A mocked out "manager"
mocked_manager = MagicMock()
# WHEN: An importer object is created
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(mocked_manager, path='.', name='.', file_path=None)
# THEN: The importer should be an instance of BibleDB
2017-12-22 16:53:40 +00:00
assert isinstance(importer, BibleImport)
2016-08-18 06:31:36 +00:00
def test_get_text_no_text(self):
"""
Test that get_text handles elements containing text in a combination of text and tail attributes
"""
# GIVEN: Some test data which contains an empty element and an instance of OpenSongBible
test_data = objectify.fromstring('<element></element>')
# WHEN: Calling get_text
result = get_text(test_data)
# THEN: A blank string should be returned
2017-12-22 16:53:40 +00:00
assert result == ''
def test_get_text_text(self):
2016-08-18 06:31:36 +00:00
"""
Test that get_text handles elements containing text in a combination of text and tail attributes
"""
# GIVEN: Some test data which contains all possible permutation of text and tail text possible and an instance
# of OpenSongBible
test_data = objectify.fromstring('<element>Element text '
'<sub_text_tail>sub_text_tail text </sub_text_tail>sub_text_tail tail '
'<sub_text>sub_text text </sub_text>'
'<sub_tail></sub_tail>sub_tail tail</element>')
# WHEN: Calling get_text
result = get_text(test_data)
# THEN: The text returned should be as expected
2017-12-22 16:53:40 +00:00
assert result == 'Element text sub_text_tail text sub_text_tail tail sub_text text sub_tail tail'
def test_parse_chapter_number(self):
"""
Test parse_chapter_number when supplied with chapter number and an instance of OpenSongBible
2016-08-18 06:31:36 +00:00
"""
# GIVEN: The number 10 represented as a string
# WHEN: Calling parse_chapter_nnumber
result = parse_chapter_number('10', 0)
2016-08-18 06:31:36 +00:00
# THEN: The 10 should be returned as an Int
2017-12-22 16:53:40 +00:00
assert result == 10
2016-08-18 06:31:36 +00:00
def test_parse_chapter_number_empty_attribute(self):
2016-08-18 06:31:36 +00:00
"""
Testparse_chapter_number when the chapter number is an empty string. (Bug #1074727)
2016-08-18 06:31:36 +00:00
"""
# GIVEN: An empty string, and the previous chapter number set as 12 and an instance of OpenSongBible
# WHEN: Calling parse_chapter_number
result = parse_chapter_number('', 12)
2016-08-18 06:31:36 +00:00
# THEN: parse_chapter_number should increment the previous verse number
2017-12-22 16:53:40 +00:00
assert result == 13
2016-08-18 06:31:36 +00:00
def test_parse_verse_number_valid_verse_no(self):
2016-08-18 06:31:36 +00:00
"""
Test parse_verse_number when supplied with a valid verse number
2016-08-18 06:31:36 +00:00
"""
# GIVEN: An instance of OpenSongBible, the number 15 represented as a string and an instance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling parse_verse_number
result = importer.parse_verse_number('15', 0)
2016-08-18 06:31:36 +00:00
# THEN: parse_verse_number should return the verse number
2017-12-22 16:53:40 +00:00
assert result == 15
2016-08-18 06:31:36 +00:00
def test_parse_verse_number_verse_range(self):
2016-08-18 06:31:36 +00:00
"""
Test parse_verse_number when supplied with a verse range
2016-08-18 06:31:36 +00:00
"""
# GIVEN: An instance of OpenSongBible, and the range 24-26 represented as a string
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling parse_verse_number
result = importer.parse_verse_number('24-26', 0)
2016-08-18 06:31:36 +00:00
# THEN: parse_verse_number should return the first verse number in the range
2017-12-22 16:53:40 +00:00
assert result == 24
2016-08-18 06:31:36 +00:00
def test_parse_verse_number_invalid_verse_no(self):
2016-08-18 06:31:36 +00:00
"""
Test parse_verse_number when supplied with a invalid verse number
2016-08-18 06:31:36 +00:00
"""
# GIVEN: An instance of OpenSongBible, a non numeric string represented as a string
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling parse_verse_number
result = importer.parse_verse_number('invalid', 41)
2016-08-18 06:31:36 +00:00
# THEN: parse_verse_number should increment the previous verse number
2017-12-22 16:53:40 +00:00
assert result == 42
2016-08-18 06:31:36 +00:00
def test_parse_verse_number_empty_attribute(self):
2016-08-18 06:31:36 +00:00
"""
Test parse_verse_number when the verse number is an empty string. (Bug #1074727)
2016-08-18 06:31:36 +00:00
"""
# GIVEN: An instance of OpenSongBible, an empty string, and the previous verse number set as 14
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling parse_verse_number
result = importer.parse_verse_number('', 14)
2016-08-18 06:31:36 +00:00
# THEN: parse_verse_number should increment the previous verse number
2017-12-22 16:53:40 +00:00
assert result == 15
2016-08-18 06:31:36 +00:00
def test_parse_verse_number_invalid_type(self):
2016-08-18 06:31:36 +00:00
"""
Test parse_verse_number when the verse number is an invalid type)
2016-08-18 06:31:36 +00:00
"""
with patch.object(OpenSongBible, 'log_warning')as mocked_log_warning:
# GIVEN: An instanceofOpenSongBible, a Tuple, and the previous verse number set as 12
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
2016-08-18 06:31:36 +00:00
# WHEN: Calling parse_verse_number
result = importer.parse_verse_number((1, 2, 3), 12)
# THEN: parse_verse_number should log the verse number it was called with increment the previous verse
# number
mocked_log_warning.assert_called_once_with('Illegal verse number: (1, 2, 3)')
2017-12-22 16:53:40 +00:00
assert result == 13
2016-08-18 06:31:36 +00:00
def test_process_books_stop_import(self):
"""
Test process_books when stop_import is set to True
"""
2016-09-02 14:23:20 +00:00
# GIVEN: An instance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: stop_import_flag is set to True
importer.stop_import_flag = True
importer.process_books(['Book'])
# THEN: find_and_create_book should not have been called
2017-12-22 16:53:40 +00:00
assert self.mocked_find_and_create_book.called is False
def test_process_books_completes(self):
"""
Test process_books when it processes all books
"""
# GIVEN: An instance of OpenSongBible Importer and two mocked books
2016-09-02 14:23:20 +00:00
self.mocked_find_and_create_book.side_effect = ['db_book1', 'db_book2']
with patch.object(OpenSongBible, 'process_chapters') as mocked_process_chapters:
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
2016-09-02 14:23:20 +00:00
book1 = MagicMock()
book1.attrib = {'n': 'Name1'}
book1.c = 'Chapter1'
book2 = MagicMock()
book2.attrib = {'n': 'Name2'}
book2.c = 'Chapter2'
importer.language_id = 10
importer.session = MagicMock()
importer.stop_import_flag = False
# WHEN: Calling process_books with the two books
importer.process_books([book1, book2])
# THEN: find_and_create_book and process_books should be called with the details from the mocked books
2017-12-22 16:53:40 +00:00
assert self.mocked_find_and_create_book.call_args_list == [call('Name1', 2, 10), call('Name2', 2, 10)]
assert mocked_process_chapters.call_args_list == \
2017-12-23 09:30:02 +00:00
[call('db_book1', 'Chapter1'), call('db_book2', 'Chapter2')]
2017-12-22 16:53:40 +00:00
assert importer.session.commit.call_count == 2
def test_process_chapters_stop_import(self):
"""
Test process_chapters when stop_import is set to True
"""
# GIVEN: An isntance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
importer.parse_chapter_number = MagicMock()
# WHEN: stop_import_flag is set to True
importer.stop_import_flag = True
importer.process_chapters('Book', ['Chapter1'])
# THEN: importer.parse_chapter_number not have been called
2017-12-22 16:53:40 +00:00
assert importer.parse_chapter_number.called is False
@patch('openlp.plugins.bibles.lib.importers.opensong.parse_chapter_number', **{'side_effect': [1, 2]})
def test_process_chapters_completes(self, mocked_parse_chapter_number):
"""
Test process_chapters when it completes
"""
# GIVEN: An instance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
importer.wizard = MagicMock()
# WHEN: called with some valid data
book = MagicMock()
book.name = "Book"
chapter1 = MagicMock()
chapter1.attrib = {'n': '1'}
chapter1.c = 'Chapter1'
chapter1.v = ['Chapter1 Verses']
chapter2 = MagicMock()
chapter2.attrib = {'n': '2'}
chapter2.c = 'Chapter2'
chapter2.v = ['Chapter2 Verses']
importer.process_verses = MagicMock()
importer.stop_import_flag = False
importer.process_chapters(book, [chapter1, chapter2])
# THEN: parse_chapter_number, process_verses and increment_process_bar should have been called
2017-12-22 16:53:40 +00:00
assert mocked_parse_chapter_number.call_args_list == [call('1', 0), call('2', 1)]
assert importer.process_verses.call_args_list == \
2017-12-23 09:30:02 +00:00
[call(book, 1, ['Chapter1 Verses']), call(book, 2, ['Chapter2 Verses'])]
2017-12-22 16:53:40 +00:00
assert importer.wizard.increment_progress_bar.call_args_list == [call('Importing Book 1...'),
call('Importing Book 2...')]
def test_process_verses_stop_import(self):
"""
Test process_verses when stop_import is set to True
"""
# GIVEN: An isntance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
importer.parse_verse_number = MagicMock()
# WHEN: stop_import_flag is set to True
importer.stop_import_flag = True
importer.process_verses('Book', 1, 'Verses')
# THEN: importer.parse_verse_number not have been called
2017-12-22 16:53:40 +00:00
assert importer.parse_verse_number.called is False
def test_process_verses_completes(self):
"""
Test process_verses when it completes
"""
with patch('openlp.plugins.bibles.lib.importers.opensong.get_text',
**{'side_effect': ['Verse1 Text', 'Verse2 Text']}) as mocked_get_text, \
patch.object(OpenSongBible, 'parse_verse_number',
**{'side_effect': [1, 2]}) as mocked_parse_verse_number:
# GIVEN: An instance of OpenSongBible
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
importer.wizard = MagicMock()
# WHEN: called with some valid data
book = MagicMock()
book.id = 1
verse1 = MagicMock()
verse1.attrib = {'n': '1'}
verse1.c = 'Chapter1'
verse1.v = ['Chapter1 Verses']
verse2 = MagicMock()
verse2.attrib = {'n': '2'}
verse2.c = 'Chapter2'
verse2.v = ['Chapter2 Verses']
importer.create_verse = MagicMock()
importer.stop_import_flag = False
importer.process_verses(book, 1, [verse1, verse2])
# THEN: parse_chapter_number, process_verses and increment_process_bar should have been called
2017-12-22 16:53:40 +00:00
assert mocked_parse_verse_number.call_args_list == [call('1', 0), call('2', 1)]
assert mocked_get_text.call_args_list == [call(verse1), call(verse2)]
assert importer.create_verse.call_args_list == \
2017-12-23 09:30:02 +00:00
[call(1, 1, 1, 'Verse1 Text'), call(1, 1, 2, 'Verse2 Text')]
def test_do_import_parse_xml_fails(self):
"""
Test do_import when parse_xml fails (returns None)
"""
# GIVEN: An instance of OpenSongBible and a mocked parse_xml which returns False
with patch.object(OpenSongBible, 'log_debug'), \
2016-09-02 14:32:14 +00:00
patch.object(OpenSongBible, 'validate_xml_file'), \
patch.object(OpenSongBible, 'parse_xml', return_value=None), \
patch.object(OpenSongBible, 'get_language_id') as mocked_language_id:
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling do_import
result = importer.do_import()
# THEN: do_import should return False and get_language_id should have not been called
2017-12-22 16:53:40 +00:00
assert result is False
assert mocked_language_id.called is False
def test_do_import_no_language(self):
"""
Test do_import when the user cancels the language selection dialog
"""
# GIVEN: An instance of OpenSongBible and a mocked get_language which returns False
with patch.object(OpenSongBible, 'log_debug'), \
patch.object(OpenSongBible, 'validate_xml_file'), \
patch.object(OpenSongBible, 'parse_xml'), \
patch.object(OpenSongBible, 'get_language_id', return_value=False), \
patch.object(OpenSongBible, 'process_books') as mocked_process_books:
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling do_import
result = importer.do_import()
# THEN: do_import should return False and process_books should have not been called
2017-12-22 16:53:40 +00:00
assert result is False
assert mocked_process_books.called is False
def test_do_import_completes(self):
"""
Test do_import when it completes successfully
"""
# GIVEN: An instance of OpenSongBible
with patch.object(OpenSongBible, 'log_debug'), \
patch.object(OpenSongBible, 'validate_xml_file'), \
patch.object(OpenSongBible, 'parse_xml'), \
patch.object(OpenSongBible, 'get_language_id', return_value=10), \
patch.object(OpenSongBible, 'process_books'):
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(MagicMock(), path='.', name='.', file_path=None)
# WHEN: Calling do_import
result = importer.do_import()
# THEN: do_import should return True
2017-12-22 16:53:40 +00:00
assert result is True
2016-09-02 14:32:14 +00:00
2016-09-02 14:23:20 +00:00
class TestOpenSongImportFileImports(TestCase, TestMixin):
"""
Test the functions in the :mod:`opensongimport` module.
"""
def setUp(self):
self.manager_patcher = patch('openlp.plugins.bibles.lib.db.Manager')
self.addCleanup(self.manager_patcher.stop)
self.manager_patcher.start()
def test_file_import(self):
"""
Test the actual import of OpenSong Bible file
"""
# GIVEN: Test files with a mocked out "manager", "import_wizard", and mocked functions
# get_book_ref_id_by_name, create_verse, create_book, session and get_language.
2017-12-22 22:21:38 +00:00
test_data = load_external_result_data(TEST_PATH / 'dk1933.json')
2016-09-02 14:23:20 +00:00
bible_file = 'opensong-dk1933.xml'
with patch('openlp.plugins.bibles.lib.importers.opensong.OpenSongBible.application'):
mocked_manager = MagicMock()
mocked_import_wizard = MagicMock()
2017-10-10 19:09:20 +00:00
importer = OpenSongBible(mocked_manager, path='.', name='.', file_path=None)
2016-09-02 14:23:20 +00:00
importer.wizard = mocked_import_wizard
importer.get_book_ref_id_by_name = MagicMock()
importer.create_verse = MagicMock()
importer.create_book = MagicMock()
importer.session = MagicMock()
importer.get_language = MagicMock()
importer.get_language.return_value = 'Danish'
# WHEN: Importing bible file
2017-12-22 21:20:49 +00:00
importer.file_path = TEST_PATH / bible_file
2016-09-02 14:23:20 +00:00
importer.do_import()
# THEN: The create_verse() method should have been called with each verse in the file.
2017-12-22 16:53:40 +00:00
assert importer.create_verse.called is True
2016-09-02 14:23:20 +00:00
for verse_tag, verse_text in test_data['verses']:
importer.create_verse.assert_any_call(importer.create_book().id, 1, int(verse_tag), verse_text)