diff --git a/tests/functional/openlp_plugins/remotes/test_router.py b/tests/functional/openlp_plugins/remotes/test_router.py index 872c7c788..a9e21c2fe 100644 --- a/tests/functional/openlp_plugins/remotes/test_router.py +++ b/tests/functional/openlp_plugins/remotes/test_router.py @@ -25,11 +25,11 @@ This module contains tests for the lib submodule of the Remotes plugin. import os import urllib.request from unittest import TestCase +from unittest.mock import MagicMock, patch, mock_open from openlp.core.common import Settings, Registry from openlp.core.ui import ServiceManager from openlp.plugins.remotes.lib.httpserver import HttpRouter -from tests.functional import MagicMock, patch, mock_open from tests.helpers.testmixin import TestMixin __default_settings__ = { @@ -313,11 +313,13 @@ class TestRouter(TestCase, TestMixin): with patch.object(self.service_manager, 'setup_ui'), \ patch.object(self.router, 'do_json_header'): self.service_manager.bootstrap_initialise() - self.app.processEvents() + # Not sure why this is here, it doesn't make sense in the test + # self.app.processEvents() # WHEN: Remote next is received self.router.service(action='next') - self.app.processEvents() + # Not sure why this is here, it doesn't make sense in the test + # self.app.processEvents() # THEN: service_manager.next_item() should have been called self.assertTrue(mocked_next_item.called, 'next_item() should have been called in service_manager') @@ -334,11 +336,13 @@ class TestRouter(TestCase, TestMixin): with patch.object(self.service_manager, 'setup_ui'), \ patch.object(self.router, 'do_json_header'): self.service_manager.bootstrap_initialise() - self.app.processEvents() + # Not sure why this is here, it doesn't make sense in the test + # self.app.processEvents() # WHEN: Remote next is received self.router.service(action='previous') - self.app.processEvents() + # Not sure why this is here, it doesn't make sense in the test + # self.app.processEvents() # THEN: service_manager.next_item() should have been called self.assertTrue(mocked_previous_item.called, 'previous_item() should have been called in service_manager') diff --git a/tests/interfaces/openlp_plugins/bibles/forms/test_bibleimportform.py b/tests/interfaces/openlp_plugins/bibles/forms/test_bibleimportform.py index 8f07ac387..bf1a27d0b 100644 --- a/tests/interfaces/openlp_plugins/bibles/forms/test_bibleimportform.py +++ b/tests/interfaces/openlp_plugins/bibles/forms/test_bibleimportform.py @@ -22,7 +22,7 @@ """ Package to test the openlp.plugins.bibles.forms.bibleimportform package. """ -from unittest import TestCase +from unittest import TestCase, skip from PyQt5 import QtWidgets @@ -48,12 +48,12 @@ class TestBibleImportForm(TestCase, TestMixin): Registry().register('main_window', self.main_window) self.form = BibleImportForm(self.main_window, MagicMock(), MagicMock()) - def tearDown(self): - """ - Delete all the C++ objects at the end so that we don't have a segfault - """ - del self.form - del self.main_window + # def tearDown(self): + # """ + # Delete all the C++ objects at the end so that we don't have a segfault + # """ + # del self.form + # del self.main_window @patch('openlp.plugins.bibles.forms.bibleimportform.CWExtract.get_bibles_from_http') @patch('openlp.plugins.bibles.forms.bibleimportform.BGExtract.get_bibles_from_http')