raoul
/
openlp
forked from openlp/openlp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Review fixes

This commit is contained in:
Tim Bentley 2013-01-29 17:19:19 +00:00
parent 9719645edd
commit 0a1f91af8b
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openlp/core/ui/servicemanager.py
View File

@ -391,7 +391,7 @@ class ServiceManager(QtGui.QWidget, ServiceManagerDialog):
Loads the service file and saves the existing one it there is one Loads the service file and saves the existing one it there is one
unchanged unchanged
``load_File`` ``load_file``
The service file to the loaded. Will be None is from menu so The service file to the loaded. Will be None is from menu so
selection will be required. selection will be required.
""" """

2
openlp/plugins/custom/lib/mediaitem.py
View File

@ -137,7 +137,7 @@ class CustomMediaItem(MediaManagerItem):
self.onSearchTextButtonClicked() self.onSearchTextButtonClicked()
item = self.buildServiceItem(remote=True) item = self.buildServiceItem(remote=True)
self.remoteTriggered = None self.remoteTriggered = None
self.remoteCustom =1 self.remoteCustom = 1
if item: if item:
return item return item
return None return None

6
tests/functional/openlp_core_ui/test_servicenotedialog.py
View File

@ -42,7 +42,7 @@ class TestStartNoteDialog(TestCase):
QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton) QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton)
# THEN the following input text is returned # THEN the following input text is returned
self.assertEqual(self.form.text_edit.toPlainText(), u'', u'The returned text is empty') self.assertEqual(self.form.text_edit.toPlainText(), u'', u'The returned text should be empty')
# WHEN displaying the UI, having set the text and pressing enter # WHEN displaying the UI, having set the text and pressing enter
text = u'OpenLP is the best worship software' text = u'OpenLP is the best worship software'
@ -53,7 +53,7 @@ class TestStartNoteDialog(TestCase):
QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton) QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton)
# THEN the following text is returned # THEN the following text is returned
self.assertEqual(self.form.text_edit.toPlainText(), text, u'The text is as originally entered') self.assertEqual(self.form.text_edit.toPlainText(), text, u'The text originally entered should still be there')
# WHEN displaying the UI, having set the text and pressing enter # WHEN displaying the UI, having set the text and pressing enter
self.form.text_edit.setPlainText(u'') self.form.text_edit.setPlainText(u'')
@ -64,4 +64,4 @@ class TestStartNoteDialog(TestCase):
QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton) QtTest.QTest.mouseClick(okWidget, QtCore.Qt.LeftButton)
# THEN the following text is returned # THEN the following text is returned
self.assertEqual(self.form.text_edit.toPlainText(), text, u'The text is as changed text is returned') self.assertEqual(self.form.text_edit.toPlainText(), text, u'The text changed text should be returned')