From 4a1b826e660ce6461dcedef5b56ea54764d12c35 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Mon, 12 Oct 2009 07:21:17 +0100 Subject: [PATCH 1/7] Cleanups --- openlp/core/lib/mediamanageritem.py | 51 +++++++++++++++----------- openlp/plugins/bibles/lib/mediaitem.py | 3 ++ 2 files changed, 33 insertions(+), 21 deletions(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index 60661996c..0866137a6 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -206,63 +206,72 @@ class MediaManagerItem(QtGui.QWidget): if self.hasFileIcon: self.addToolbarButton( translate( - self.TranslationContext, u'Load ' + self.PluginTextShort), + self.TranslationContext, u'Load %s' % self.PluginTextShort), translate( self.TranslationContext, - u'Load a new ' + self.PluginTextShort), - u':' + self.IconPath + u'_load.png', self.onFileClick, - self.PluginTextShort + u'FileItem') + u'Load a new %s' % self.PluginTextShort), + u':%s_load.png' % self.IconPath, + self.onFileClick, + u'%sFileItem' %self.PluginTextShort) ## New Button ## if self.hasNewIcon: self.addToolbarButton( translate( - self.TranslationContext, u'New ' + self.PluginTextShort), + self.TranslationContext, u'New %s' % self.PluginTextShort), translate( self.TranslationContext, - u'Add a new ' + self.PluginTextShort), - u':' + self.IconPath + u'_new.png', self.onNewClick, - self.PluginTextShort + u'NewItem') + u'Add a new %s' % self.PluginTextShort), + u':%s_new.png' % self.IconPath, + self.onNewClick, + u'%sNewItem' % self.PluginTextShort) ## Edit Button ## if self.hasEditIcon: self.addToolbarButton( translate( - self.TranslationContext, u'Edit ' + self.PluginTextShort), + self.TranslationContext, u'Edit %s' % self.PluginTextShort), translate( self.TranslationContext, - u'Edit the selected ' + self.PluginTextShort), - u':' + self.IconPath + u'_edit.png', self.onEditClick, - self.PluginTextShort + u'EditItem') + u'Edit the selected %s' % self.PluginTextShort), + u':%s_edit.png' % self.IconPath, + self.onEditClick, + u'%sEditItem' % self.PluginTextShort) ## Delete Button ## if self.hasDeleteIcon: self.addToolbarButton( translate( - self.TranslationContext, u'Delete ' + self.PluginTextShort), + self.TranslationContext, u'Delete %s ' % self.PluginTextShort), translate(self.TranslationContext, u'Delete the selected item'), - u':' + self.IconPath + u'_delete.png', self.onDeleteClick, - self.PluginTextShort + u'DeleteItem') + u':%s_delete.png' % self.IconPath, + self.onDeleteClick, + u'%sDeleteItem' % self.PluginTextShort) ## Separator Line ## self.addToolbarSeparator() ## Preview ## self.addToolbarButton( translate( - self.TranslationContext, u'Preview ' + self.PluginTextShort), + self.TranslationContext, u'Preview %s' % self.PluginTextShort), translate(self.TranslationContext, u'Preview the selected item'), - u':/system/system_preview.png', self.onPreviewClick, u'PreviewItem') + u':/system/system_preview.png', + self.onPreviewClick, + u'PreviewItem') ## Live Button ## self.addToolbarButton( translate(self.TranslationContext, u'Go Live'), translate(self.TranslationContext, u'Send the selected item live'), - u':/system/system_live.png', self.onLiveClick, u'LiveItem') + u':/system/system_live.png', + self.onLiveClick, + u'LiveItem') ## Add to service Button ## self.addToolbarButton( translate( self.TranslationContext, - u'Add ' + self.PluginTextShort + u' To Service'), + u'Add %s to Service' % self.PluginTextShort), translate( self.TranslationContext, u'Add the selected item(s) to the service'), - u':/system/system_add.png', self.onAddClick, - self.PluginTextShort + u'AddItem') + u':/system/system_add.png', + self.onAddClick, + u'%sAddServiceItem' % self.PluginTextShort) def addListViewToToolBar(self): #Add the List widget diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index e880fb0c1..d114ab93c 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -180,6 +180,9 @@ class BibleMediaItem(MediaManagerItem): self.AdvancedSecondBibleComboBox = QtGui.QComboBox(self.AdvancedTab) self.AdvancedSecondBibleComboBox.setObjectName(u'SecondBible') self.AdvancedVerticalLayout.addWidget(self.AdvancedSecondBibleComboBox) + self.AdvancedMessage = QtGui.QLabel(self.QuickTab) + self.AdvancedMessage.setObjectName(u'AdvancedMessage') + self.AdvancedVerticalLayout.addWidget(self.AdvancedMessage) self.SearchTabWidget.addTab(self.AdvancedTab, u'Advanced') # Add the search tab widget to the page layout self.PageLayout.addWidget(self.SearchTabWidget) From cc71923682fe466cee1b144734a35bb9d0e00718 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Mon, 12 Oct 2009 11:18:54 +0100 Subject: [PATCH 2/7] Bible plugin clean up and Quick web setup --- openlp/core/utils/__init__.py | 2 +- openlp/plugins/bibles/lib/bibleDBimpl.py | 10 +- openlp/plugins/bibles/lib/common.py | 3 +- openlp/plugins/bibles/lib/manager.py | 49 ++++--- openlp/plugins/bibles/lib/mediaitem.py | 45 +++--- openlp/plugins/bibles/resources/httpbooks.csv | 132 +++++++++--------- 6 files changed, 136 insertions(+), 105 deletions(-) diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index de12084ea..d262305a5 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -38,7 +38,7 @@ def check_latest_version(config, current_version): if lastTest != thisTest: version_string = u'' req = urllib2.Request(u'http://www.openlp.org/files/version.txt') - req.add_header(u'User-Agent', u'Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)') + req.add_header(u'User-Agent', u'OpenLP Version Checker') try: handle = urllib2.urlopen(req, None, 1) html = handle.read() diff --git a/openlp/plugins/bibles/lib/bibleDBimpl.py b/openlp/plugins/bibles/lib/bibleDBimpl.py index a9e31e4f8..eac7ccd79 100644 --- a/openlp/plugins/bibles/lib/bibleDBimpl.py +++ b/openlp/plugins/bibles/lib/bibleDBimpl.py @@ -127,13 +127,19 @@ class BibleDBImpl(BibleCommon): verse = self.session.query(Verse).join(Book).filter( Book.name == bookname).filter( Verse.chapter == chapter).order_by(Verse.verse.desc()).first() - return verse.verse + if verse == None: + return 0 + else: + return verse.verse def get_max_bible_book_chapter(self, bookname): log.debug(u'get_max_bible_book_chapter %s', bookname) verse = self.session.query(Verse).join(Book).filter( Book.name == bookname).order_by(Verse.chapter.desc()).first() - return verse.chapter + if verse == None: + return 0 + else: + return verse.chapter def get_bible_book(self, bookname): log.debug(u'get_bible_book %s', bookname) diff --git a/openlp/plugins/bibles/lib/common.py b/openlp/plugins/bibles/lib/common.py index a13ba1781..e81814e46 100644 --- a/openlp/plugins/bibles/lib/common.py +++ b/openlp/plugins/bibles/lib/common.py @@ -104,7 +104,8 @@ class BibleCommon(object): urllib2.install_opener(opener) xml_string = u'' req = urllib2.Request(urlstring) - req.add_header(u'User-Agent', u'Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)') + #May us look like an IE Browser on XP to stop blocking by web site + req.add_header(u'User-Agent', u'Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1)') try: handle = urllib2.urlopen(req) html = handle.read() diff --git a/openlp/plugins/bibles/lib/manager.py b/openlp/plugins/bibles/lib/manager.py index 583a11360..bb0067e9f 100644 --- a/openlp/plugins/bibles/lib/manager.py +++ b/openlp/plugins/bibles/lib/manager.py @@ -25,6 +25,8 @@ import logging import os +from openlp.core.lib import translate + from bibleOSISimpl import BibleOSISImpl from bibleCSVimpl import BibleCSVImpl from bibleDBimpl import BibleDBImpl @@ -55,6 +57,7 @@ class BibleManager(object): """ self.config = config log.debug(u'Bible Initialising') + self.web = translate(u'BibleManager', u'Web') # dict of bible database objects self.bible_db_cache = None # dict of bible http readers @@ -83,6 +86,8 @@ class BibleManager(object): self.bible_http_cache = {} # books of the bible with testaments self.book_testaments = {} + # books of the bible with chapter count + self.book_chapters = [] # books of the bible with abbreviation self.book_abbreviations = {} self.web_bibles_present = False @@ -126,6 +131,7 @@ class BibleManager(object): p = line.split(u',') self.book_abbreviations[p[0]] = p[1].replace(u'\n', '') self.book_testaments[p[0]] = p[2].replace(u'\n', '') + self.book_chapters.append({u'book':p[0], u'total':p[3].replace(u'\n', '')}) log.debug(u'Bible Initialised') def process_dialog(self, dialogobject): @@ -247,33 +253,34 @@ class BibleManager(object): ``BibleMode.Full`` this method returns all the Bibles for the Advanced Search, and when the mode is ``BibleMode.Partial`` this method returns all the bibles for the Quick Search. - -c """ log.debug(u'get_bibles') bible_list = [] for bible_name, bible_object in self.bible_db_cache.iteritems(): - if mode == BibleMode.Full: - bible_list.append(bible_name) - else: - if self.bible_http_cache[bible_name] is None: - # we do not have an http bible - bible_list.append(bible_name) + if self.bible_http_cache[bible_name] is not None: + bible_name = u'%s (%s)' % (bible_name, self.web) + bible_list.append(bible_name) return bible_list - def get_bible_books(self,bible): - """ - Returns a list of the books of the bible from the database - """ - log.debug(u'get_bible_books %s', bible) - return self.bible_db_cache[bible].get_bible_books() + def is_bible_web(self, bible): + pos_end = bible.find(u' (%s)' % self.web) + if pos_end != -1: + return True, bible[:pos_end] + return False, bible - def get_book_chapter_count(self, bible, book): + def get_bible_books(self): + """ + Returns a list of the books of the bible + """ + log.debug(u'get_bible_books') + return self.book_chapters + + def get_book_chapter_count(self, book): """ Returns the number of Chapters for a given book """ - log.debug(u'get_book_chapter_count %s, %s', bible, book) - return self.bible_db_cache[bible].get_max_bible_book_chapter(book) + log.debug(u'get_book_chapter_count %s', book) + return self.book_chapters[book] def get_book_verse_count(self, bible, book, chapter): """ @@ -281,8 +288,12 @@ c book and chapterMaxBibleBookVerses """ log.debug(u'get_book_verse_count %s,%s,%s', bible, book, chapter) - return self.bible_db_cache[bible].get_max_bible_book_verses( - book, chapter) + web, bible = self.is_bible_web(bible) + if web: + return int(99) + else: + return self.bible_db_cache[bible].get_max_bible_book_verses( + book, chapter) def get_verse_from_text(self, bible, versetext): """ diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index d114ab93c..beb4bfdc1 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -54,7 +54,8 @@ class BibleMediaItem(MediaManagerItem): self.ServiceItemIconName = u':/media/bible_image.png' self.servicePath = None MediaManagerItem.__init__(self, parent, icon, title) - self.search_results = {} # place to store the search results + # place to store the search results + self.search_results = {} QtCore.QObject.connect(Receiver().get_receiver(), QtCore.SIGNAL(u'openlpreloadbibles'), self.reloadBibles) @@ -245,6 +246,7 @@ class BibleMediaItem(MediaManagerItem): def setQuickMessage(self, text): self.QuickMessage.setText(translate(u'BibleMediaItem', unicode(text))) + self.AdvancedMessage.setText(translate(u'BibleMediaItem', unicode(text))) Receiver().send_message(u'process_events') #minor delay to get the events processed time.sleep(0.1) @@ -279,9 +281,11 @@ class BibleMediaItem(MediaManagerItem): unicode(self.AdvancedVersionComboBox.currentText())) def onAdvancedBookComboBox(self): + item = int(self.AdvancedBookComboBox.currentIndex()) self.initialiseChapterVerse( unicode(self.AdvancedVersionComboBox.currentText()), - unicode(self.AdvancedBookComboBox.currentText())) + unicode(self.AdvancedBookComboBox.currentText()), + self.AdvancedBookComboBox.itemData(item).toInt()[0]) def onNewClick(self): self.bibleimportform = BibleImportForm( @@ -435,30 +439,39 @@ class BibleMediaItem(MediaManagerItem): def initialiseBible(self, bible): log.debug(u'initialiseBible %s', bible) - books = self.parent.biblemanager.get_bible_books(unicode(bible)) + book_data = self.parent.biblemanager.get_bible_books() self.AdvancedBookComboBox.clear() first = True - for book in books: - self.AdvancedBookComboBox.addItem(book.name) + for book in book_data: + row = self.AdvancedBookComboBox.count() + self.AdvancedBookComboBox.addItem(book[u'book']) + self.AdvancedBookComboBox.setItemData(row, QtCore.QVariant(book[u'total'])) if first: first = False - self.initialiseChapterVerse(bible, book.name) + self.initialiseChapterVerse(bible, book[u'book'], book[u'total']) - def initialiseChapterVerse(self, bible, book): + def initialiseChapterVerse(self, bible, book, chapters): log.debug(u'initialiseChapterVerse %s, %s', bible, book) - self.chapters_from = self.parent.biblemanager.get_book_chapter_count( - bible, book) + print bible , book , chapters + self.chapters_from = chapters self.verses = self.parent.biblemanager.get_book_verse_count(bible, book, 1) - self.adjustComboBox(1, self.chapters_from, self.AdvancedFromChapter) - self.adjustComboBox(1, self.chapters_from, self.AdvancedToChapter) - self.adjustComboBox(1, self.verses, self.AdvancedFromVerse) - self.adjustComboBox(1, self.verses, self.AdvancedToVerse) + if self.verses == 0: + self.AdvancedSearchButton.setEnabled(False) + self.AdvancedMessage.setText( + translate(u'BibleMediaItem', u'Bible not fully loaded')) + else: + self.AdvancedSearchButton.setEnabled(True) + self.AdvancedMessage.setText(u'') + self.adjustComboBox(1, self.chapters_from, self.AdvancedFromChapter) + self.adjustComboBox(1, self.chapters_from, self.AdvancedToChapter) + self.adjustComboBox(1, self.verses, self.AdvancedFromVerse) + self.adjustComboBox(1, self.verses, self.AdvancedToVerse) - def adjustComboBox(self, frm, to, combo): - log.debug(u'adjustComboBox %s, %s, %s', combo, frm, to) + def adjustComboBox(self, range_from, range_to, combo): + log.debug(u'adjustComboBox %s, %s, %s', combo, range_from, range_to) combo.clear() - for i in range(int(frm), int(to) + 1): + for i in range(int(range_from), int(range_to) + 1): combo.addItem(unicode(i)) def displayResults(self, bible): diff --git a/openlp/plugins/bibles/resources/httpbooks.csv b/openlp/plugins/bibles/resources/httpbooks.csv index d8d12d9ff..2d8afa20e 100644 --- a/openlp/plugins/bibles/resources/httpbooks.csv +++ b/openlp/plugins/bibles/resources/httpbooks.csv @@ -1,66 +1,66 @@ -Genesis,ge,1 -Exodus,ex,1 -Leviticus,le,1 -Numbers,nu,1 -Deuteronomy,de,1 -Joshua,jos,1 -Judges,jud,1 -Ruth,ru,1 -1 Samual,1sa,1 -2 Samual,2sa,1 -1 Kings,1ki,1 -2 Kings,2ki,1 -1 Chronicles,1ch,1 -2 Chronicles,2ch,1 -Ezra,ezr,1 -Nehemiah,ne,1 -Esther,es,1 -Job,job,1 -Psalms,ps,1 -Proverbs,pr,1 -Ecclesiastes,ec,1 -Song of Songs,so,1 -Isaiah,isa,1 -Jeremiah,jer,1 -Lamentations,la,1 -Ezekiel,exe,1 -Daniel,da,1 -Hosea,ho,1 -Joel,joe,1 -Amos,am,1 -Obad,ob,1 -Jonah,Jonah,1 -Micah,mic,1 -Naham,na,1 -Habakkuk,hab,1 -Zephaniah,zep,1 -Haggai,hag,1 -Zechariah,zec,1 -Malachi,mal,1 -Matthew,mt,2 -Mark,mk,2 -Luke,lu,2 -John,joh,2 -Acts,ac,2 -Romans,ro,2 -1 Corinthans,1co,2 -2 Corinthans,2co,2 -Galatians,ga,2 -Ephesians,eph,2 -Philippians,php,2 -Colossians,col,2 -1 Thessalonians,1th,2 -2 Thessalonians,2th,2 -1 Timothy,1ti,2 -2 Timothy,2ti,2 -Titus,tit,2 -Philemon,phm,2 -Hebrews,heb,2 -James,jas,2 -1 Peter,1pe,2 -2 Peter,2pe,2 -1 John,1jo,2 -2 John,2jo,2 -3 John,3jo,2 -Jude,jude,2 -Revelation,re,2 +Genesis,Gen,1,50 +Exodus,Exod,1,40 +Leviticus,Lev,1,27 +Numbers,Num,1,36 +Deuteronomy,Deut,1,34 +Joshua,Josh,1,24 +Judges,Judg,1,21 +Ruth,Ruth,1,4 +1 Samual,1Sam,1,31 +2 Samual,2Sam,1,24 +1 Kings,1Kgs,1,22 +2 Kings,2Kgs,1,25 +1 Chronicles,1Chr,1,29 +2 Chronicles,2Chr,1,36 +Ezra,Esra,1,10 +Nehemiah,Neh,1,13 +Esther,Esth,1,10 +Job,Job,1,42 +Psalms,Ps,1,150 +Proverbs,Prov,1,31 +Ecclesiastes,Eccl,1,12 +Song of Songs,Song,1,8 +Isaiah,Isa,1,66 +Jeremiah,Jer,1,5 +Lamentations,Lam,1,5 +Ezekiel,Ezek,1,48 +Daniel,Dan,1,12 +Hosea,Hos,1,14 +Joel,Joel,1,3 +Amos,Amos,1,9 +Obad,Obad,1,1 +Jonah,Jonah,1,4 +Micah,Mic,1,7 +Naham,Nah,1,3 +Habakkuk,Hab,1,3 +Zephaniah,Zeph,1,3 +Haggai,Hag,1,2 +Zechariah,Zech,1,3 +Malachi,Mal,1,4 +Matthew,Matt,2,28 +Mark,Mark,2,16 +Luke,Luke,2,24 +John,John,2,21 +Acts,Acts,2,28 +Romans,Rom,2,16 +1 Corinthans,1Cor,2,16 +2 Corinthans,2Cor,2,13 +Galatians,Gal,2,6 +Ephesians,Eph,2,6 +Philippians,Phil,2,4 +Colossians,Col,2,4 +1 Thessalonians,1Thess,2,5 +2 Thessalonians,2Thess,2,3 +1 Timothy,1Tim,2,6 +2 Timothy,2Tim,2,4 +Titus,Titus,2,3 +Philemon,Phlm,2,1 +Hebrews,Heb,2,13 +James,Jas,2,5 +1 Peter,1Pet,2,5 +2 Peter,2Pet,2,3 +1 John,1John,2,5 +2 John,2John,2,1 +3 John,3John,2,1 +Jude,Jude,2,1 +Revelation,Rev,2,22 From 0273fd508f0202f3d25275905990bc35a5530786 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Tue, 13 Oct 2009 20:24:27 +0100 Subject: [PATCH 3/7] Fix Logging exception in check_version --- openlp.pyw | 2 +- openlp/core/utils/__init__.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/openlp.pyw b/openlp.pyw index 203137e1f..6741cd1f6 100755 --- a/openlp.pyw +++ b/openlp.pyw @@ -35,7 +35,7 @@ from openlp.core.resources import qInitResources from openlp.core.ui import MainWindow, SplashScreen from openlp.core.utils import ConfigHelper -log = logging.getLogger() +log = logging.getLogger(__name__) class OpenLP(QtGui.QApplication): """ diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index d262305a5..bdc00c606 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -28,6 +28,8 @@ from datetime import datetime from registry import Registry from confighelper import ConfigHelper +log = logging.getLogger() + __all__ = ['Registry', 'ConfigHelper'] def check_latest_version(config, current_version): From 1bca1cf4cf54c0b810f97273825c73e55b0356dd Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Wed, 14 Oct 2009 06:08:36 +0100 Subject: [PATCH 4/7] More bible changes --- openlp/core/utils/__init__.py | 2 +- openlp/plugins/bibles/lib/manager.py | 11 ++++++++++- openlp/plugins/bibles/lib/mediaitem.py | 11 +++++------ 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index bdc00c606..02914aa90 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -28,7 +28,7 @@ from datetime import datetime from registry import Registry from confighelper import ConfigHelper -log = logging.getLogger() +log = logging.getLogger(__name__) __all__ = ['Registry', 'ConfigHelper'] diff --git a/openlp/plugins/bibles/lib/manager.py b/openlp/plugins/bibles/lib/manager.py index bb0067e9f..c0ff932a4 100644 --- a/openlp/plugins/bibles/lib/manager.py +++ b/openlp/plugins/bibles/lib/manager.py @@ -290,7 +290,13 @@ class BibleManager(object): log.debug(u'get_book_verse_count %s,%s,%s', bible, book, chapter) web, bible = self.is_bible_web(bible) if web: - return int(99) + count = self.bible_db_cache[bible].get_max_bible_book_verses( + book, chapter) + if count == 0: + text = self.get_verse_text(bible, book, chapter, chapter, 1, 1) + count = self.bible_db_cache[bible].get_max_bible_book_verses( + book, chapter) + return count else: return self.bible_db_cache[bible].get_max_bible_book_verses( book, chapter) @@ -301,6 +307,7 @@ class BibleManager(object): book and chapterMaxBibleBookVerses """ log.debug(u'get_verses_from_text %s,%s', bible, versetext) + web, bible = self.is_bible_web(bible) return self.bible_db_cache[bible].get_verses_from_text(versetext) def save_meta_data(self, bible, version, copyright, permissions): @@ -318,6 +325,7 @@ class BibleManager(object): Returns the meta data for a given key """ log.debug(u'get_meta %s,%s', bible, key) + web, bible = self.is_bible_web(bible) return self.bible_db_cache[bible].get_meta(key) def get_verse_text(self, bible, bookname, schapter, echapter, sverse, @@ -338,6 +346,7 @@ class BibleManager(object): bible, bookname, schapter, echapter, sverse, everse) # check to see if book/chapter exists fow HTTP bibles and load cache # if necessary + web, bible = self.is_bible_web(bible) if self.bible_http_cache[bible] is not None: book = self.bible_db_cache[bible].get_bible_book(bookname) if book is None: diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index beb4bfdc1..1526c49ac 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -298,14 +298,14 @@ class BibleMediaItem(MediaManagerItem): self.adjustComboBox(frm, self.verses, self.AdvancedToVerse) def onAdvancedToChapter(self): - text1 = self.AdvancedFromChapter.currentText() - text2 = self.AdvancedToChapter.currentText() + text1 = unicode(self.AdvancedFromChapter.currentText()) + text2 = unicode(self.AdvancedToChapter.currentText()) if text1 != text2: bible = unicode(self.AdvancedVersionComboBox.currentText()) book = unicode(self.AdvancedBookComboBox.currentText()) # get the verse count for new chapter verses = self.parent.biblemanager.get_book_verse_count( - bible, book, int(text2))[0] + bible, book, int(text2)) self.adjustComboBox(1, verses, self.AdvancedToVerse) def onAdvancedSearchButton(self): @@ -325,11 +325,10 @@ class BibleMediaItem(MediaManagerItem): def onAdvancedFromChapter(self): bible = unicode(self.AdvancedVersionComboBox.currentText()) book = unicode(self.AdvancedBookComboBox.currentText()) - cf = self.AdvancedFromChapter.currentText() + cf = int(self.AdvancedFromChapter.currentText()) self.adjustComboBox(cf, self.chapters_from, self.AdvancedToChapter) # get the verse count for new chapter - vse = self.parent.biblemanager.get_book_verse_count(bible, book, - int(cf))[0] + vse = self.parent.biblemanager.get_book_verse_count(bible, book, cf) self.adjustComboBox(1, vse, self.AdvancedFromVerse) self.adjustComboBox(1, vse, self.AdvancedToVerse) From dfe31f370d9b5c5216a4ef714bb1b0bc639f1c93 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Wed, 14 Oct 2009 06:13:09 +0100 Subject: [PATCH 5/7] More bible changes --- openlp/plugins/bibles/lib/manager.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/openlp/plugins/bibles/lib/manager.py b/openlp/plugins/bibles/lib/manager.py index c0ff932a4..5fd20b4af 100644 --- a/openlp/plugins/bibles/lib/manager.py +++ b/openlp/plugins/bibles/lib/manager.py @@ -294,8 +294,10 @@ class BibleManager(object): book, chapter) if count == 0: text = self.get_verse_text(bible, book, chapter, chapter, 1, 1) + print text count = self.bible_db_cache[bible].get_max_bible_book_verses( book, chapter) + print count return count else: return self.bible_db_cache[bible].get_max_bible_book_verses( From 6904ac214591a7d6bc117c2ff2ca438b5e7417a8 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Wed, 14 Oct 2009 17:27:46 +0100 Subject: [PATCH 6/7] Web Bibles to Advanced Tab complete for now --- openlp.pyw | 2 +- openlp/plugins/bibles/lib/manager.py | 2 -- openlp/plugins/bibles/lib/mediaitem.py | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/openlp.pyw b/openlp.pyw index 6741cd1f6..203137e1f 100755 --- a/openlp.pyw +++ b/openlp.pyw @@ -35,7 +35,7 @@ from openlp.core.resources import qInitResources from openlp.core.ui import MainWindow, SplashScreen from openlp.core.utils import ConfigHelper -log = logging.getLogger(__name__) +log = logging.getLogger() class OpenLP(QtGui.QApplication): """ diff --git a/openlp/plugins/bibles/lib/manager.py b/openlp/plugins/bibles/lib/manager.py index 5fd20b4af..c0ff932a4 100644 --- a/openlp/plugins/bibles/lib/manager.py +++ b/openlp/plugins/bibles/lib/manager.py @@ -294,10 +294,8 @@ class BibleManager(object): book, chapter) if count == 0: text = self.get_verse_text(bible, book, chapter, chapter, 1, 1) - print text count = self.bible_db_cache[bible].get_max_bible_book_verses( book, chapter) - print count return count else: return self.bible_db_cache[bible].get_max_bible_book_verses( diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index 1526c49ac..462e3c34a 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -451,7 +451,6 @@ class BibleMediaItem(MediaManagerItem): def initialiseChapterVerse(self, bible, book, chapters): log.debug(u'initialiseChapterVerse %s, %s', bible, book) - print bible , book , chapters self.chapters_from = chapters self.verses = self.parent.biblemanager.get_book_verse_count(bible, book, 1) From fa6cb6020aff6baa2118eb56246168f117004b32 Mon Sep 17 00:00:00 2001 From: Tim Bentley Date: Wed, 14 Oct 2009 19:27:44 +0100 Subject: [PATCH 7/7] fixes from merge --- openlp/core/lib/mediamanageritem.py | 2 +- openlp/core/utils/__init__.py | 2 +- openlp/plugins/bibles/lib/common.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index 0866137a6..2e151ebf4 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -239,7 +239,7 @@ class MediaManagerItem(QtGui.QWidget): if self.hasDeleteIcon: self.addToolbarButton( translate( - self.TranslationContext, u'Delete %s ' % self.PluginTextShort), + self.TranslationContext, u'Delete %s' % self.PluginTextShort), translate(self.TranslationContext, u'Delete the selected item'), u':%s_delete.png' % self.IconPath, self.onDeleteClick, diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index 02914aa90..305cdff35 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -40,7 +40,7 @@ def check_latest_version(config, current_version): if lastTest != thisTest: version_string = u'' req = urllib2.Request(u'http://www.openlp.org/files/version.txt') - req.add_header(u'User-Agent', u'OpenLP Version Checker') + req.add_header(u'User-Agent', u'OpenLP%s' % current_version) try: handle = urllib2.urlopen(req, None, 1) html = handle.read() diff --git a/openlp/plugins/bibles/lib/common.py b/openlp/plugins/bibles/lib/common.py index e81814e46..6d05f247e 100644 --- a/openlp/plugins/bibles/lib/common.py +++ b/openlp/plugins/bibles/lib/common.py @@ -104,7 +104,7 @@ class BibleCommon(object): urllib2.install_opener(opener) xml_string = u'' req = urllib2.Request(urlstring) - #May us look like an IE Browser on XP to stop blocking by web site + #Make us look like an IE Browser on XP to stop blocking by web site req.add_header(u'User-Agent', u'Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1)') try: handle = urllib2.urlopen(req)