From 0f23d12d72820f806b4fc6d4477c022024ebb779 Mon Sep 17 00:00:00 2001 From: Simon Hanna Date: Fri, 29 Dec 2017 11:27:58 +0100 Subject: [PATCH] Fix version checking if response is empty --- openlp/core/version.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/openlp/core/version.py b/openlp/core/version.py index 6ba1b9ecc..316de54d9 100644 --- a/openlp/core/version.py +++ b/openlp/core/version.py @@ -76,12 +76,12 @@ class VersionWorker(QtCore.QObject): """ log.debug('VersionWorker - Start') # I'm not entirely sure why this was here, I'm commenting it out until I hit the same scenario - time.sleep(1) - download_url = 'http://www.openlp.org/files/version.txt' + # time.sleep(1) + download_url = 'https://www.openlp.org/files/version.txt' if self.current_version['build']: - download_url = 'http://www.openlp.org/files/nightly_version.txt' + download_url = 'https://www.openlp.org/files/nightly_version.txt' elif int(self.current_version['version'].split('.')[1]) % 2 != 0: - download_url = 'http://www.openlp.org/files/dev_version.txt' + download_url = 'https://www.openlp.org/files/dev_version.txt' headers = { 'User-Agent': 'OpenLP/{version} {system}/{release}; '.format(version=self.current_version['full'], system=platform.system(), @@ -92,7 +92,7 @@ class VersionWorker(QtCore.QObject): while retries < 3: try: response = requests.get(download_url, headers=headers) - remote_version = response.text + remote_version = response.text.strip() log.debug('New version found: %s', remote_version) break except OSError: