From 1c4c2e363623c491750f85c75c4a62dc9bcd51a8 Mon Sep 17 00:00:00 2001 From: Martin Zibricky Date: Tue, 9 Apr 2013 11:53:42 +0200 Subject: [PATCH] Bug #1160506 - wrap url constructions into join_url() function. --- openlp/core/ui/firsttimeform.py | 24 ++++++++++++------------ openlp/core/utils/__init__.py | 20 ++++++++++++++++++++ 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/openlp/core/ui/firsttimeform.py b/openlp/core/ui/firsttimeform.py index 05837f04b..0742a92b6 100644 --- a/openlp/core/ui/firsttimeform.py +++ b/openlp/core/ui/firsttimeform.py @@ -42,7 +42,8 @@ from PyQt4 import QtCore, QtGui from openlp.core.lib import translate, PluginStatus, Receiver, build_icon, \ check_directory_exists from openlp.core.lib.settings import Settings -from openlp.core.utils import get_web_page, AppLocation, get_filesystem_encoding +from openlp.core.utils import get_web_page, AppLocation, join_url, \ + get_filesystem_encoding from firsttimewizard import Ui_FirstTimeWizard, FirstTimePage log = logging.getLogger(__name__) @@ -68,7 +69,8 @@ class ThemeScreenshotThread(QtCore.QThread): title = config.get(u'theme_%s' % theme, u'title') filename = config.get(u'theme_%s' % theme, u'filename') screenshot = config.get(u'theme_%s' % theme, u'screenshot') - urllib.urlretrieve(u'%s%s' % (self.parent().baseurl, themes_dir + '/' + screenshot), + urllib.urlretrieve(join_url(self.parent().baseurl, + themes_dir, screenshot), os.path.join(tmp_dir, screenshot)) item = QtGui.QListWidgetItem(title, self.parent().themesListWidget) item.setData(QtCore.Qt.UserRole, QtCore.QVariant(filename)) @@ -103,9 +105,6 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): files = self.webAccess.read() self.config.readfp(io.BytesIO(files)) self.baseurl = self.config.get(u'general', u'base url') - # Ensure url ends with '/'. - if not self.baseurl.endswith('/'): - self.baseurl += '/' self.updateScreenListCombo() self.downloadCancelled = False self.downloading = unicode(translate('OpenLP.FirstTimeWizard', @@ -144,7 +143,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): for song in songs: title = unicode(self.config.get( u'songs_%s' % song, u'title'), u'utf8') - filename = unicode(self.config.get( + filename = unicode(self.config.get( u'songs_%s' % song, u'filename'), u'utf8') item = QtGui.QListWidgetItem(title, self.songsListWidget) item.setData(QtCore.Qt.UserRole, QtCore.QVariant(filename)) @@ -374,7 +373,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): item = self.songsListWidget.item(i) if item.checkState() == QtCore.Qt.Checked: filename = item.data(QtCore.Qt.UserRole).toString() - size = self._getFileSize(u'%s%s/%s' % (self.baseurl, songs_dir, filename)) + size = self._getFileSize(join_url(self.baseurl, songs_dir, filename)) self.max_progress += size # Loop through the Bibles list and increase for each selected item iterator = QtGui.QTreeWidgetItemIterator(self.biblesTreeWidget) @@ -383,7 +382,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): item = iterator.value() if item.parent() and item.checkState(0) == QtCore.Qt.Checked: filename = item.data(0, QtCore.Qt.UserRole).toString() - size = self._getFileSize(u'%s%s/%s' % (self.baseurl, bibles_dir, filename)) + size = self._getFileSize(join_url(self.baseurl, bibles_dir, filename)) self.max_progress += size iterator += 1 # Loop through the themes list and increase for each selected item @@ -392,7 +391,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): item = self.themesListWidget.item(i) if item.checkState() == QtCore.Qt.Checked: filename = item.data(QtCore.Qt.UserRole).toString() - size = self._getFileSize(u'%s%s/%s' % (self.baseurl, themes_dir, filename)) + size = self._getFileSize(join_url(self.baseurl, themes_dir, filename)) self.max_progress += size if self.max_progress: # Add on 2 for plugins status setting plus a "finished" point. @@ -482,7 +481,8 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): self.previous_size = 0 destination = os.path.join(songs_destination, unicode(filename)) - self.urlGetFile(u'%s%s/%s' % (self.baseurl, songs_dir, filename), destination) + self.urlGetFile(join_url(self.baseurl, songs_dir, filename), + destination) # Download Bibles bibles_iterator = QtGui.QTreeWidgetItemIterator( self.biblesTreeWidget) @@ -492,7 +492,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): bible = unicode(item.data(0, QtCore.Qt.UserRole).toString()) self._incrementProgressBar(self.downloading % bible, 0) self.previous_size = 0 - self.urlGetFile(u'%s%s/%s' % (self.baseurl, bibles_dir, bible), + self.urlGetFile(join_url(self.baseurl, bibles_dir, bible), os.path.join(bibles_destination, bible)) bibles_iterator += 1 # Download themes @@ -502,7 +502,7 @@ class FirstTimeForm(QtGui.QWizard, Ui_FirstTimeWizard): theme = unicode(item.data(QtCore.Qt.UserRole).toString()) self._incrementProgressBar(self.downloading % theme, 0) self.previous_size = 0 - self.urlGetFile(u'%s%s/%s' % (self.baseurl, themes_dir, theme), + self.urlGetFile(join_url(self.baseurl, themes_dir, theme), os.path.join(themes_destination, theme)) # Set Default Display if self.displayComboBox.currentIndex() != -1: diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index 085760817..6f8bf610b 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -37,6 +37,7 @@ import re from subprocess import Popen, PIPE import sys import urllib2 +import urlparse from openlp.core.lib.settings import Settings @@ -364,6 +365,25 @@ def get_images_filter(): return IMAGES_FILTER +def join_url(base, *args): + """ + Join one or more url components with the base url. + + ``base`` + Base url containing top level domain. + e.g. http://www.example.org + + ``args`` + url components to be appended to the base url. + """ + # Remove leading and trailing slash from components. + # Also ensure QString is converted to unicode(). + args = [unicode(x).strip('/') for x in args] + url = urlparse.urljoin(base, '/'.join(args)) + print url + return url + + def split_filename(path): """ Return a list of the parts in a given path.