From 442dc7d0d284736e2ce775f29dfc78013a7d9612 Mon Sep 17 00:00:00 2001 From: Tomas Groth Date: Mon, 3 Feb 2020 23:03:24 +0000 Subject: [PATCH] Deregister screen-updates to the theme widget when it closes. Fixes #320. --- appveyor.yml | 2 +- openlp/core/ui/firsttimeform.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 3e8108688..707f6a0ef 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -15,7 +15,7 @@ environment: install: # Install dependencies from pypi - - "%PYTHON%\\python.exe -m pip install sqlalchemy alembic appdirs chardet beautifulsoup4 lxml Mako mysql-connector-python pytest mock pyodbc psycopg2 pypiwin32 websockets asyncio waitress six webob requests QtAwesome PyQt5 PyQtWebEngine pymediainfo PyMuPDF==1.16.7 QDarkStyle python-vlc Pyro4 zeroconf" + - "%PYTHON%\\python.exe -m pip install sqlalchemy alembic appdirs chardet beautifulsoup4 lxml Mako mysql-connector-python pytest mock pyodbc psycopg2 pypiwin32 websockets asyncio waitress six webob requests QtAwesome PyQt5 PyQtWebEngine pymediainfo PyMuPDF==1.16.7 QDarkStyle python-vlc Pyro4 zeroconf flask-cors" build: off diff --git a/openlp/core/ui/firsttimeform.py b/openlp/core/ui/firsttimeform.py index dbb10222c..c5bb3d1a3 100644 --- a/openlp/core/ui/firsttimeform.py +++ b/openlp/core/ui/firsttimeform.py @@ -308,6 +308,7 @@ class FirstTimeForm(QtWidgets.QWizard, UiFirstTimeWizard, RegistryProperties): self.screen_selection_widget.save() if self.theme_combo_box.currentIndex() != -1: Settings().setValue('themes/global theme', self.theme_combo_box.currentText()) + Registry().remove_function('config_screen_changed', self.screen_selection_widget.load) super().accept() def reject(self): @@ -326,6 +327,7 @@ class FirstTimeForm(QtWidgets.QWizard, UiFirstTimeWizard, RegistryProperties): while any([not is_thread_finished(thread_name) for thread_name in self.thumbnail_download_threads]): time.sleep(0.1) self.application.set_normal_cursor() + Registry().remove_function('config_screen_changed', self.screen_selection_widget.load) super().reject() def _on_custom_button_clicked(self, which):