From 55738636d9d1c91aff1621a665184bf61560c2d2 Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Mon, 16 May 2011 13:41:43 +0200 Subject: [PATCH 01/14] render the themes when the screen size changed --- openlp/core/ui/mainwindow.py | 1 + openlp/core/ui/thememanager.py | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/openlp/core/ui/mainwindow.py b/openlp/core/ui/mainwindow.py index 11727f4ae..2d56a2e0c 100644 --- a/openlp/core/ui/mainwindow.py +++ b/openlp/core/ui/mainwindow.py @@ -783,6 +783,7 @@ class MainWindow(QtGui.QMainWindow, Ui_MainWindow): self.renderer.update_display() self.liveController.screenSizeChanged() self.previewController.screenSizeChanged() + self.themeManagerContents.updatePreviewImages() self.setFocus() self.activateWindow() diff --git a/openlp/core/ui/thememanager.py b/openlp/core/ui/thememanager.py index e30c9dea3..1a9c71cab 100644 --- a/openlp/core/ui/thememanager.py +++ b/openlp/core/ui/thememanager.py @@ -660,6 +660,15 @@ class ThemeManager(QtGui.QWidget): pixmap.save(thumb, u'png') log.debug(u'Theme image written to %s', samplepathname) + def updatePreviewImages(self): + """ + Called to update the themes' preview images. + """ + for theme in self.themelist: + self.generateAndSaveImage( + self.path, theme, self.getThemeData(theme)) + self.loadThemes() + def generateImage(self, themeData, forcePage=False): """ Call the renderer to build a Sample Image From 7829de85978a177fa10237469c90aafec00727ba Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Mon, 16 May 2011 14:22:08 +0200 Subject: [PATCH 02/14] set cursor busy, update the preview images before the displays --- openlp/core/ui/mainwindow.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/openlp/core/ui/mainwindow.py b/openlp/core/ui/mainwindow.py index 593a3de05..1bb7f7bcf 100644 --- a/openlp/core/ui/mainwindow.py +++ b/openlp/core/ui/mainwindow.py @@ -778,17 +778,19 @@ class MainWindow(QtGui.QMainWindow, Ui_MainWindow): def screenChanged(self): """ - The screen has changed to so tell the displays to update_display - their locations + The screen has changed so we have to update components such as the + renderer. """ log.debug(u'screenChanged') + Receiver.send_message(u'cursor_busy') self.image_manager.update_display() self.renderer.update_display() - self.liveController.screenSizeChanged() - self.previewController.screenSizeChanged() self.themeManagerContents.updatePreviewImages() + self.previewController.screenSizeChanged() + self.liveController.screenSizeChanged() self.setFocus() self.activateWindow() + Receiver.send_message(u'cursor_normal') def closeEvent(self, event): """ From 875202decaf458b0fd45c3130c2ba9473c43901a Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Thu, 19 May 2011 08:01:28 +0200 Subject: [PATCH 03/14] reverted changes --- openlp/core/ui/mainwindow.py | 1 - openlp/core/ui/thememanager.py | 9 --------- 2 files changed, 10 deletions(-) diff --git a/openlp/core/ui/mainwindow.py b/openlp/core/ui/mainwindow.py index 1bb7f7bcf..695fc1c54 100644 --- a/openlp/core/ui/mainwindow.py +++ b/openlp/core/ui/mainwindow.py @@ -785,7 +785,6 @@ class MainWindow(QtGui.QMainWindow, Ui_MainWindow): Receiver.send_message(u'cursor_busy') self.image_manager.update_display() self.renderer.update_display() - self.themeManagerContents.updatePreviewImages() self.previewController.screenSizeChanged() self.liveController.screenSizeChanged() self.setFocus() diff --git a/openlp/core/ui/thememanager.py b/openlp/core/ui/thememanager.py index 1a9c71cab..e30c9dea3 100644 --- a/openlp/core/ui/thememanager.py +++ b/openlp/core/ui/thememanager.py @@ -660,15 +660,6 @@ class ThemeManager(QtGui.QWidget): pixmap.save(thumb, u'png') log.debug(u'Theme image written to %s', samplepathname) - def updatePreviewImages(self): - """ - Called to update the themes' preview images. - """ - for theme in self.themelist: - self.generateAndSaveImage( - self.path, theme, self.getThemeData(theme)) - self.loadThemes() - def generateImage(self, themeData, forcePage=False): """ Call the renderer to build a Sample Image From 206ee04db69f0cc7259713fa35c6fbfa964d5f32 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Thu, 19 May 2011 18:20:00 -0400 Subject: [PATCH 04/14] modified: openlp/plugins/custom/forms/editcustomform.py openlp/plugins/custom/lib/mediaitem.py openlp/plugins/songs/forms/editsongform.py openlp/plugins/songs/lib/mediaitem.py --- openlp/plugins/custom/forms/editcustomform.py | 2 ++ openlp/plugins/custom/lib/mediaitem.py | 12 +++++++++++- openlp/plugins/songs/forms/editsongform.py | 2 ++ openlp/plugins/songs/lib/mediaitem.py | 10 ++++++++++ 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/openlp/plugins/custom/forms/editcustomform.py b/openlp/plugins/custom/forms/editcustomform.py index 774789fa0..1d0e0427d 100644 --- a/openlp/plugins/custom/forms/editcustomform.py +++ b/openlp/plugins/custom/forms/editcustomform.py @@ -114,6 +114,8 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): def accept(self): log.debug(u'accept') if self.saveCustom(): + Receiver.send_message(u'custom_set_autoselect_item', + self.customSlide.title) Receiver.send_message(u'custom_load_list') QtGui.QDialog.accept(self) diff --git a/openlp/plugins/custom/lib/mediaitem.py b/openlp/plugins/custom/lib/mediaitem.py index 66b1c3675..7e1298bd8 100644 --- a/openlp/plugins/custom/lib/mediaitem.py +++ b/openlp/plugins/custom/lib/mediaitem.py @@ -62,6 +62,7 @@ class CustomMediaItem(MediaManagerItem): # which Custom is required. self.remoteCustom = -1 self.manager = parent.manager + self.setAutoSelectItem() def addEndHeaderBar(self): self.addToolbarSeparator() @@ -105,6 +106,9 @@ class CustomMediaItem(MediaManagerItem): QtCore.SIGNAL(u'custom_edit_clear'), self.onRemoteEditClear) QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'custom_load_list'), self.initialise) + QtCore.QObject.connect(Receiver.get_receiver(), + QtCore.SIGNAL(u'custom_set_autoselect_item'), + self.setAutoSelectItem) QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'custom_preview'), self.onPreviewClick) @@ -140,10 +144,16 @@ class CustomMediaItem(MediaManagerItem): custom_name.setData( QtCore.Qt.UserRole, QtCore.QVariant(customSlide.id)) self.listView.addItem(custom_name) + # Auto-select the item if name has been set + if customSlide.title == self.autoSelectItem : + self.listView.setCurrentItem(custom_name) + + def setAutoSelectItem(self,itemToSelect="*"): + self.autoSelectItem = itemToSelect def onNewClick(self): self.parent.edit_custom_form.loadCustom(0) - self.parent.edit_custom_form.exec_() + self.parent.edit_custom_fom.exec_() self.initialise() def onRemoteEditClear(self): diff --git a/openlp/plugins/songs/forms/editsongform.py b/openlp/plugins/songs/forms/editsongform.py index 297318d53..6155145f8 100644 --- a/openlp/plugins/songs/forms/editsongform.py +++ b/openlp/plugins/songs/forms/editsongform.py @@ -695,6 +695,8 @@ class EditSongForm(QtGui.QDialog, Ui_EditSongDialog): self.clearCaches() if self._validate_song(): self.saveSong() + Receiver.send_message(u'songs_set_autoselect_item', + unicode(self.titleEdit.text())) Receiver.send_message(u'songs_load_list') QtGui.QDialog.accept(self) diff --git a/openlp/plugins/songs/lib/mediaitem.py b/openlp/plugins/songs/lib/mediaitem.py index 5f961b2f2..1f7987569 100644 --- a/openlp/plugins/songs/lib/mediaitem.py +++ b/openlp/plugins/songs/lib/mediaitem.py @@ -73,6 +73,7 @@ class SongMediaItem(MediaManagerItem): self.editItem = None self.quickPreviewAllowed = True self.hasSearch = True + self.setAutoSelectItem() def addEndHeaderBar(self): self.addToolbarSeparator() @@ -123,6 +124,9 @@ class SongMediaItem(MediaManagerItem): QtCore.QObject.connect(self.searchTextEdit, QtCore.SIGNAL(u'searchTypeChanged(int)'), self.onSearchTextButtonClick) + QtCore.QObject.connect(Receiver.get_receiver(), + QtCore.SIGNAL(u'songs_set_autoselect_item'), + self.setAutoSelectItem) def configUpdated(self): self.searchAsYouType = QtCore.QSettings().value( @@ -159,6 +163,9 @@ class SongMediaItem(MediaManagerItem): QtCore.QVariant(SongSearch.Entire)).toInt()[0]) self.configUpdated() + def setAutoSelectItem(self,itemToSelect="*"): + self.autoSelectItem = itemToSelect + def onSearchTextButtonClick(self): # Save the current search type to the configuration. QtCore.QSettings().setValue(u'%s/last search type' % @@ -237,6 +244,9 @@ class SongMediaItem(MediaManagerItem): song_name = QtGui.QListWidgetItem(song_detail) song_name.setData(QtCore.Qt.UserRole, QtCore.QVariant(song.id)) self.listView.addItem(song_name) + # Auto-select the item if name has been set + if song.title == self.autoSelectItem : + self.listView.setCurrentItem(song_name) def displayResultsAuthor(self, searchresults): log.debug(u'display results Author') From af5fdcf73d9fbad681ec98dd34bd8183cd331837 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Thu, 19 May 2011 18:34:46 -0400 Subject: [PATCH 05/14] modified: openlp/plugins/custom/lib/mediaitem.py --- openlp/plugins/custom/lib/mediaitem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openlp/plugins/custom/lib/mediaitem.py b/openlp/plugins/custom/lib/mediaitem.py index 7e1298bd8..f81cc3a2c 100644 --- a/openlp/plugins/custom/lib/mediaitem.py +++ b/openlp/plugins/custom/lib/mediaitem.py @@ -153,7 +153,7 @@ class CustomMediaItem(MediaManagerItem): def onNewClick(self): self.parent.edit_custom_form.loadCustom(0) - self.parent.edit_custom_fom.exec_() + self.parent.edit_custom_form.exec_() self.initialise() def onRemoteEditClear(self): From c4b08629794cb5d1c83445b5df6c1c19bc90a340 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Fri, 20 May 2011 01:01:49 -0400 Subject: [PATCH 06/14] modified: openlp/core/lib/mediamanageritem.py openlp/core/ui/slidecontroller.py --- openlp/core/lib/mediamanageritem.py | 4 ++-- openlp/core/ui/slidecontroller.py | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index cbd2caadc..432efe749 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -113,7 +113,6 @@ class MediaManagerItem(QtGui.QWidget): self.retranslateUi() QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'%s_service_load' % self.parent.name.lower()), - self.serviceLoad) def requiredIcons(self): """ @@ -499,10 +498,11 @@ class MediaManagerItem(QtGui.QWidget): """ Add a selected item to the current service """ + print "OnAddClick" if not self.listView.selectedIndexes() and not self.remoteTriggered: QtGui.QMessageBox.information(self, UiStrings().NISp, translate('OpenLP.MediaManagerItem', - 'You must select one or more items.')) + 'You must select one or more items to add.')) else: # Is it posssible to process multiple list items to generate # multiple service items? diff --git a/openlp/core/ui/slidecontroller.py b/openlp/core/ui/slidecontroller.py index c298f897f..21376cdc5 100644 --- a/openlp/core/ui/slidecontroller.py +++ b/openlp/core/ui/slidecontroller.py @@ -210,6 +210,11 @@ class SlideController(QtGui.QWidget): u'Go Live', u':/general/general_live.png', translate('OpenLP.SlideController', 'Move to live'), self.onGoLive) + self.toolbar.addToolbarButton( + # Does not need translating - control string. + u'Add to Service', u':/general/general_add.png', + translate('OpenLP.SlideController', 'Add to Service'), + self.onPreviewAddToService) self.toolbar.addToolbarSeparator(u'Close Separator') self.toolbar.addToolbarButton( # Does not need translating - control string. @@ -1044,6 +1049,12 @@ class SlideController(QtGui.QWidget): Receiver.send_message(u'%s_edit' % self.serviceItem.name.lower(), u'P:%s' % self.serviceItem.edit_id) + def onPreviewAddToService(self): + """ + From the preview display request the Item to be added to service + """ + Receiver.send_message(u'%s_add_service_item' % self.serviceItem.name) + def onGoLiveClick(self): """ triggered by clicking the Preview slide items From 00a2a7b77170285dbc7fb358199b289ebf837439 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Fri, 20 May 2011 01:19:26 -0400 Subject: [PATCH 07/14] modified: openlp/core/lib/mediamanageritem.py --- openlp/core/lib/mediamanageritem.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index 432efe749..706e309b8 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -498,7 +498,6 @@ class MediaManagerItem(QtGui.QWidget): """ Add a selected item to the current service """ - print "OnAddClick" if not self.listView.selectedIndexes() and not self.remoteTriggered: QtGui.QMessageBox.information(self, UiStrings().NISp, translate('OpenLP.MediaManagerItem', From 304f4ff732ed4b96fb9d59fb6cdfddd59cb946b2 Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Fri, 20 May 2011 13:45:39 +0200 Subject: [PATCH 08/14] added menu entry to update the theme images --- openlp/core/ui/mainwindow.py | 16 ++++++++++++++++ openlp/core/ui/thememanager.py | 25 +++++++++++++++++++++++++ openlp/core/utils/__init__.py | 2 +- 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/openlp/core/ui/mainwindow.py b/openlp/core/ui/mainwindow.py index 695fc1c54..167fcdd4a 100644 --- a/openlp/core/ui/mainwindow.py +++ b/openlp/core/ui/mainwindow.py @@ -229,6 +229,8 @@ class Ui_MainWindow(object): self.ToolsOpenDataFolder = icon_action(mainWindow, u'ToolsOpenDataFolder', u':/general/general_open.png', category=UiStrings().Tools) + self.updateThemeImages = base_action(mainWindow, + u'updateThemeImages', category=UiStrings().Tools) action_list.add_category(UiStrings().Settings, CategoryOrder.standardMenu) self.settingsPluginListItem = shortcut_action(mainWindow, u'settingsPluginListItem', [QtGui.QKeySequence(u'Alt+F7')], @@ -292,6 +294,7 @@ class Ui_MainWindow(object): self.SettingsConfigureItem)) add_actions(self.ToolsMenu, (self.ToolsAddToolItem, None)) add_actions(self.ToolsMenu, (self.ToolsOpenDataFolder, None)) + add_actions(self.ToolsMenu, [self.updateThemeImages]) add_actions(self.HelpMenu, (self.HelpDocumentationItem, self.HelpOnlineHelpItem, None, self.helpWebSiteItem, self.HelpAboutItem)) @@ -433,6 +436,11 @@ class Ui_MainWindow(object): translate('OpenLP.MainWindow', 'Open &Data Folder...')) self.ToolsOpenDataFolder.setStatusTip(translate('OpenLP.MainWindow', 'Open the folder where songs, bibles and other data resides.')) + self.updateThemeImages.setText( + translate('OpenLP.MainWindow', 'Update Theme Images')) + self.updateThemeImages.setStatusTip( + translate('OpenLP.MainWindow', 'Update the preview images for all ' + 'themes.')) self.ModeDefaultItem.setText( translate('OpenLP.MainWindow', '&Default')) self.ModeDefaultItem.setStatusTip(translate('OpenLP.MainWindow', @@ -505,6 +513,8 @@ class MainWindow(QtGui.QMainWindow, Ui_MainWindow): QtCore.SIGNAL(u'triggered()'), self.onHelpOnLineHelpClicked) QtCore.QObject.connect(self.ToolsOpenDataFolder, QtCore.SIGNAL(u'triggered()'), self.onToolsOpenDataFolderClicked) + QtCore.QObject.connect(self.updateThemeImages, + QtCore.SIGNAL(u'triggered()'), self.onUpdateThemeImages) QtCore.QObject.connect(self.DisplayTagItem, QtCore.SIGNAL(u'triggered()'), self.onDisplayTagItemClicked) QtCore.QObject.connect(self.SettingsConfigureItem, @@ -717,6 +727,12 @@ class MainWindow(QtGui.QMainWindow, Ui_MainWindow): path = AppLocation.get_data_path() QtGui.QDesktopServices.openUrl(QtCore.QUrl("file:///" + path)) + def onUpdateThemeImages(self): + """ + Updates the new theme preview images. + """ + self.themeManagerContents.updatePreviewImages() + def onDisplayTagItemClicked(self): """ Show the Settings dialog diff --git a/openlp/core/ui/thememanager.py b/openlp/core/ui/thememanager.py index e30c9dea3..4b2de8500 100644 --- a/openlp/core/ui/thememanager.py +++ b/openlp/core/ui/thememanager.py @@ -660,6 +660,31 @@ class ThemeManager(QtGui.QWidget): pixmap.save(thumb, u'png') log.debug(u'Theme image written to %s', samplepathname) + def updatePreviewImages(self): + """ + Called to update the themes' preview images. + """ + progressDialog = QtGui.QProgressDialog(self.mainwindow) + progressDialog.setWindowModality(QtCore.Qt.WindowModal) + progressDialog.setLabelText( + translate('OpenLP.ThemeManager', 'Starting update...', + 'Shown when you update the theme images.')) + progressDialog.setCancelButton(None) + progressDialog.setRange(0, len(self.themelist)) + progressDialog.setMinimumDuration(0) + progressDialog.forceShow() + Receiver.send_message(u'openlp_process_events') + for index, theme in enumerate(self.themelist): + progressDialog.setValue(index) + progressDialog.setLabelText(unicode(translate('OpenLP.ThemeManager', + 'Updating %s...', + 'Shown when you update the theme images.')) % theme) + Receiver.send_message(u'openlp_process_events') + self.generateAndSaveImage( + self.path, theme, self.getThemeData(theme)) + progressDialog.setValue(len(self.themelist)) + self.loadThemes() + def generateImage(self, themeData, forcePage=False): """ Call the renderer to build a Sample Image diff --git a/openlp/core/utils/__init__.py b/openlp/core/utils/__init__.py index 3051301d6..c5c08fad4 100644 --- a/openlp/core/utils/__init__.py +++ b/openlp/core/utils/__init__.py @@ -342,7 +342,7 @@ def add_actions(target, actions): The menu or toolbar to add actions to. ``actions`` - The actions to be added. An action consisting of the keyword 'None' + The actions to be added. An action consisting of the keyword ``None`` will result in a separator being inserted into the target. """ for action in actions: From 383670e446cc4f25ce2823d18f69fd25b36189ae Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Fri, 20 May 2011 17:00:27 +0200 Subject: [PATCH 09/14] use the awesome mainwindow progress bar --- openlp/core/ui/thememanager.py | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/openlp/core/ui/thememanager.py b/openlp/core/ui/thememanager.py index 4b2de8500..190939ab9 100644 --- a/openlp/core/ui/thememanager.py +++ b/openlp/core/ui/thememanager.py @@ -664,25 +664,12 @@ class ThemeManager(QtGui.QWidget): """ Called to update the themes' preview images. """ - progressDialog = QtGui.QProgressDialog(self.mainwindow) - progressDialog.setWindowModality(QtCore.Qt.WindowModal) - progressDialog.setLabelText( - translate('OpenLP.ThemeManager', 'Starting update...', - 'Shown when you update the theme images.')) - progressDialog.setCancelButton(None) - progressDialog.setRange(0, len(self.themelist)) - progressDialog.setMinimumDuration(0) - progressDialog.forceShow() - Receiver.send_message(u'openlp_process_events') - for index, theme in enumerate(self.themelist): - progressDialog.setValue(index) - progressDialog.setLabelText(unicode(translate('OpenLP.ThemeManager', - 'Updating %s...', - 'Shown when you update the theme images.')) % theme) - Receiver.send_message(u'openlp_process_events') + self.mainwindow.displayProgressBar(len(self.themelist)) + for theme in self.themelist: + self.mainwindow.incrementProgressBar() self.generateAndSaveImage( self.path, theme, self.getThemeData(theme)) - progressDialog.setValue(len(self.themelist)) + self.mainwindow.finishedProgressBar() self.loadThemes() def generateImage(self, themeData, forcePage=False): From a5a8c0d6d28527fbef779a307fe3222c19965722 Mon Sep 17 00:00:00 2001 From: Gerald Britton Date: Fri, 20 May 2011 12:34:44 -0400 Subject: [PATCH 10/14] Fix Words of Worship import to issue error message for files missing the expected header --- openlp/plugins/songs/lib/wowimport.py | 1 + 1 file changed, 1 insertion(+) diff --git a/openlp/plugins/songs/lib/wowimport.py b/openlp/plugins/songs/lib/wowimport.py index f5293a53c..56f461f8b 100644 --- a/openlp/plugins/songs/lib/wowimport.py +++ b/openlp/plugins/songs/lib/wowimport.py @@ -110,6 +110,7 @@ class WowImport(SongImport): self.title = file_name.rpartition(u'.')[0] songData = open(file, 'rb') if songData.read(19) != u'WoW File\nSong Words': + self.log_error(file) continue # Seek to byte which stores number of blocks in the song songData.seek(56) From 31c1d23070a8ba5964cdd7731a011a6ab7aa6712 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Fri, 20 May 2011 17:30:28 -0400 Subject: [PATCH 11/14] modified: openlp/core/lib/mediamanageritem.py openlp/core/ui/slidecontroller.py --- openlp/core/lib/mediamanageritem.py | 3 ++- openlp/core/ui/slidecontroller.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index 706e309b8..a47dbccd2 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -113,10 +113,11 @@ class MediaManagerItem(QtGui.QWidget): self.retranslateUi() QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'%s_service_load' % self.parent.name.lower()), + self.serviceLoad) def requiredIcons(self): """ - This method is called to define the icons for the plugin. + Tis method is called to define the icons for the plugin. It provides a default set and the plugin is able to override the if required. """ diff --git a/openlp/core/ui/slidecontroller.py b/openlp/core/ui/slidecontroller.py index 21376cdc5..0f22883f7 100644 --- a/openlp/core/ui/slidecontroller.py +++ b/openlp/core/ui/slidecontroller.py @@ -1053,7 +1053,8 @@ class SlideController(QtGui.QWidget): """ From the preview display request the Item to be added to service """ - Receiver.send_message(u'%s_add_service_item' % self.serviceItem.name) + self.serviceItem.from_plugin = False + self.parent.serviceManager.addServiceItem(self.serviceItem) def onGoLiveClick(self): """ From cfe1903883f5c5f2a9bf0dbb5f0ffdaa771e9110 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Sat, 21 May 2011 16:21:05 -0400 Subject: [PATCH 12/14] modified: openlp/core/ui/servicemanager.py openlp/core/ui/slidecontroller.py --- openlp/core/ui/servicemanager.py | 2 -- openlp/core/ui/slidecontroller.py | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/openlp/core/ui/servicemanager.py b/openlp/core/ui/servicemanager.py index 3c9938f1d..358877cc7 100644 --- a/openlp/core/ui/servicemanager.py +++ b/openlp/core/ui/servicemanager.py @@ -286,8 +286,6 @@ class ServiceManager(QtGui.QWidget): QtCore.SIGNAL(u'theme_update_global'), self.themeChange) QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'service_item_update'), self.serviceItemUpdate) - QtCore.QObject.connect(Receiver.get_receiver(), - QtCore.SIGNAL(u'preview_add_service_item'), self.addServiceItem) # Last little bits of setting up self.service_theme = unicode(QtCore.QSettings().value( self.mainwindow.serviceSettingsSection + u'/service theme', diff --git a/openlp/core/ui/slidecontroller.py b/openlp/core/ui/slidecontroller.py index 6f029fdf7..a88215428 100644 --- a/openlp/core/ui/slidecontroller.py +++ b/openlp/core/ui/slidecontroller.py @@ -1053,8 +1053,7 @@ class SlideController(QtGui.QWidget): """ From the preview display request the Item to be added to service """ - self.serviceItem.from_plugin = False - Receiver.send_message('preview_add_service_item',self.serviceItem) + self.parent.ServiceManagerContents.addServiceItem(self.serviceItem) def onGoLiveClick(self): """ From c9481e034e31c46d09284056ce7a3ec8204574e8 Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Sat, 21 May 2011 16:29:43 -0400 Subject: [PATCH 13/14] modified: openlp/core/lib/mediamanageritem.py --- openlp/core/lib/mediamanageritem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index dd4417093..d41947b48 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -120,7 +120,7 @@ class MediaManagerItem(QtGui.QWidget): def requiredIcons(self): """ - Tis method is called to define the icons for the plugin. + This method is called to define the icons for the plugin. It provides a default set and the plugin is able to override the if required. """ From 08932ad664572fa7ba5a55ab7f82055b0ad7028e Mon Sep 17 00:00:00 2001 From: Stevan Pettit Date: Sat, 21 May 2011 21:29:09 -0400 Subject: [PATCH 14/14] modified: openlp/core/lib/mediamanageritem.py openlp/plugins/custom/lib/mediaitem.py openlp/plugins/songs/lib/mediaitem.py --- openlp/core/lib/mediamanageritem.py | 1 + openlp/plugins/custom/lib/mediaitem.py | 1 - openlp/plugins/songs/lib/mediaitem.py | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/openlp/core/lib/mediamanageritem.py b/openlp/core/lib/mediamanageritem.py index d41947b48..f57740fad 100644 --- a/openlp/core/lib/mediamanageritem.py +++ b/openlp/core/lib/mediamanageritem.py @@ -111,6 +111,7 @@ class MediaManagerItem(QtGui.QWidget): self.requiredIcons() self.setupUi() self.retranslateUi() + self.autoSelectItem = None QtCore.QObject.connect(Receiver.get_receiver(), QtCore.SIGNAL(u'%s_service_load' % self.parent.name.lower()), self.serviceLoad) diff --git a/openlp/plugins/custom/lib/mediaitem.py b/openlp/plugins/custom/lib/mediaitem.py index 8e80b8b13..189164b59 100644 --- a/openlp/plugins/custom/lib/mediaitem.py +++ b/openlp/plugins/custom/lib/mediaitem.py @@ -62,7 +62,6 @@ class CustomMediaItem(MediaManagerItem): # which Custom is required. self.remoteCustom = -1 self.manager = parent.manager - self.autoSelectItem = None def addEndHeaderBar(self): self.addToolbarSeparator() diff --git a/openlp/plugins/songs/lib/mediaitem.py b/openlp/plugins/songs/lib/mediaitem.py index 1afc17467..78c7825be 100644 --- a/openlp/plugins/songs/lib/mediaitem.py +++ b/openlp/plugins/songs/lib/mediaitem.py @@ -73,7 +73,6 @@ class SongMediaItem(MediaManagerItem): self.editItem = None self.quickPreviewAllowed = True self.hasSearch = True - self.autoSelectItem = None def addEndHeaderBar(self): self.addToolbarSeparator()