fix tests to allow for SongbookNumberInTitle defaulting to false and add hints tests

tests/functional/openlp_plugins/songs/test_singingthefaithimport.py

@@ -46,3 +46,18 @@ class TestSingingTheFaithFileImport(SongImportTestHelper):
         # Whole song
         self.file_import([TEST_PATH / 'H2.txt'],
                          self.load_external_result_data(TEST_PATH / 'STF002.json'))
+
+        # Tests with hints - note that the hints directory has a hints.tag which specifies
+        # SongbookNumberInTitle: True
+        # The default is false, so the unhinted tests will not have the title, but the hinted
+        # song tests will need it
+
+        # Single verse
+        self.file_import([TEST_PATH / 'hints' / 'H1.txt'],
+                         self.load_external_result_data(TEST_PATH / 'hints' / 'STF001.json'))
+        # Whole song
+        self.file_import([TEST_PATH / 'hints' / 'H2.txt'],
+                         self.load_external_result_data(TEST_PATH / 'hints' / 'STF002.json'))
+
+
+

tests/resources/songs/singingthefaith/STF001.json

@@ -1,5 +1,5 @@
 {
-    "title": "STF001 - Amazing Grace! how sweet the sound!",
+    "title": "Amazing Grace! how sweet the sound!",
     "authors": [
         "John Newton (d. 1807)"
     ],

tests/resources/songs/singingthefaith/STF002.json

@@ -1,5 +1,5 @@
 {
-    "title": "STF002 - Amazing Grace! how sweet the sound!",
+    "title": "Amazing Grace! how sweet the sound!",
     "authors": [
         "John Newton (d. 1807)"
     ],