raoul/openlp
1
0
Fork 0
forked from openlp/openlp
Code Issues Pull Requests Projects Releases Wiki Activity

Document a magic number.

Browse Source
This commit is contained in:
Patrick Zimmermann 2013-03-05 20:49:11 +01:00
parent b740f54352
commit 955a1a3be4
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openlp/plugins/songs/forms/songreviewwidget.py
View File

@ -34,6 +34,7 @@ from PyQt4 import QtCore, QtGui
from openlp.core.lib import build_icon from openlp.core.lib import build_icon
from openlp.plugins.songs.lib.xml import SongXML from openlp.plugins.songs.lib.xml import SongXML
class SongReviewWidget(QtGui.QWidget): class SongReviewWidget(QtGui.QWidget):
""" """
A widget representing a song on the duplicate song review page. A widget representing a song on the duplicate song review page.
@ -166,9 +167,13 @@ class SongReviewWidget(QtGui.QWidget):
# Resize table fields to content and table to columns # Resize table fields to content and table to columns
self.song_info_verse_list_widget.setColumnWidth(0, self.song_group_box.width()) self.song_info_verse_list_widget.setColumnWidth(0, self.song_group_box.width())
self.song_info_verse_list_widget.resizeRowsToContents() self.song_info_verse_list_widget.resizeRowsToContents()
# The 6 is a trial and error value to just remove the scrollbar. # The 6 is a trial and error value since verticalHeader().length() + offset() is a little bit to small.
# TODO: Might be a different value with different skins. # It seems there is no clean way to determine the real height of the table contents.
self.song_info_verse_list_widget.setFixedHeight(self.song_info_verse_list_widget.verticalHeader().length() + 6) # The "correct" value slightly fluctuates depending on the theme used, in the worst case
# Some pixels are missing at the bottom of the table, but all themes I tried still allowed
# to read the last verse line, so I'll just leave it at that.
self.song_info_verse_list_widget.setFixedHeight(self.song_info_verse_list_widget.verticalHeader().length() +
self.song_info_verse_list_widget.verticalHeader().offset() + 6)
self.song_group_box_layout.addWidget(self.song_info_verse_list_widget) self.song_group_box_layout.addWidget(self.song_info_verse_list_widget)
self.song_group_box_layout.addStretch() self.song_group_box_layout.addStretch()
self.song_vertical_layout.addWidget(self.song_group_box) self.song_vertical_layout.addWidget(self.song_group_box)
@ -187,6 +192,7 @@ class SongReviewWidget(QtGui.QWidget):
self.song_copyright_label.setText(u'Copyright:') self.song_copyright_label.setText(u'Copyright:')
self.song_comments_label.setText(u'Comments:') self.song_comments_label.setText(u'Comments:')
self.song_authors_label.setText(u'Authors:') self.song_authors_label.setText(u'Authors:')
def on_remove_button_clicked(self): def on_remove_button_clicked(self):
""" """
Signal emitted when the "remove" button is clicked. Signal emitted when the "remove" button is clicked.