From 978cc3bc3687fcac81894fb9ca547210c8d3d1eb Mon Sep 17 00:00:00 2001 From: Andreas Preikschat Date: Thu, 12 Jul 2012 18:48:28 +0200 Subject: [PATCH] - removed not needed 'QtCore.Qt.OtherFocusReason' from setFocus calls - fixed 'short' lines - changed addItem to addItems when possible - other clean ups --- openlp/core/lib/ui.py | 8 ++-- openlp/core/ui/advancedtab.py | 44 +++++++------------ openlp/core/ui/shortcutlistform.py | 4 +- openlp/core/ui/thememanager.py | 2 +- openlp/plugins/bibles/lib/biblestab.py | 3 +- openlp/plugins/custom/forms/editcustomform.py | 42 +++++++----------- openlp/plugins/songs/forms/editsongform.py | 4 +- openlp/plugins/songs/forms/editverseform.py | 2 +- 8 files changed, 41 insertions(+), 68 deletions(-) diff --git a/openlp/core/lib/ui.py b/openlp/core/lib/ui.py index e9638a58b..3ecfa049e 100644 --- a/openlp/core/lib/ui.py +++ b/openlp/core/lib/ui.py @@ -464,9 +464,8 @@ def create_valign_selection_widgets(parent): label = QtGui.QLabel(parent) label.setText(translate('OpenLP.Ui', '&Vertical Align:')) combo_box = QtGui.QComboBox(parent) - combo_box.addItem(UiStrings().Top) - combo_box.addItem(UiStrings().Middle) - combo_box.addItem(UiStrings().Bottom) + combo_box.addItems( + [UiStrings().Top, UiStrings().Middle, UiStrings().Bottom]) label.setBuddy(combo_box) return label, combo_box @@ -481,8 +480,7 @@ def find_and_set_in_combo_box(combo_box, value_to_find): ``value_to_find`` The value to find """ - index = combo_box.findText(value_to_find, - QtCore.Qt.MatchExactly) + index = combo_box.findText(value_to_find, QtCore.Qt.MatchExactly) if index == -1: # Not Found. index = 0 diff --git a/openlp/core/ui/advancedtab.py b/openlp/core/ui/advancedtab.py index 25c6f7a26..ef15b2c91 100644 --- a/openlp/core/ui/advancedtab.py +++ b/openlp/core/ui/advancedtab.py @@ -102,28 +102,22 @@ class AdvancedTab(SettingsTab): u'expandServiceItemCheckBox') self.uiLayout.addRow(self.expandServiceItemCheckBox) self.enableAutoCloseCheckBox = QtGui.QCheckBox(self.uiGroupBox) - self.enableAutoCloseCheckBox.setObjectName( - u'enableAutoCloseCheckBox') + self.enableAutoCloseCheckBox.setObjectName(u'enableAutoCloseCheckBox') self.uiLayout.addRow(self.enableAutoCloseCheckBox) self.leftLayout.addWidget(self.uiGroupBox) # Default service name self.serviceNameGroupBox = QtGui.QGroupBox(self.leftColumn) self.serviceNameGroupBox.setObjectName(u'serviceNameGroupBox') - self.serviceNameLayout = QtGui.QFormLayout( - self.serviceNameGroupBox) - self.serviceNameCheckBox = QtGui.QCheckBox( - self.serviceNameGroupBox) + self.serviceNameLayout = QtGui.QFormLayout(self.serviceNameGroupBox) + self.serviceNameCheckBox = QtGui.QCheckBox(self.serviceNameGroupBox) self.serviceNameCheckBox.setObjectName(u'serviceNameCheckBox') self.serviceNameLayout.setObjectName(u'serviceNameLayout') self.serviceNameLayout.addRow(self.serviceNameCheckBox) self.serviceNameTimeLabel = QtGui.QLabel(self.serviceNameGroupBox) self.serviceNameTimeLabel.setObjectName(u'serviceNameTimeLabel') - self.serviceNameDay = QtGui.QComboBox( - self.serviceNameGroupBox) - self.serviceNameDay.addItems( - [u'', u'', u'', u'', u'', u'', u'', u'']) - self.serviceNameDay.setObjectName( - u'serviceNameDay') + self.serviceNameDay = QtGui.QComboBox(self.serviceNameGroupBox) + self.serviceNameDay.addItems([u'', u'', u'', u'', u'', u'', u'', u'']) + self.serviceNameDay.setObjectName(u'serviceNameDay') self.serviceNameTime = QtGui.QTimeEdit(self.serviceNameGroupBox) self.serviceNameTime.setObjectName(u'serviceNameTime') self.serviceNameTimeHBox = QtGui.QHBoxLayout() @@ -150,8 +144,7 @@ class AdvancedTab(SettingsTab): self.serviceNameHBox.addWidget(self.serviceNameRevertButton) self.serviceNameLayout.addRow(self.serviceNameLabel, self.serviceNameHBox) - self.serviceNameExampleLabel = QtGui.QLabel( - self.serviceNameGroupBox) + self.serviceNameExampleLabel = QtGui.QLabel(self.serviceNameGroupBox) self.serviceNameExampleLabel.setObjectName( u'serviceNameExampleLabel') self.serviceNameExample = QtGui.QLabel(self.serviceNameGroupBox) @@ -201,8 +194,7 @@ class AdvancedTab(SettingsTab): self.newDataDirectoryLabelHBox.setObjectName( u'newDataDirectoryLabelHBox') self.newDataDirectoryLabelHBox.addWidget(self.newDataDirectoryEdit) - self.newDataDirectoryLabelHBox.addWidget( - self.dataDirectoryBrowseButton) + self.newDataDirectoryLabelHBox.addWidget(self.dataDirectoryBrowseButton) self.newDataDirectoryLabelHBox.addWidget( self.dataDirectoryDefaultButton) self.dataDirectoryCopyCheckHBox = QtGui.QHBoxLayout() @@ -339,8 +331,7 @@ class AdvancedTab(SettingsTab): Setup the interface translation strings. """ self.tabTitleVisible = UiStrings().Advanced - self.uiGroupBox.setTitle( - translate('OpenLP.AdvancedTab', 'UI Settings')) + self.uiGroupBox.setTitle(translate('OpenLP.AdvancedTab', 'UI Settings')) self.dataDirectoryGroupBox.setTitle( translate('OpenLP.AdvancedTab', 'Data Location')) self.recentLabel.setText( @@ -432,8 +423,7 @@ class AdvancedTab(SettingsTab): translate('OpenLP.AdvancedTab', 'WARNING: New data directory location contains ' 'OpenLP data files. These files WILL be replaced during a copy.')) - self.x11GroupBox.setTitle(translate('OpenLP.AdvancedTab', - 'X11')) + self.x11GroupBox.setTitle(translate('OpenLP.AdvancedTab', 'X11')) self.x11BypassCheckBox.setText(translate('OpenLP.AdvancedTab', 'Bypass X11 Window Manager')) # Slide Limits @@ -498,8 +488,7 @@ class AdvancedTab(SettingsTab): self.defaultColor = settings.value(u'default color', QtCore.QVariant(u'#ffffff')).toString() self.defaultFileEdit.setText(settings.value(u'default image', - QtCore.QVariant(u':/graphics/openlp-splash-screen.png'))\ - .toString()) + QtCore.QVariant(u':/graphics/openlp-splash-screen.png')).toString()) self.slide_limits = settings.value( u'slide limits', QtCore.QVariant(SlideLimits.End)).toInt()[0] if self.slide_limits == SlideLimits.End: @@ -541,8 +530,7 @@ class AdvancedTab(SettingsTab): self.currentDataPath = AppLocation.get_data_path() log.warning(u'User requested data path set to default %s' % self.currentDataPath) - self.dataDirectoryLabel.setText(os.path.abspath( - self.currentDataPath)) + self.dataDirectoryLabel.setText(os.path.abspath(self.currentDataPath)) self.defaultColorButton.setStyleSheet( u'background-color: %s' % self.defaultColor) @@ -652,8 +640,7 @@ class AdvancedTab(SettingsTab): file_filters = u'%s;;%s (*.*) (*)' % (get_images_filter(), UiStrings().AllFiles) filename = QtGui.QFileDialog.getOpenFileName(self, - translate('OpenLP.AdvancedTab', 'Open File'), '', - file_filters) + translate('OpenLP.AdvancedTab', 'Open File'), '', file_filters) if filename: self.defaultFileEdit.setText(filename) self.defaultFileEdit.setFocus() @@ -702,7 +689,8 @@ class AdvancedTab(SettingsTab): """ new_data_path = AppLocation.get_directory(AppLocation.DataDir) if self.currentDataPath.lower() != new_data_path.lower(): - # Make sure they want to change the data location back to the default. + # Make sure they want to change the data location back to the + # default. answer = QtGui.QMessageBox.question(self, translate('OpenLP.AdvancedTab', 'Reset Data Directory'), translate('OpenLP.AdvancedTab', @@ -761,7 +749,7 @@ class AdvancedTab(SettingsTab): self.dataExists = False self.dataDirectoryCopyCheckBox.setChecked(True) self.newDataDirectoryHasFilesLabel.hide() - + def onDataDirectoryCancelButtonClicked(self): """ Cancel the data directory location change diff --git a/openlp/core/ui/shortcutlistform.py b/openlp/core/ui/shortcutlistform.py index b2ae27063..26aa9e7f7 100644 --- a/openlp/core/ui/shortcutlistform.py +++ b/openlp/core/ui/shortcutlistform.py @@ -222,10 +222,10 @@ class ShortcutListForm(QtGui.QDialog, Ui_ShortcutListDialog): self.alternatePushButton.setChecked(column not in [0, 1]) if column in [0, 1]: self.primaryPushButton.setText(u'') - self.primaryPushButton.setFocus(QtCore.Qt.OtherFocusReason) + self.primaryPushButton.setFocus() else: self.alternatePushButton.setText(u'') - self.alternatePushButton.setFocus(QtCore.Qt.OtherFocusReason) + self.alternatePushButton.setFocus() def onCurrentItemChanged(self, item=None, previousItem=None): """ diff --git a/openlp/core/ui/thememanager.py b/openlp/core/ui/thememanager.py index 585ab2329..334774394 100644 --- a/openlp/core/ui/thememanager.py +++ b/openlp/core/ui/thememanager.py @@ -457,7 +457,7 @@ class ThemeManager(QtGui.QWidget): # Sort the themes by its name considering language specific characters. # lower() is needed for windows! files.sort(key=lambda file_name: unicode(file_name).lower(), - cmp=locale.strcoll) + cmp=locale.strcoll) # now process the file list of png files for name in files: # check to see file is in theme root directory diff --git a/openlp/plugins/bibles/lib/biblestab.py b/openlp/plugins/bibles/lib/biblestab.py index b093d06e4..218553236 100644 --- a/openlp/plugins/bibles/lib/biblestab.py +++ b/openlp/plugins/bibles/lib/biblestab.py @@ -537,8 +537,7 @@ class BiblesTab(SettingsTab): """ self.bibleThemeComboBox.clear() self.bibleThemeComboBox.addItem(u'') - for theme in theme_list: - self.bibleThemeComboBox.addItem(theme) + self.bibleThemeComboBox.addItems(theme_list) find_and_set_in_combo_box(self.bibleThemeComboBox, self.bible_theme) def getGreyTextPalette(self, greyed): diff --git a/openlp/plugins/custom/forms/editcustomform.py b/openlp/plugins/custom/forms/editcustomform.py index 816cd2720..13d722b18 100644 --- a/openlp/plugins/custom/forms/editcustomform.py +++ b/openlp/plugins/custom/forms/editcustomform.py @@ -75,8 +75,7 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): def loadThemes(self, themelist): self.themeComboBox.clear() self.themeComboBox.addItem(u'') - for themename in themelist: - self.themeComboBox.addItem(themename) + self.themeComboBox.addItems(themelist) def loadCustom(self, id, preview=False): """ @@ -105,7 +104,7 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): self.slideListView.addItem(slide[1]) theme = self.customSlide.theme_name find_and_set_in_combo_box(self.themeComboBox, theme) - self.titleEdit.setFocus(QtCore.Qt.OtherFocusReason) + self.titleEdit.setFocus() # If not preview hide the preview button. self.previewButton.setVisible(preview) @@ -127,11 +126,9 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): sxml = CustomXMLBuilder() sxml.new_document() sxml.add_lyrics_to_song() - count = 1 - for i in range(self.slideListView.count()): - sxml.add_verse_to_lyrics(u'custom', unicode(count), - unicode(self.slideListView.item(i).text())) - count += 1 + for count in range(self.slideListView.count()): + sxml.add_verse_to_lyrics(u'custom', unicode(count + 1), + unicode(self.slideListView.item(count).text())) self.customSlide.title = unicode(self.titleEdit.text()) self.customSlide.text = unicode(sxml.extract_xml(), u'utf-8') self.customSlide.credits = unicode(self.creditEdit.text()) @@ -158,8 +155,7 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): def onAddButtonClicked(self): self.editSlideForm.setText(u'') if self.editSlideForm.exec_(): - for slide in self.editSlideForm.getText(): - self.slideListView.addItem(slide) + self.slideListView.addItems(self.editSlideForm.getText()) def onEditButtonClicked(self): self.editSlideForm.setText(self.slideListView.currentItem().text()) @@ -170,13 +166,13 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): """ Edits all slides. """ - slide_list = u'' + slide_text = u'' for row in range(self.slideListView.count()): item = self.slideListView.item(row) - slide_list += item.text() + slide_text += item.text() if row != self.slideListView.count() - 1: - slide_list += u'\n[===]\n' - self.editSlideForm.setText(slide_list) + slide_text += u'\n[===]\n' + self.editSlideForm.setText(slide_text) if self.editSlideForm.exec_(): self.updateSlideList(self.editSlideForm.getText(), True) @@ -200,21 +196,19 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): """ if edit_all: self.slideListView.clear() - for slide in slides: - self.slideListView.addItem(slide) + self.slideListView.addItems(slides) else: old_slides = [] old_row = self.slideListView.currentRow() # Create a list with all (old/unedited) slides. - old_slides = [self.slideListView.item(row).text() for row in \ + old_slides = [self.slideListView.item(row).text() for row in range(self.slideListView.count())] self.slideListView.clear() old_slides.pop(old_row) # Insert all slides to make the old_slides list complete. for slide in slides: old_slides.insert(old_row, slide) - for slide in old_slides: - self.slideListView.addItem(slide) + self.slideListView.addItems(old_slides) self.slideListView.repaint() def onDeleteButtonClicked(self): @@ -241,14 +235,8 @@ class EditCustomForm(QtGui.QDialog, Ui_CustomEditDialog): self.deleteButton.setEnabled(True) self.editButton.setEnabled(True) # Decide if the up/down buttons should be enabled or not. - if self.slideListView.count() - 1 == row: - self.downButton.setEnabled(False) - else: - self.downButton.setEnabled(True) - if row == 0: - self.upButton.setEnabled(False) - else: - self.upButton.setEnabled(True) + self.downButton.setEnabled(self.slideListView.count() - 1 != row) + self.upButton.setEnabled(row != 0) def _validate(self): """ diff --git a/openlp/plugins/songs/forms/editsongform.py b/openlp/plugins/songs/forms/editsongform.py index 0b3dddcc9..41cfbfe19 100644 --- a/openlp/plugins/songs/forms/editsongform.py +++ b/openlp/plugins/songs/forms/editsongform.py @@ -202,7 +202,7 @@ class EditSongForm(QtGui.QDialog, Ui_EditSongDialog): self.authorsListView.clear() self.topicsListView.clear() self.audioListWidget.clear() - self.titleEdit.setFocus(QtCore.Qt.OtherFocusReason) + self.titleEdit.setFocus() self.songBookNumberEdit.clear() self.loadAuthors() self.loadTopics() @@ -325,7 +325,7 @@ class EditSongForm(QtGui.QDialog, Ui_EditSongDialog): media_file.setData(QtCore.Qt.UserRole, QtCore.QVariant(media.file_name)) self.audioListWidget.addItem(media_file) - self.titleEdit.setFocus(QtCore.Qt.OtherFocusReason) + self.titleEdit.setFocus() # Hide or show the preview button. self.previewButton.setVisible(preview) diff --git a/openlp/plugins/songs/forms/editverseform.py b/openlp/plugins/songs/forms/editverseform.py index f5c8e5d48..ffa7f2331 100644 --- a/openlp/plugins/songs/forms/editverseform.py +++ b/openlp/plugins/songs/forms/editverseform.py @@ -171,7 +171,7 @@ class EditVerseForm(QtGui.QDialog, Ui_EditVerseDialog): self.verseNumberBox.setValue(1) self.insertButton.setVisible(True) self.verseTextEdit.setPlainText(text) - self.verseTextEdit.setFocus(QtCore.Qt.OtherFocusReason) + self.verseTextEdit.setFocus() self.verseTextEdit.moveCursor(QtGui.QTextCursor.End) def getVerse(self):