From a8a7e675a410647cdcdbe5258396e9a86144e5ef Mon Sep 17 00:00:00 2001 From: Martin Thompson Date: Sun, 9 May 2010 21:02:38 +0100 Subject: [PATCH] Updated from review comments --- openlp/core/ui/maindisplay.py | 6 ++++-- openlp/plugins/bibles/lib/mediaitem.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/openlp/core/ui/maindisplay.py b/openlp/core/ui/maindisplay.py index d67823908..4b2c4d268 100644 --- a/openlp/core/ui/maindisplay.py +++ b/openlp/core/ui/maindisplay.py @@ -118,7 +118,8 @@ class MainDisplay(DisplayWidget): DisplayWidget.__init__(self, parent) self.parent = parent self.setWindowTitle(u'OpenLP Display') - try: # WA_TranslucentBackground not available in QT4.4 + # WA_TranslucentBackground is not available in QT4.4 + try: self.setAttribute(QtCore.Qt.WA_TranslucentBackground) except AttributeError: pass @@ -344,7 +345,8 @@ class VideoDisplay(Phonon.VideoWidget): Phonon.createPath(self.mediaObject, self) Phonon.createPath(self.mediaObject, self.audioObject) flags = QtCore.Qt.FramelessWindowHint | QtCore.Qt.Dialog - try: # WindowsStaysOnBottomHint is not available in QT4.4 + # WindowsStaysOnBottomHint is not available in QT4.4 + try: flags = flags | QtCore.Qt.WindowStaysOnBottomHint except AttributeError: pass diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index e84e732e7..136f45633 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -337,7 +337,7 @@ class BibleMediaItem(MediaManagerItem): # load bibles into the combo boxes first = True for bible in bibles: - if bible is not None: + if bible: self.QuickVersionComboBox.addItem(bible) self.QuickSecondBibleComboBox.addItem(bible) self.AdvancedVersionComboBox.addItem(bible)