raoul
/
openlp
forked from openlp/openlp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix call to wrong signal on error

This commit is contained in:
Ken Roberts 2016-06-17 16:05:26 -07:00
parent c64df391aa
commit aaba690c97
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openlp/core/lib/projector/pjlink1.py
View File

@ -356,8 +356,8 @@ class PJLink1(QTcpSocket):
log.warning('({ip}) Authenticated connection but no pin set'.format(ip=self.name))
self.disconnect_from_host()
self.change_status(E_AUTHENTICATION)
log.debug('({ip}) Emitting projectorNoAuthentication() signal'.format(ip=self.name))
self.projectorNoAuthentication.emit(self.name)
log.debug('({ip}) Emitting projectorAuthentication() signal'.format(ip=self.name))
self.projectorAuthentication.emit(self.name)
return
else:
log.debug('({ip}) Setting hash with salt="{data}"'.format(ip=self.ip, data=data_check[2]))

8
tests/functional/openlp_core_lib/test_projector_pjlink1.py
View File

@ -335,12 +335,12 @@ class TestPJLink(TestCase):
@patch.object(pjlink_test, 'send_command')
@patch.object(pjlink_test, 'waitForReadyRead')
@patch.object(pjlink_test, 'projectorNoAuthentication')
@patch.object(pjlink_test, 'projectorAuthentication')
@patch.object(pjlink_test, 'timer')
@patch.object(pjlink_test, 'socket_timer')
def test_bug_1593882_no_pin_authenticated_connection(self, mock_socket_timer,
mock_timer,
mock_no_authentication,
mock_authentication,
mock_ready_read,
mock_send_command):
"""
@ -352,7 +352,7 @@ class TestPJLink(TestCase):
mock_ready_read.return_value = True
# WHEN: call with authentication request and pin not set
pjlink.check_login(data='PJLink 1 123abc')
pjlink.check_login(data=TEST_CONNECT_AUTHENTICATE)
# THEN: No Authentication signal should have been sent
mock_no_authentication.called_with(pjlink.name, 'projectorNoAuthentication should have been called')
mock_authentication.called_with(pjlink.name, 'projectorAuthentication should have been called')