raoul/openlp
1
0
Fork 0
forked from openlp/openlp
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a super-annoying bug where any newly imported Bibles would throw an exception.

Browse Source 
bzr-revno: 1971
This commit is contained in:
Raoul Snyman 2012-05-17 22:38:40 +02:00 committed by Andreas Preikschat
commit d754fe4ae5
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
openlp/plugins/bibles/lib/manager.py
View File

@ -330,13 +330,7 @@ class BibleManager(object):
'Import Wizard to install one or more Bibles.') 'Import Wizard to install one or more Bibles.')
}) })
return None return None
language_selection = self.get_meta_data(bible, u'book_name_language') language_selection = self.get_language_selection(bible)
if language_selection:
language_selection = int(language_selection.value)
if language_selection is None or language_selection == -1:
language_selection = QtCore.QSettings().value(
self.settingsSection + u'/bookname language',
QtCore.QVariant(0)).toInt()[0]
reflist = parse_reference(versetext, self.db_cache[bible], reflist = parse_reference(versetext, self.db_cache[bible],
language_selection, book_ref_id) language_selection, book_ref_id)
if reflist: if reflist:
@ -378,12 +372,16 @@ class BibleManager(object):
""" """
log.debug(u'BibleManager.get_language_selection("%s")', bible) log.debug(u'BibleManager.get_language_selection("%s")', bible)
language_selection = self.get_meta_data(bible, u'book_name_language') language_selection = self.get_meta_data(bible, u'book_name_language')
if language_selection and language_selection.value != u'None': if language_selection:
return int(language_selection.value) try:
if language_selection is None or language_selection.value == u'None': language_selection = int(language_selection.value)
return QtCore.QSettings().value( except (ValueError, TypeError):
language_selection = LanguageSelection.Application
if language_selection is None or language_selection == -1:
language_selection = QtCore.QSettings().value(
self.settingsSection + u'/bookname language', self.settingsSection + u'/bookname language',
QtCore.QVariant(0)).toInt()[0] QtCore.QVariant(0)).toInt()[0]
return language_selection
def verse_search(self, bible, second_bible, text): def verse_search(self, bible, second_bible, text):
""" """

3
openlp/plugins/bibles/lib/mediaitem.py
View File

@ -843,10 +843,11 @@ class BibleMediaItem(MediaManagerItem):
items = [] items = []
language_selection = self.plugin.manager.get_language_selection(bible) language_selection = self.plugin.manager.get_language_selection(bible)
for count, verse in enumerate(search_results): for count, verse in enumerate(search_results):
book = None
if language_selection == LanguageSelection.Bible: if language_selection == LanguageSelection.Bible:
book = verse.book.name book = verse.book.name
elif language_selection == LanguageSelection.Application: elif language_selection == LanguageSelection.Application:
book_names = BibleStrings().Booknames book_names = BibleStrings().BookNames
data = BiblesResourcesDB.get_book_by_id( data = BiblesResourcesDB.get_book_by_id(
verse.book.book_reference_id) verse.book.book_reference_id)
book = unicode(book_names[data[u'abbreviation']]) book = unicode(book_names[data[u'abbreviation']])