raoul/openlp
1
0
Fork 0
forked from openlp/openlp
Code Issues Pull Requests Projects Releases Wiki Activity

Split test in two methods

Browse Source
This commit is contained in:
Samuel Mehrbrodt 2014-05-21 21:55:16 +02:00
parent 5cd2f7ebff
commit dd9d535f81
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/functional/openlp_plugins/songs/test_mediaitem.py
View File

@ -154,7 +154,7 @@ class TestMediaItem(TestCase, TestMixin):
# THEN: The songbook should be in the footer # THEN: The songbook should be in the footer
self.assertEqual(service_item.raw_footer, ['My Song', 'My copyright', 'My songbook #12']) self.assertEqual(service_item.raw_footer, ['My Song', 'My copyright', 'My songbook #12'])
def match_authors_test(self): def authors_match_test(self):
""" """
Test the author matching when importing a song from a service Test the author matching when importing a song from a service
""" """
@ -180,6 +180,22 @@ class TestMediaItem(TestCase, TestMixin):
# THEN: They should match # THEN: They should match
self.assertTrue(result, "Authors should match") self.assertTrue(result, "Authors should match")
def authors_dont_match_test(self):
# GIVEN: A song and a string with authors
song = MagicMock()
song.authors = []
author = MagicMock()
author.display_name = "Hans Wurst"
song.authors.append(author)
author2 = MagicMock()
author2.display_name = "Max Mustermann"
song.authors.append(author2)
# There are occasions where an author appears twice in a song (with different types).
# We need to make sure that this case works (lp#1313538)
author3 = MagicMock()
author3.display_name = "Max Mustermann"
song.authors.append(author3)
# WHEN: An author is missing in the string # WHEN: An author is missing in the string
authors_str = "Hans Wurst, Max Mustermann" authors_str = "Hans Wurst, Max Mustermann"
result = self.media_item._authors_match(song, authors_str) result = self.media_item._authors_match(song, authors_str)