diff --git a/openlp/core/ui/slidecontroller.py b/openlp/core/ui/slidecontroller.py index e00804530..37c4836b9 100644 --- a/openlp/core/ui/slidecontroller.py +++ b/openlp/core/ui/slidecontroller.py @@ -1140,7 +1140,7 @@ class SlideController(DisplayController, RegistryProperties): win_id = QtWidgets.QApplication.desktop().winId() screen = QtWidgets.QApplication.primaryScreen() rect = self.screens.current['size'] - win_image = screen.grabWindow(win_id, rect.x(), rect.y(),rect.width(), rect.height()) + win_image = screen.grabWindow(win_id, rect.x(), rect.y(), rect.width(), rect.height()) win_image.setDevicePixelRatio(self.slide_preview.devicePixelRatio()) self.slide_preview.setPixmap(win_image) self.slide_image = win_image diff --git a/openlp/plugins/songs/forms/editsongform.py b/openlp/plugins/songs/forms/editsongform.py index 33b106aa0..4bc77c65c 100644 --- a/openlp/plugins/songs/forms/editsongform.py +++ b/openlp/plugins/songs/forms/editsongform.py @@ -515,7 +515,7 @@ class EditSongForm(QtWidgets.QDialog, Ui_EditSongDialog, RegistryProperties): self.topics_list_view.addItem(topic_name) self.songbooks_list_view.clear() for songbook_entry in self.song.songbook_entries: - self.add_songbook_entry_to_list(songbook_entry.songbook.id, songbook_entry.songbook.name, + self.add_songbook_entry_to_list(songbook_entry.songbook.id, songbook_entry.songbook.name, songbook_entry.entry) self.audio_list_widget.clear() for media in self.song.media_files: diff --git a/openlp/plugins/songs/lib/mediaitem.py b/openlp/plugins/songs/lib/mediaitem.py index dfa967e22..82a2d6085 100644 --- a/openlp/plugins/songs/lib/mediaitem.py +++ b/openlp/plugins/songs/lib/mediaitem.py @@ -255,9 +255,9 @@ class SongMediaItem(MediaManagerItem): search_entry = re.sub(r'[^0-9]', '', search_keywords[2]) songbook_entries = (self.plugin.manager.session.query(SongBookEntry) - .join(Book) - .order_by(Book.name) - .order_by(SongBookEntry.entry)) + .join(Book) + .order_by(Book.name) + .order_by(SongBookEntry.entry)) for songbook_entry in songbook_entries: if songbook_entry.song.temporary: continue diff --git a/tests/functional/openlp_core_lib/test_htmlbuilder.py b/tests/functional/openlp_core_lib/test_htmlbuilder.py index 181c485f5..8ca98060d 100644 --- a/tests/functional/openlp_core_lib/test_htmlbuilder.py +++ b/tests/functional/openlp_core_lib/test_htmlbuilder.py @@ -363,9 +363,8 @@ class Htmbuilder(TestCase, TestMixin): """ Test the webkit_version() function """ - # GIVEN: Webkit + # GIVEN: Webkit webkit_ver = float(QtWebKit.qWebKitVersion()) # WHEN: Retrieving the webkit version # THEN: Webkit versions should match self.assertEquals(webkit_version(), webkit_ver, "The returned webkit version doesn't match the installed one") - diff --git a/tests/functional/openlp_core_ui/test_mainwindow.py b/tests/functional/openlp_core_ui/test_mainwindow.py index 5499a78a7..a49ded25c 100644 --- a/tests/functional/openlp_core_ui/test_mainwindow.py +++ b/tests/functional/openlp_core_ui/test_mainwindow.py @@ -189,5 +189,3 @@ class TestMainWindow(TestCase, TestMixin): # THEN: The media manager dock is made visible self.assertEqual(0, mocked_media_manager_dock.setVisible.call_count) mocked_widget.on_focus.assert_called_with() - - diff --git a/tests/resources/projector/data.py b/tests/resources/projector/data.py index fca9c0ca0..00d150cf2 100644 --- a/tests/resources/projector/data.py +++ b/tests/resources/projector/data.py @@ -59,4 +59,3 @@ TEST3_DATA = dict(ip='333.333.333.333', name='___TEST_THREE___', location='location three', notes='notes three') -