Fix bug #1094809: Improve the Message when a wrong Verse order was entered

bzr-revno: 2286
Fixes: https://launchpad.net/bugs/1094809
This commit is contained in:
Samuel Mehrbrodt 2013-08-16 22:50:26 +02:00 committed by Raoul Snyman
commit ed5fedbf33

View File

@ -171,13 +171,15 @@ class EditSongForm(QtGui.QDialog, Ui_EditSongDialog):
if invalid_verses:
valid = create_separated_list(verse_names)
if len(invalid_verses) > 1:
critical_error_message_box(message=translate('SongsPlugin.EditSongForm',
'The verse order is invalid. There are no verses corresponding to %s. Valid entries are %s.') %
(u', '.join(invalid_verses), valid))
msg = translate('SongsPlugin.EditSongForm', 'There are no verses corresponding to "%(invalid)s".'
'Valid entries are %(valid)s.\nPlease enter the verses seperated by spaces.') \
% {'invalid' : u', '.join(invalid_verses), 'valid' : valid}
else:
critical_error_message_box(message=translate('SongsPlugin.EditSongForm',
'The verse order is invalid. There is no verse corresponding to %s. Valid entries are %s.') %
(invalid_verses[0], valid))
msg = translate('SongsPlugin.EditSongForm', 'There is no verse corresponding to "%(invalid)s".'
'Valid entries are %(valid)s.\nPlease enter the verses seperated by spaces.') \
% {'invalid' : invalid_verses[0], 'valid' : valid}
critical_error_message_box(title=translate('SongsPlugin.EditSongForm', 'Invalid Verse Order'),
message=msg)
return len(invalid_verses) == 0
def _validate_song(self):