From eed14070577a2ed222abbdacd11df01eb5f71917 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Thu, 11 Aug 2016 00:22:07 +0300 Subject: [PATCH 01/14] - Fixed the bug where Bible "Advanced" clear button gives focus to "Quick" search field, thus making typing in it possible. --- openlp/plugins/bibles/lib/mediaitem.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index b8ff3a752..bdcda9942 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -254,7 +254,7 @@ class BibleMediaItem(MediaManagerItem): self.quickStyleComboBox.activated.connect(self.on_quick_style_combo_box_changed) self.advancedStyleComboBox.activated.connect(self.on_advanced_style_combo_box_changed) # Buttons - self.advancedClearButton.clicked.connect(self.on_clear_button) + self.advancedClearButton.clicked.connect(self.on_clear_button_advanced) self.quickClearButton.clicked.connect(self.on_clear_button) self.advancedSearchButton.clicked.connect(self.on_advanced_search_button) self.quickSearchButton.clicked.connect(self.on_quick_search_button) @@ -555,6 +555,11 @@ class BibleMediaItem(MediaManagerItem): self.quick_search_edit.clear() self.quick_search_edit.setFocus() + def on_clear_button_advanced(self): + # The same as the on_clear_button, but does not give focus to Quick search field. + self.list_view.clear() + self.check_search_result() + def on_lock_button_toggled(self, checked): self.quick_search_edit.setFocus() if checked: From c77dd470c5c165e7a92d2639cb23f3f11f91eed1 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sun, 14 Aug 2016 23:19:54 +0300 Subject: [PATCH 02/14] - Added the missing "clicked" to make the code easier to understand. --- openlp/plugins/bibles/lib/mediaitem.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index bdcda9942..2b35c9115 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -254,8 +254,8 @@ class BibleMediaItem(MediaManagerItem): self.quickStyleComboBox.activated.connect(self.on_quick_style_combo_box_changed) self.advancedStyleComboBox.activated.connect(self.on_advanced_style_combo_box_changed) # Buttons - self.advancedClearButton.clicked.connect(self.on_clear_button_advanced) - self.quickClearButton.clicked.connect(self.on_clear_button) + self.advancedClearButton.clicked.connect(self.on_advanced_clear_button_clicked) + self.quickClearButton.clicked.connect(self.on_clear_button_clicked) self.advancedSearchButton.clicked.connect(self.on_advanced_search_button) self.quickSearchButton.clicked.connect(self.on_quick_search_button) # Other stuff @@ -548,15 +548,15 @@ class BibleMediaItem(MediaManagerItem): self.advancedTab.setVisible(True) self.advanced_book_combo_box.setFocus() - def on_clear_button(self): + def on_clear_button_clicked(self): # Clear the list, then set the "No search Results" message, then clear the text field and give it focus. self.list_view.clear() self.check_search_result() self.quick_search_edit.clear() self.quick_search_edit.setFocus() - def on_clear_button_advanced(self): - # The same as the on_clear_button, but does not give focus to Quick search field. + def on_advanced_clear_button_clicked(self): + # The same as the on_clear_button_clicked, but does not give focus to Quick search field. self.list_view.clear() self.check_search_result() From 345978286be1450b0958f64a3cc549d57aa550e1 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 20 Aug 2016 01:49:51 +0300 Subject: [PATCH 03/14] - Added a test. --- .../openlp_plugins/bibles/test_mediaitem.py | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 05418f177..1d88aa6fb 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -150,3 +150,23 @@ class TestMediaItem(TestCase, TestMixin): self.assertEqual(2, self.media_item.quickSearchButton.setEnabled.call_count, 'Disable and Enable the button') self.assertEqual(1, self.media_item.check_search_result.call_count, 'Check results Should had been called once') self.assertEqual(1, self.app.set_normal_cursor.call_count, 'Normal cursor should had been called once') + + def on_clear_button_clicked_test(self): + """ + Test that the on_clear_button_clicked works properly. (Used by Bible search tab) + """ + + # GIVEN: Mocked list_view, check_search_results & quick_search_edit. + self.media_item.list_view = MagicMock() + self.media_item.check_search_result = MagicMock() + self.media_item.quick_search_edit = MagicMock() + + + # WHEN: on_clear_button_clicked is called + self.media_item.on_clear_button_clicked() + + # THEN: Search result should be reset and search field should receive focus. + self.assertEqual(1, self.media_item.list_view.clear.call_count, 'List_view.clear should had been called once.') + self.assertEqual(1, self.media_item.check_search_result.call_count, 'Check results Should had been called once') + self.assertEqual(1, self.media_item.quick_search_edit.clear.call_count, 'Should had been called once') + self.assertEqual(1, self.media_item.quick_search_edit.setFocus.call_count, 'Should had been called once') From b5c4cb1f851eb92d98ac43fd9c8d97c093653978 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 20 Aug 2016 01:53:20 +0300 Subject: [PATCH 04/14] - pep8 fix (2x blank line) --- tests/functional/openlp_plugins/bibles/test_mediaitem.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 1d88aa6fb..606c65a63 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -161,7 +161,6 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.check_search_result = MagicMock() self.media_item.quick_search_edit = MagicMock() - # WHEN: on_clear_button_clicked is called self.media_item.on_clear_button_clicked() From 890b617fc77306269727df22cc6e939e2ad5809e Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 20 Aug 2016 02:42:48 +0300 Subject: [PATCH 05/14] - Fixed the same issue for the lock button. --- openlp/plugins/bibles/lib/mediaitem.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index 2b35c9115..979eb5e89 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -556,16 +556,25 @@ class BibleMediaItem(MediaManagerItem): self.quick_search_edit.setFocus() def on_advanced_clear_button_clicked(self): - # The same as the on_clear_button_clicked, but does not give focus to Quick search field. + # The same as the on_clear_button_clicked, but gives focus to Book name field in "Select" (advanced). self.list_view.clear() self.check_search_result() + self.advanced_book_combo_box.setFocus() def on_lock_button_toggled(self, checked): - self.quick_search_edit.setFocus() + """ + Toggle the lock button, if Search tab is used, set focus to search field, if Select tab is used, + give focus to Bible book name field. + """ if checked: self.sender().setIcon(self.lock_icon) else: self.sender().setIcon(self.unlock_icon) + if self.quickTab.isVisible(): + self.quick_search_edit.setFocus() + else: + self.advanced_book_combo_box.setFocus() + def on_quick_style_combo_box_changed(self): self.settings.layout_style = self.quickStyleComboBox.currentIndex() From cf65d6921e5514d378abe703b1fa50134cde4c21 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 20 Aug 2016 02:46:20 +0300 Subject: [PATCH 06/14] - Pep8 --- openlp/plugins/bibles/lib/mediaitem.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index 979eb5e89..e20abe797 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -575,7 +575,6 @@ class BibleMediaItem(MediaManagerItem): else: self.advanced_book_combo_box.setFocus() - def on_quick_style_combo_box_changed(self): self.settings.layout_style = self.quickStyleComboBox.currentIndex() self.advancedStyleComboBox.setCurrentIndex(self.settings.layout_style) From 685c01ec25fb821bdccb2c006d6fb11cecccbdaa Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 20 Aug 2016 21:59:31 +0300 Subject: [PATCH 07/14] - Renamed test title from x_test to test_x --- tests/functional/openlp_plugins/bibles/test_mediaitem.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 606c65a63..bacafe009 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -114,7 +114,7 @@ class TestMediaItem(TestCase, TestMixin): self.assertEqual(self.media_item.search_results, {}) self.assertEqual(self.media_item.second_search_results, {}) - def on_quick_search_button_general_test(self): + def test_on_quick_search_button_general(self): """ Test that general things, which should be called on all Quick searches are called. """ @@ -151,7 +151,7 @@ class TestMediaItem(TestCase, TestMixin): self.assertEqual(1, self.media_item.check_search_result.call_count, 'Check results Should had been called once') self.assertEqual(1, self.app.set_normal_cursor.call_count, 'Normal cursor should had been called once') - def on_clear_button_clicked_test(self): + def test_on_clear_button_clicked(self): """ Test that the on_clear_button_clicked works properly. (Used by Bible search tab) """ From 359dded22a35f8e5f36cde218f553fb2813d8677 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Fri, 9 Sep 2016 10:51:19 +0300 Subject: [PATCH 08/14] - Fixed the test --- tests/functional/openlp_plugins/bibles/test_mediaitem.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index bacafe009..3aea7d825 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -155,7 +155,6 @@ class TestMediaItem(TestCase, TestMixin): """ Test that the on_clear_button_clicked works properly. (Used by Bible search tab) """ - # GIVEN: Mocked list_view, check_search_results & quick_search_edit. self.media_item.list_view = MagicMock() self.media_item.check_search_result = MagicMock() @@ -165,7 +164,7 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.on_clear_button_clicked() # THEN: Search result should be reset and search field should receive focus. - self.assertEqual(1, self.media_item.list_view.clear.call_count, 'List_view.clear should had been called once.') - self.assertEqual(1, self.media_item.check_search_result.call_count, 'Check results Should had been called once') - self.assertEqual(1, self.media_item.quick_search_edit.clear.call_count, 'Should had been called once') - self.assertEqual(1, self.media_item.quick_search_edit.setFocus.call_count, 'Should had been called once') + self.media_item.list_view.clear.assert_called_once_with(), + self.media_item.check_search_result.assert_called_once_with(), + self.media_item.quick_search_edit.clear.assert_called_once_with(), + self.media_item.quick_search_edit.setFocus.assert_called_once_with() \ No newline at end of file From a99bd8603f4ab101a213ff581eb3ca88b6a30b74 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Fri, 9 Sep 2016 10:57:11 +0300 Subject: [PATCH 09/14] - Combined some tags in expection dialogue. - Added new line to the end of the test. --- openlp/core/ui/exceptiondialog.py | 6 +++--- tests/functional/openlp_plugins/bibles/test_mediaitem.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/openlp/core/ui/exceptiondialog.py b/openlp/core/ui/exceptiondialog.py index 7341287c7..bcbc67552 100644 --- a/openlp/core/ui/exceptiondialog.py +++ b/openlp/core/ui/exceptiondialog.py @@ -97,9 +97,9 @@ class Ui_ExceptionDialog(object): translate('OpenLP.ExceptionDialog', 'Please describe what you were trying to do. ' ' If possible, write in English.')) exception_part1 = (translate('OpenLP.ExceptionDialog', - 'Oops, OpenLP hit a problem and couldn\'t recover!

' - 'You can help the OpenLP developers to fix this' - ' by
sending them a bug report to {email}{newlines}' + 'Oops, OpenLP hit a problem and couldn\'t recover!

' + 'You can help the OpenLP developers to fix this' + ' by
sending them a bug report to {email}{newlines}' ).format(email=' bugs@openlp.org', newlines='

')) self.message_label.setText( diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 3aea7d825..6d468275b 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -167,4 +167,4 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.list_view.clear.assert_called_once_with(), self.media_item.check_search_result.assert_called_once_with(), self.media_item.quick_search_edit.clear.assert_called_once_with(), - self.media_item.quick_search_edit.setFocus.assert_called_once_with() \ No newline at end of file + self.media_item.quick_search_edit.setFocus.assert_called_once_with() From a034532d195841920e21c4f875b742a97f3a881b Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Thu, 15 Sep 2016 02:17:17 +0300 Subject: [PATCH 10/14] - Fixed a bug where web bible's trigger traceback in search while typing. --- openlp/plugins/bibles/lib/manager.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openlp/plugins/bibles/lib/manager.py b/openlp/plugins/bibles/lib/manager.py index d2286bed2..cff979714 100644 --- a/openlp/plugins/bibles/lib/manager.py +++ b/openlp/plugins/bibles/lib/manager.py @@ -367,7 +367,6 @@ class BibleManager(RegistryProperties): second_web_bible = self.db_cache[second_bible].get_object(BibleMeta, 'download_source') if web_bible or second_web_bible: # If either Bible is Web, cursor is reset to normal and search ends w/o any message. - self.check_search_result() self.application.set_normal_cursor() return None # Fetch the results from db. If no results are found, return None, no message is given for this. From 191845b70c32d1dc5dfc219bff8904e64c8d7b02 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Thu, 15 Sep 2016 10:41:54 +0300 Subject: [PATCH 11/14] - Added param: to Lock toggle button --- openlp/plugins/bibles/lib/mediaitem.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index e20abe797..567f35823 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -565,6 +565,8 @@ class BibleMediaItem(MediaManagerItem): """ Toggle the lock button, if Search tab is used, set focus to search field, if Select tab is used, give focus to Bible book name field. + :param checked: The state of the toggle button. bool + :return: None """ if checked: self.sender().setIcon(self.lock_icon) From 09da152372d1e1b8bd3b8858cf17742d9665cb5d Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sat, 17 Sep 2016 00:43:30 +0300 Subject: [PATCH 12/14] - Added a test for toggle lock button - Removed give focus to Select bookname on Select tab, may be confusing. --- openlp/plugins/bibles/lib/mediaitem.py | 5 +---- .../openlp_plugins/bibles/test_mediaitem.py | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/openlp/plugins/bibles/lib/mediaitem.py b/openlp/plugins/bibles/lib/mediaitem.py index 567f35823..fc92b8f7a 100644 --- a/openlp/plugins/bibles/lib/mediaitem.py +++ b/openlp/plugins/bibles/lib/mediaitem.py @@ -563,8 +563,7 @@ class BibleMediaItem(MediaManagerItem): def on_lock_button_toggled(self, checked): """ - Toggle the lock button, if Search tab is used, set focus to search field, if Select tab is used, - give focus to Bible book name field. + Toggle the lock button, if Search tab is used, set focus to search field. :param checked: The state of the toggle button. bool :return: None """ @@ -574,8 +573,6 @@ class BibleMediaItem(MediaManagerItem): self.sender().setIcon(self.unlock_icon) if self.quickTab.isVisible(): self.quick_search_edit.setFocus() - else: - self.advanced_book_combo_box.setFocus() def on_quick_style_combo_box_changed(self): self.settings.layout_style = self.quickStyleComboBox.currentIndex() diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 6d468275b..484e5bd3d 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -168,3 +168,18 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.check_search_result.assert_called_once_with(), self.media_item.quick_search_edit.clear.assert_called_once_with(), self.media_item.quick_search_edit.setFocus.assert_called_once_with() + + def test_on_lock_button_toggled_search_tab(self): + """ + Test that "on_lock_button_toggled" gives focus to the right field. + """ + # GIVEN: Mocked functions + self.media_item.sender = MagicMock() + self.media_item.quickTab = MagicMock() + self.media_item.quick_search_edit = MagicMock() + + # WHEN: on_lock_button_toggled is called and quickTab.isVisible() returns = True. + self.media_item.on_lock_button_toggled(True) + + # THEN: on_quick_search_edit should receive focus. + self.media_item.quick_search_edit.setFocus.assert_called_once_with() From 190baf19d5767a8d9cb4f788b839a15fb6c8c699 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sun, 18 Sep 2016 01:53:47 +0300 Subject: [PATCH 13/14] - Added two new tests for lock button toggle. --- .../openlp_plugins/bibles/test_mediaitem.py | 38 ++++++++++++++++--- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 484e5bd3d..4543b6974 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -169,17 +169,43 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.quick_search_edit.clear.assert_called_once_with(), self.media_item.quick_search_edit.setFocus.assert_called_once_with() - def test_on_lock_button_toggled_search_tab(self): + def test_on_lock_button_toggled_search_tab_lock_icon(self): """ - Test that "on_lock_button_toggled" gives focus to the right field. + Test that "on_lock_button_toggled" gives focus to the right field and toggles the lock properly. """ - # GIVEN: Mocked functions + # GIVEN: Mocked sender & Search edit, quickTab returning value = True on isVisible. self.media_item.sender = MagicMock() - self.media_item.quickTab = MagicMock() self.media_item.quick_search_edit = MagicMock() + self.media_item.quickTab = MagicMock(**{'isVisible.return_value': True}) - # WHEN: on_lock_button_toggled is called and quickTab.isVisible() returns = True. + self.media_item.lock_icon = 'lock icon' + sender_instance_mock = MagicMock() + self.media_item.sender = MagicMock(return_value=sender_instance_mock) + + # WHEN: on_lock_button_toggled is called and checked returns = True. self.media_item.on_lock_button_toggled(True) - # THEN: on_quick_search_edit should receive focus. + # THEN: on_quick_search_edit should receive focus and Lock icon should be set. self.media_item.quick_search_edit.setFocus.assert_called_once_with() + sender_instance_mock.setIcon.assert_called_once_with('lock icon') + + def test_on_lock_button_toggled_select_tab_unlock_icon(self): + """ + Test that "on_lock_button_toggled" does not give focus to Search field in Select + and lock toggles properly. + """ + # GIVEN: Mocked sender & Search edit, quickTab returning value = False on isVisible. + self.media_item.sender = MagicMock() + self.media_item.quick_search_edit = MagicMock() + self.media_item.quickTab = MagicMock(**{'isVisible.return_value': False}) + + self.media_item.unlock_icon = 'unlock icon' + sender_instance_mock = MagicMock() + self.media_item.sender = MagicMock(return_value=sender_instance_mock) + + # WHEN: on_lock_button_toggled is called and checked returns = False. + self.media_item.on_lock_button_toggled(False) + + # THEN: on_quick_search_edit should not receive focus and Unlock icon should be set. + self.media_item.quick_search_edit.setFocus.assert_not_called_once_with() + sender_instance_mock.setIcon.assert_called_once_with('unlock icon') From ff2e1d1ea781cf5421aa36779d47cc8441221672 Mon Sep 17 00:00:00 2001 From: Olli Suutari Date: Sun, 18 Sep 2016 02:07:24 +0300 Subject: [PATCH 14/14] - The checking for not_called_once does not work apparently, fails in jenkins but passes in nosetests. --- .../openlp_plugins/bibles/test_mediaitem.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/functional/openlp_plugins/bibles/test_mediaitem.py b/tests/functional/openlp_plugins/bibles/test_mediaitem.py index 4543b6974..d5645cd3f 100644 --- a/tests/functional/openlp_plugins/bibles/test_mediaitem.py +++ b/tests/functional/openlp_plugins/bibles/test_mediaitem.py @@ -189,16 +189,15 @@ class TestMediaItem(TestCase, TestMixin): self.media_item.quick_search_edit.setFocus.assert_called_once_with() sender_instance_mock.setIcon.assert_called_once_with('lock icon') - def test_on_lock_button_toggled_select_tab_unlock_icon(self): + def test_on_lock_button_toggled_unlock_icon(self): """ - Test that "on_lock_button_toggled" does not give focus to Search field in Select - and lock toggles properly. + Test that lock button unlocks properly and lock toggles properly. """ # GIVEN: Mocked sender & Search edit, quickTab returning value = False on isVisible. self.media_item.sender = MagicMock() self.media_item.quick_search_edit = MagicMock() - self.media_item.quickTab = MagicMock(**{'isVisible.return_value': False}) - + self.media_item.quickTab = MagicMock() + self.media_item.quickTab.isVisible = MagicMock() self.media_item.unlock_icon = 'unlock icon' sender_instance_mock = MagicMock() self.media_item.sender = MagicMock(return_value=sender_instance_mock) @@ -206,6 +205,5 @@ class TestMediaItem(TestCase, TestMixin): # WHEN: on_lock_button_toggled is called and checked returns = False. self.media_item.on_lock_button_toggled(False) - # THEN: on_quick_search_edit should not receive focus and Unlock icon should be set. - self.media_item.quick_search_edit.setFocus.assert_not_called_once_with() + # THEN: Unlock icon should be set. sender_instance_mock.setIcon.assert_called_once_with('unlock icon')