From f0fb9e773d758bf583374df210c942aa5d2c1f39 Mon Sep 17 00:00:00 2001 From: Bastian Germann Date: Tue, 16 Oct 2018 09:09:18 +0200 Subject: [PATCH] no mandatory icu for tests --- setup.py | 1 - tests/functional/openlp_core/common/test_i18n.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 1fe60169c..2ee755251 100755 --- a/setup.py +++ b/setup.py @@ -138,7 +138,6 @@ elif sys.platform.startswith('darwin'): 'pyobjc-framework-Cocoa' ]) elif sys.platform.startswith('linux'): - # dbus-python could be replaced by PyQt5.QtDBus requires.append('dbus-python') setup( diff --git a/tests/functional/openlp_core/common/test_i18n.py b/tests/functional/openlp_core/common/test_i18n.py index 31d67c873..a4b896c6b 100644 --- a/tests/functional/openlp_core/common/test_i18n.py +++ b/tests/functional/openlp_core/common/test_i18n.py @@ -113,11 +113,11 @@ def test_get_language_invalid_with_none(): assert language is None +@skipIf(is_macosx(), 'This test doesn\'t work on macOS currently') def test_get_locale_key(): """ Test the get_locale_key(string) function """ - import icu with patch('openlp.core.common.i18n.LanguageManager.get_language') as mocked_get_language: # GIVEN: The language is German # 0x00C3 (A with diaresis) should be sorted as "A". 0x00DF (sharp s) should be sorted as "ss".