Commit Graph

78 Commits

Author SHA1 Message Date
Tim Bentley 5646183803 Fixes 2012-11-11 21:16:14 +00:00
Tim Bentley 55f4bc3a73 Fix name and add spearator 2012-11-11 19:33:53 +00:00
Raoul Snyman b76be3d6b8 Fixed bug #1077654 where there were more classes in the CSS, but we were specifically looking for only one class. Made the code less brittle.
Fixes: https://launchpad.net/bugs/1077654
2012-11-11 18:09:23 +02:00
Tim Bentley 47c9af348c Fix spelling - oops 2012-11-07 21:37:01 +00:00
Tim Bentley 716dc9ccf0 More updates 2012-10-21 15:07:57 +01:00
Tim Bentley cdbc1fd82e Copyrights 2012-10-21 14:16:22 +01:00
Samuel Findlay 4510fdbede Added three names in Copyright headers and About window (Samuel Findlay, Edwin Lunando, Dave Warnock). Fixed consistency issues. 2012-06-23 00:14:53 +10:00
Dave Warnock e0c5fabc5a Amend DB Error OperationError
bzr-revno: 1988
2012-06-11 18:33:57 +01:00
Dave Warnock b9b0d83a00 renamed tryCount local variable to try_count 2012-06-11 15:11:53 +01:00
Dave Warnock 913b0433f6 This update is a tidy up of the code that fixed bug #927473
Changes are made due to the following issues:

- the code assumed that exception OperationalError would only be thrown by  mySQL temporarily disappearing. However, other dbms can throw this exception and usually for errors that mean a retry will also fail.

- the code repeated the actual code of the method within the exception handler. This means code duplication and also that any new exceptions  are not handled by the same exception handler so for example their transaction will not get rolled back.

- not all potential dbms exceptions were caught and so in some cases the database transaction was not rolled back

The solution is to retry transactions where an OperationalError is thrown. Currently these are retried up to 3 times before the error is logged and the method returns false. By retrying the transaction we ensure that the same transaction code with the same exception handlers is used each time.

An additional catchall exception has been added where there is a transaction to ensure that it is rolled back. As with the OperationError this throws the exception back up the stack.
2012-06-10 22:45:02 +01:00
Stevan Pettit f1586052a6 Added code to allow OpenLP to run portable 2012-05-11 08:22:34 -04:00
Jon Tibble 9785e7f1be Cleanups 2012-03-12 19:35:29 +00:00
Rastislav Pecik 8818256b2a Fixed code according to mrege proposal comments 2012-02-28 15:06:14 +01:00
Rastislav Pecik 271c4ef1a4 using QtCore.QVariant object as a second argument in settings.value method 2012-02-28 12:30:30 +01:00
Rastislav Pecik 6ec167ed83 QSettings.value() now uses second argument for default value, which is utf8 2012-02-28 12:12:52 +01:00
Rastislav Pecik c024e9e47d Exported mysql charset settings to configuration files and cleaned up the code 2012-02-27 19:18:52 +01:00
Rastislav Pecik b56d8d2a06 Fixed connection to mysql to use UTF8 encoding.
Fixes: https://launchpad.net/bugs/941692
2012-02-27 01:42:35 +01:00
Raoul Snyman bcad2c171f Added exception logging in case we need to confirm that we are actually getting the exception we think we are. 2012-02-16 21:05:16 +02:00
Raoul Snyman f8a8185eb0 Attempt to catch the OperationalError which is thrown when MySQL closes the connection without telling us. 2012-02-12 11:24:06 +02:00
Tim Bentley 2a5e8935bb New year merge 2011-12-27 10:33:55 +00:00
Tim Bentley 17bca693c6 Block song exports 2011-12-04 16:36:18 +00:00
Tim Bentley 456d7ec68e remove print 2011-12-04 07:27:49 +00:00
Tim Bentley 6698ce578d Change Data type 2011-12-03 19:08:02 +00:00
Tim Bentley add75e9c7f Head 1815 2011-12-03 17:02:11 +00:00
Tim Bentley 8c4397d380 Head 2011-12-03 17:01:57 +00:00
Tim Bentley 1239cd707c Fix database versions 2011-12-03 12:51:40 +00:00
Tim Bentley 624216a1b8 add field and usage 2011-12-03 09:05:01 +00:00
Raoul Snyman 46643ab832 Added the quoting to database fields. 2011-11-07 23:22:35 -07:00
Raoul Snyman 4d66954d62 - Fixed re-playing of previous audio file.
- Fixed left-over files from previous song.
- Renamed a few more enumerations.
- Fixed some exception handling.
2011-08-31 09:49:57 +02:00
Raoul Snyman 0b81824430 HEAD 2011-08-28 19:45:31 +02:00
Tim Bentley 67894aa8d9 Error Handling improvements 2011-08-27 19:43:05 +01:00
Tim Bentley c1a648900f Fix initial setup bug 2011-08-27 16:02:45 +01:00
Raoul Snyman f099329217 Up/Down buttons, Remove/Remove All buttons. 2011-08-27 01:04:54 +02:00
Tim Bentley 1e4b922bfa DB Fixed 2011-08-26 20:09:25 +01:00
Tim Bentley 2dd0aa234e remove prints 2011-08-26 19:07:44 +01:00
Tim Bentley f266485001 Add fields to database 2011-08-26 18:56:36 +01:00
Raoul Snyman bcf9b174ff Fixed a bug where the version number saved to the database was incorrect. Added the ability to throw an error message and not load the database if the db is too new or incorrect. 2011-08-25 22:02:55 +02:00
Raoul Snyman ddf148449d Now with exception handling. 2011-08-25 13:47:07 +02:00
Raoul Snyman 923261c59c Even better, got rid of 'upgrade_schema' function which is not really needed. 2011-08-25 11:22:48 +02:00
Raoul Snyman 7e572cd0c2 Database upgrading, revision 1. 2011-08-25 11:02:59 +02:00
Raoul Snyman 301993a3ea Fixed bug #825809 where SQLAlchemy 0.7 throws a 'ArgumentError: SQL expression object or string expected' when passed something other than an SQL expression object or a string.
Fixes: https://launchpad.net/bugs/825809
2011-08-16 21:53:52 +02:00
Tim Bentley 608910a098 Fix name 2011-06-12 17:02:52 +01:00
Tim Bentley c812770153 Copyright fixes 2011-06-12 16:41:01 +01:00
Armin Köhler 8caece6af0 HEAD r1588 2011-05-28 14:50:29 +02:00
Raoul Snyman 665fc82c94 Fix for bug #789285: OpenLP does not work with SQLAlchemy 0.7. 2011-05-27 21:25:03 +02:00
Armin Köhler d3148f90f8 fix Traceback like Jonathan recommand 2011-05-27 09:54:49 +02:00
Tim Bentley acdbefd922 Fixes 2011-05-26 18:11:22 +01:00
Tim Bentley 8f6ed366a1 Copyright updates 2011-05-26 17:25:54 +01:00
Raoul Snyman 7669643774 Updated the copyright notice, adding Jeffrey Smith back in after he accidentally got removed somewhere somehow. 2011-05-24 22:47:05 +02:00
Andreas Preikschat 3824c33607 use iteritems 2011-05-07 16:14:34 +02:00