Commit Graph

137 Commits

Author SHA1 Message Date
d1c4cea777 Fix linting issues 2018-10-26 18:40:20 -07:00
ec479e589b Fix a bunch of linting issues (which should also help resolve other circular dependencies) 2018-10-26 16:15:31 -07:00
Kyle Russell
8a5a2628dc Fix pycodestyle line spacing warnings 2018-08-31 20:27:53 -04:00
Kyle Russell
c366e58683 Improve usability of image plugin choosegroupform
In order to add an image to an existing group when no group was preselected,
the user must currently choose the existing group name from the comboxbox
and also select the Existing Group radio button.  It should be assumed that
by selecting a group name from the combobox, the user intendeds to add the
image to an existing group, and the accompanying radio button should
automatically be selected.  This reduces the number of required clicks, and
the likelihood of not actually adding the image to the correct group.

Likewise, if a user enters text into the New Group field, the dialog
should assume that the user's intent is to create a new group and auto
select the appropriate radio button.

Also removes some choosegroupdialog specific component logic from mediaitem,
since it's now covered by the choosegroupdialog implementation.  Better
encapsulation, and improves testability. (Testing that the existing group
radio button was selected when choosedialogform was initialized with a
preselected group requires much more effort when the radio button selection
logic spanned two components.)

Adds simple test cases for the scenarios described above.
2018-08-29 23:11:30 -04:00
Tim Bentley
2edfe63a59 pep8 2017-12-29 10:02:13 +00:00
Tim Bentley
8997fc07e0 ci fixes 2017-12-29 09:40:15 +00:00
Tim Bentley
41f35f52e3 End of 2017 2017-12-29 09:15:48 +00:00
Tim Bentley
367f8f9315 add missing text 2017-12-28 09:34:04 +00:00
Tim Bentley
cfc487d623 tests 2017-12-28 08:27:44 +00:00
Tim Bentley
6729e78231 almost finished 2017-12-23 09:09:45 +00:00
b406cfd5a8 Phase 1 complete 2017-10-07 00:05:07 -07:00
cff194d320 Skip Bible HTTP tests on Jenkins to prevent the server from being blacklisted 2017-09-25 11:50:24 -07:00
7239b1e400 Add a mock main_window 2017-09-22 22:23:56 -07:00
Tim Bentley
fa04eebf36 This is getting to big to stay external any longer.
The web interface works with the existing HTML which has been externalised and can be pulled from OpenLP.

- Add new web and socket servers to API and replace all existing API's
- remove most of the Remote plugin but leave the base there to allow for the html and js code to land there.
- amend the FTW to download a package of html, JS and CSS and install in the remote directory  
- add switch to turn off the servers to allow PyCharm to debug...

bzr-revno: 2759
2017-08-23 20:34:34 +01:00
Tim Bentley
93053cd723 get version 2017-06-08 22:36:17 +01:00
Tim Bentley
1c4f335f23 head without some chords stuff! 2017-06-06 21:58:12 +01:00
Philip Ridout
114a2a12a8 fixed some seg faults 2017-06-04 00:27:19 +01:00
Tomas Groth
81492013ed Fixed songshowplus encoding issue.
Fixed issue where enable-chord settings was not setup correctly for tests.

bzr-revno: 2745
2017-05-30 22:50:26 +02:00
Tomas Groth
ad55a8d254 Fix issue where enable-chord settings was not setup correctly for tests. 2017-05-30 22:06:27 +02:00
Philip Ridout
78f38780ce head 2017-05-26 14:30:54 +01:00
Philip Ridout
cc705e1958 HEAD 2017-05-14 08:15:29 +01:00
Philip Ridout
353b2b3067 Implement a custom widget for editing paths 2017-05-12 22:05:50 +01:00
9b70fe44cf HEAD 2017-05-08 12:10:46 -07:00
Philip Ridout
2747f370a4 Fixed up test 2017-05-06 11:34:56 +01:00
Philip Ridout
1100cd5a5b Fix segfault with QFormLayout in BibleImportForm\nAlso fix up a failing test 2017-05-06 10:22:34 +01:00
baa09a7dd6 Mock comes with Python as of 3.3, and I don't think there is anyone using lower than 3.3, so let's use Python's mock directly now 2017-04-23 22:17:55 -07:00
815c32b87f Fix a problem with loading Qt's translation files, bug #1676163
Fixes: https://launchpad.net/bugs/1676163
2017-03-27 17:36:54 -07:00
a2a51b95dd Various fixes:
- Fix PresentationManager importer to take weird XML into account
- Fix OpenLP importer to support author_types
- Fix opening the data folder in KDE where it was being misinterpreted as a SMB share
- Fix a problem with the media player no longer controlling the playlist
- Fix a problem where a timer would expire after the application had been torn down
- Fix song database upgrades by moving upgrades 4 and 5 into 6 and writing some damage control
- Add a CHANGELOG.rst file
2017-03-22 21:43:13 -07:00
cd7b18ef30 Cleanup BibleImportForm tests 2017-03-22 15:17:43 -07:00
05a39cb7ea Fix a test that was causing a segfault 2017-03-10 16:46:14 -07:00
324652c347 Port some bugfixes from 2.4 to trunk 2017-03-09 22:42:38 -07:00
Tim Bentley
7a72b2cad4 download and deploy works 2017-03-05 09:23:28 +00:00
Tim Bentley
b3fb5764c6 fix years 2017-03-04 19:17:59 +00:00
Tim Bentley
f76e030ac9 more cleanups 2017-03-04 17:32:47 +00:00
Tim Bentley
5d917de2f8 Head 2017-03-03 19:27:31 +00:00
3bc6fc0b77 Fix bug #1666005 and bug #1668994 2017-03-01 21:34:24 -07:00
Tim Bentley
74ca42e220 Yet another year goes by 2016-12-31 11:01:36 +00:00
Tim Bentley
0d540ae40b Add remotes file checking 2016-12-24 09:10:13 +00:00
Tim Bentley
2d695f13ea Head 2016-10-26 19:12:38 +01:00
Tomas Groth
3a3ca8d933 Fix fetching bible texts from CrossWalk. 2016-09-18 16:54:55 +02:00
Tim Bentley
225160be24 Head 2016-08-12 19:21:30 +01:00
Philip Ridout
4866dce071 test fixes 2016-08-09 21:49:52 +01:00
Tim Bentley
cade36a332 Head 2016-08-07 19:37:15 +01:00
Tomas Groth
031ae9ebc1 Use BibleGateway standard site instead of the legacy site. Fixes bug 1562384.
Fixes: https://launchpad.net/bugs/1562384
2016-07-24 21:49:29 +02:00
Tim Bentley
ca2ceba972 Head 2016-07-23 05:59:26 +01:00
Tim Bentley
76af52b2bf Bye Bye Remote 2016-07-08 18:10:18 +01:00
Tomas Groth
93fc6e0145 Update Crosswalk webpage parser to match new layout. Fixes bug 1599999.
Fixes: https://launchpad.net/bugs/1599999
2016-07-07 22:56:50 +02:00
ec8ace4929 Fixed up some issues and refactored a method that wasn't actually a test. 2016-06-02 01:14:58 +02:00
672b8334fa Initial attempt to move to nose2 2016-05-31 23:40:13 +02:00
9ac95cf665 Skip crosswalk.com test while server down 2016-05-05 12:37:48 -07:00