Commit Graph

2537 Commits

Author SHA1 Message Date
Kyle Russell
c366e58683 Improve usability of image plugin choosegroupform
In order to add an image to an existing group when no group was preselected,
the user must currently choose the existing group name from the comboxbox
and also select the Existing Group radio button.  It should be assumed that
by selecting a group name from the combobox, the user intendeds to add the
image to an existing group, and the accompanying radio button should
automatically be selected.  This reduces the number of required clicks, and
the likelihood of not actually adding the image to the correct group.

Likewise, if a user enters text into the New Group field, the dialog
should assume that the user's intent is to create a new group and auto
select the appropriate radio button.

Also removes some choosegroupdialog specific component logic from mediaitem,
since it's now covered by the choosegroupdialog implementation.  Better
encapsulation, and improves testability. (Testing that the existing group
radio button was selected when choosedialogform was initialized with a
preselected group requires much more effort when the radio button selection
logic spanned two components.)

Adds simple test cases for the scenarios described above.
2018-08-29 23:11:30 -04:00
Simon Hanna
7321810e78 Improve the regex, removing the displayed warning 2018-08-27 16:16:26 +02:00
Simon Hanna
aaef55106c Remove imports from openlp/core/ui/__init__.py and update related files 2018-08-25 16:36:46 +02:00
Simon Hanna
a4c1e306b5 Remote imports from openlp/core/lib/__init__.py and update other files accordingly 2018-08-25 16:08:19 +02:00
Simon Hanna
3e5eb698d9 Return None instead of raising an error when converting path objects 2018-08-12 13:12:03 +02:00
Tomas Groth
0aadec661f Fix some pylint failures and add qtawesome to appveyor install. 2018-08-05 22:28:01 +02:00
Tim Bentley
3a0d0ff2ea Head 2018-08-04 21:58:13 +01:00
edada54d7e Fix windows not using lo as network interface 2018-08-03 15:32:32 -07:00
Tim Bentley
023753b2fc fix tests 2018-07-15 20:54:41 +01:00
Phill Ridout
6a8bf83d27 Add cetralised proxy support
bzr-revno: 2823
2018-07-12 21:10:35 +01:00
Tomas Groth
e3d163bf7a Remove debug print 2018-07-06 22:23:33 +02:00
Tomas Groth
ac14c0186d fix pylint test 2018-07-05 22:33:07 +02:00
Tomas Groth
588cf96b5a Fix a test 2018-07-05 21:18:16 +02:00
Tomas Groth
56a811c094 More pycodestyle fixes 2018-07-04 22:42:55 +02:00
Tomas Groth
318e90f893 Fixes for pycodestyle 2018-07-02 22:38:47 +02:00
Tim Bentley
c064259e7e fix up after projector merge 2018-06-28 21:40:54 +01:00
bc832c7c72 PJLink2 update S 2018-06-28 08:37:37 -07:00
Tim Bentley
51f8eaa911 add tests 2018-06-27 22:01:30 +01:00
Tim Bentley
5c26cf8cf0 fixes 2018-06-26 20:44:54 +01:00
Tim Bentley
13f52e96db new tree 2018-06-26 18:08:36 +01:00
Tim Bentley
b6dc37fb0b remove more and fix code 2018-06-10 20:29:00 +01:00
Phill Ridout
2aaa0bf287 break out the code using multiple when/thens 2018-06-10 07:38:42 +01:00
Phill Ridout
94758a9778 Pep 2018-06-08 07:21:23 +01:00
Phill Ridout
fac5d4b798 Fixes 2018-06-08 07:12:23 +01:00
Phill Ridout
dce509e909 Add some forgetten files 2018-06-07 18:45:24 +01:00
Phill Ridout
6f34f8f2b8 Start on implementing global OpenLP proxying 2018-06-07 18:44:35 +01:00
991b2880bf PJLink2 update R 2018-05-03 07:58:50 -07:00
604581c71a PJLink2 update Q 2018-04-19 23:04:43 -07:00
Simon Hanna
de8cbc55d6 Fix comment 2018-04-17 12:27:38 +02:00
Simon Hanna
a2b86384a7 Add requested changes 2018-04-15 15:59:40 +02:00
Simon Hanna
255b1efe3a Fix bug where newlines where stripped when normalizing string 2018-04-14 21:52:28 +02:00
Tim Bentley
f4667d8614 remove comments 2018-04-06 16:52:08 +01:00
Tim Bentley
006fdae0de fix segfault 2018-04-05 17:29:34 +01:00
Tim Bentley
eae164f041 fix up the auth tests 2018-03-31 08:51:39 +01:00
Tim Bentley
01ae5247d3 start to test the http wrappers 2018-03-29 22:15:56 +01:00
Tim Bentley
819d5d830d Add a load of tests 2018-03-29 20:52:59 +01:00
Tim Bentley
127f1dc7fd fix up tests 2018-03-29 18:22:02 +01:00
Tim Bentley
c6076e1054 start to add tests 2018-03-29 18:10:29 +01:00
Tim Bentley
fada29080c fix a bit of the tests 2018-03-29 17:25:10 +01:00
Tim Bentley
db0f131e15 Add the removal of the version code part 1 2018-03-29 16:54:55 +01:00
Tim Bentley
cc688ea21d add tests 2018-03-18 18:18:17 +00:00
Tim Bentley
2531e56910 Fix quotes 2018-03-09 21:58:45 +00:00
Tim Bentley
0130e7fc09 fix test 2018-03-08 21:22:53 +00:00
Tim Bentley
c02ea46582 fix test 2018-03-08 21:19:38 +00:00
Tim Bentley
619d7ce839 add tests 2018-02-23 16:55:17 +00:00
Tim Bentley
36276d4fac fix tests 2018-02-23 16:22:48 +00:00
Tim Bentley
5696655768 Fix up text 2018-02-20 22:03:32 +00:00
8e5fb217d3 - manager: Remove unused signal disconnect projectorNetwork.disconnect()
- Change PJLinkUDP.pjlink_udp_commands to dict with link to processing methods
- Add test_projector_pjlink_udp.test_process_ackn_duplicate
- Add test_projector_pjlink_udp.test_process_ackn_multiple
- Add test_projector_pjlink_udp.test_process_ackn_single
- Add test_projector_pjlink_udp.test_process_srch
- Add PJLinkUDP.get_datagram method
- Add PJLinkUDP._trash_udp_buffer method
- Add PJLinkUDP.process_ackn method
- Add ...

bzr-revno: 2813
2018-02-16 21:09:49 +00:00
ed347492e9 Move MY_IP4 dict to get_local_ip4 function 2018-02-11 13:52:04 -08:00
f1996d2cb7 PJLink2 Update P 2018-02-11 03:42:13 -08:00