Commit Graph

460 Commits

Author SHA1 Message Date
Kyle Russell
c366e58683 Improve usability of image plugin choosegroupform
In order to add an image to an existing group when no group was preselected,
the user must currently choose the existing group name from the comboxbox
and also select the Existing Group radio button.  It should be assumed that
by selecting a group name from the combobox, the user intendeds to add the
image to an existing group, and the accompanying radio button should
automatically be selected.  This reduces the number of required clicks, and
the likelihood of not actually adding the image to the correct group.

Likewise, if a user enters text into the New Group field, the dialog
should assume that the user's intent is to create a new group and auto
select the appropriate radio button.

Also removes some choosegroupdialog specific component logic from mediaitem,
since it's now covered by the choosegroupdialog implementation.  Better
encapsulation, and improves testability. (Testing that the existing group
radio button was selected when choosedialogform was initialized with a
preselected group requires much more effort when the radio button selection
logic spanned two components.)

Adds simple test cases for the scenarios described above.
2018-08-29 23:11:30 -04:00
Simon Hanna
aaef55106c Remove imports from openlp/core/ui/__init__.py and update related files 2018-08-25 16:36:46 +02:00
Simon Hanna
a4c1e306b5 Remote imports from openlp/core/lib/__init__.py and update other files accordingly 2018-08-25 16:08:19 +02:00
Phill Ridout
6a8bf83d27 Add cetralised proxy support
bzr-revno: 2823
2018-07-12 21:10:35 +01:00
Tomas Groth
318e90f893 Fixes for pycodestyle 2018-07-02 22:38:47 +02:00
Phill Ridout
2aaa0bf287 break out the code using multiple when/thens 2018-06-10 07:38:42 +01:00
Phill Ridout
dce509e909 Add some forgetten files 2018-06-07 18:45:24 +01:00
a0d6f2d94a HEAD 2018-03-07 21:46:50 -07:00
8e5fb217d3 - manager: Remove unused signal disconnect projectorNetwork.disconnect()
- Change PJLinkUDP.pjlink_udp_commands to dict with link to processing methods
- Add test_projector_pjlink_udp.test_process_ackn_duplicate
- Add test_projector_pjlink_udp.test_process_ackn_multiple
- Add test_projector_pjlink_udp.test_process_ackn_single
- Add test_projector_pjlink_udp.test_process_srch
- Add PJLinkUDP.get_datagram method
- Add PJLinkUDP._trash_udp_buffer method
- Add PJLinkUDP.process_ackn method
- Add ...

bzr-revno: 2813
2018-02-16 21:09:49 +00:00
f1996d2cb7 PJLink2 Update P 2018-02-11 03:42:13 -08:00
97172efba5 HEAD 2018-01-30 21:10:09 -07:00
53ac8468d4 Fix copyright 2018-01-24 13:27:22 -07:00
7490c7ad1e HEAD 2018-01-13 17:55:21 -07:00
d758ed257c Fix progress not showing in the FTW 2018-01-13 16:24:26 -07:00
4fae7f829d Fix the tests I broke 2018-01-06 22:24:55 -07:00
Tim Bentley
162742927e head fixes 2017-12-29 10:19:33 +00:00
Tim Bentley
2edfe63a59 pep8 2017-12-29 10:02:13 +00:00
Tim Bentley
8997fc07e0 ci fixes 2017-12-29 09:40:15 +00:00
Tim Bentley
41f35f52e3 End of 2017 2017-12-29 09:15:48 +00:00
Tim Bentley
367f8f9315 add missing text 2017-12-28 09:34:04 +00:00
Tim Bentley
cfc487d623 tests 2017-12-28 08:27:44 +00:00
Phill Ridout
a4054d3c2c Move song test resources to a 'song' sub directory'
A few other minor changes
2017-12-24 08:42:46 +00:00
Phill Ridout
cb53a266ce HEAD 2017-12-24 07:40:07 +00:00
Tim Bentley
35d2ce263e finished 2017-12-23 09:22:53 +00:00
Tim Bentley
5e9a73ca9f almost finished 2017-12-23 09:10:43 +00:00
Tim Bentley
6729e78231 almost finished 2017-12-23 09:09:45 +00:00
Phill Ridout
38c124224f more test tidy ups 2017-12-22 22:21:38 +00:00
64a245bef9 HEAD 2017-12-01 14:58:34 -07:00
Phill Ridout
a79ec45055 HEAD 2017-11-18 22:40:05 +00:00
ecaf678a55 - Move openlp.core.lib.projector to openlp.core.projectors
- Move openlp.core.ui.projector to openlp.core.projectors
- Move tests.functional.openlp_core/lib/test_projector* to tests.functional.openlp.core.projectors
- Fix imports for new projector location
- Convert projector imports to fully-qualified import
- Fix delete projector item in ui.manager
- Fix projector tests
- Merge trunk (fix tests)
- Rename "Projector" dock to "Projector Controller"
--------------------------------------------...

bzr-revno: 2789
2017-11-18 22:25:36 +00:00
Phill Ridout
9196db5af0 Pathlib refactors and test fixes 2017-11-18 11:23:15 +00:00
c46cd951ef Projector imports to fully-qualified, renamed projector dock 2017-11-16 15:53:53 -08:00
8c3fd99ed5 Fix missing line 2017-11-15 00:03:35 -07:00
d50029c636 Merge trunk 2017-11-14 16:19:49 -08:00
e5c9b7c98e Merge from upstream 2017-11-14 17:01:19 -07:00
1cb11832bd Added some tests for the settings upgrade and fixed a bug I had introduced. 2017-11-14 00:19:10 -07:00
Phill
f302b21c4c Fixed a number of bugs, and tests.
Failing on Code Analysis2, but this looks like fallout from the refactors (it hasn't passed since the beginning of october)

Also contains superflys branch lp:~raoul-snyman/openlp/fix-linting

--------------------------------
lp:~phill-ridout/openlp/fixes-mkII (revision 2794)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2276/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2178/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests...

bzr-revno: 2784
2017-11-10 22:36:52 -07:00
3d4ed035e9 PJLink2-L updates 2017-11-10 03:59:38 -08:00
Phill Ridout
881c3648cc Test fixes 2017-11-09 20:24:46 +00:00
Phill Ridout
f307568cbb Misc test fixes 2017-11-03 22:52:24 +00:00
6718be4cff HEAD 2017-11-03 15:31:48 -07:00
Phill Ridout
fe5430e157 HEAD 2017-10-27 22:11:29 +01:00
d5ab3340eb Move widgets to a widgets module 2017-10-23 15:09:57 -07:00
53c8337017 Moved ScreenList to display module 2017-10-10 14:15:08 -07:00
15a4a93c96 Phase 2 complete 2017-10-10 00:08:44 -07:00
7086c88c7c Fix a test that was failing (not sure why) 2017-10-09 18:08:09 -07:00
b406cfd5a8 Phase 1 complete 2017-10-07 00:05:07 -07:00
26c78b374a HEAD 2017-10-04 23:28:57 -07:00
640ebf8c3c Added JavaScript tests in; Refactored some stuff, removed some stuff. Lots börken. 2017-10-04 00:44:08 -07:00
Tim Bentley
e2fd8beb2a fix tests 2017-09-27 20:16:24 +01:00
Philip Ridout
69fca430b5 HEAD 2017-09-26 17:42:54 +01:00
Philip Ridout
10b13872e5 Modify themes to work with pathlib 2017-09-26 17:39:13 +01:00
cff194d320 Skip Bible HTTP tests on Jenkins to prevent the server from being blacklisted 2017-09-25 11:50:24 -07:00
7239b1e400 Add a mock main_window 2017-09-22 22:23:56 -07:00
Philip Ridout
8f9cb4a090 Modify setting upgrade code to provide versioned updates. Upgrade settings to use JSON encoded Path objects 2017-08-26 16:06:11 +01:00
Philip Ridout
f8a68c23d0 Enable JSON to handle unsupported objects and tests 2017-08-25 21:03:25 +01:00
Philip Ridout
6ac671a5fa HEAD 2017-08-23 21:13:58 +01:00
Tim Bentley
fa04eebf36 This is getting to big to stay external any longer.
The web interface works with the existing HTML which has been externalised and can be pulled from OpenLP.

- Add new web and socket servers to API and replace all existing API's
- remove most of the Remote plugin but leave the base there to allow for the html and js code to land there.
- amend the FTW to download a package of html, JS and CSS and install in the remote directory  
- add switch to turn off the servers to allow PyCharm to debug...

bzr-revno: 2759
2017-08-23 20:34:34 +01:00
Tim Bentley
0066a926e6 More test fixes 2017-08-13 06:19:04 +01:00
Tim Bentley
751ec88d94 fix more tests 2017-08-12 21:52:19 +01:00
Philip Ridout
b384e6f2fa Convert some more utility fuctions over to using the pathlib 2017-08-12 18:45:56 +01:00
Tim Bentley
c2321e7c10 Merge head 2017-08-03 18:54:40 +01:00
VirBinarus
1ce9a53d3b removed blank lines, split up some test functions for readablilty. 2017-06-27 18:42:54 +01:00
VirBinarus
4d6a3ac5d5 formatted test_servicemanager.py even more to make jenkins even more happy 2017-06-22 21:57:36 +01:00
VirBinarus
82b7a568a5 formatted test_servicemanager.py more to make jenkins more happy 2017-06-22 21:49:14 +01:00
VirBinarus
36b965325f formatted test_servicemanager.py to make jenkins happy 2017-06-22 21:42:46 +01:00
VirBinarus
462bc6e051 fixed tests 2017-06-22 21:24:43 +01:00
VirBinarus
26275566ea bzr thinks I've modified it so this is to make sure 2017-06-15 19:10:09 +01:00
VirBinarus
9aef1cdf5d made tests 2017-06-15 19:05:38 +01:00
VirBinarus
524d8f3acb fixed bug #1238385, but no tests
Fixes: https://launchpad.net/bugs/1238385
2017-06-13 16:49:48 +01:00
Tim Bentley
da51b046b2 Head 2017-06-09 16:56:40 +01:00
Tim Bentley
93053cd723 get version 2017-06-08 22:36:17 +01:00
Tim Bentley
1c4f335f23 head without some chords stuff! 2017-06-06 21:58:12 +01:00
Olli Suutari
3e70173be4 Renamed "last search type" to "last used search type" 2017-06-04 12:52:15 +03:00
Philip Ridout
114a2a12a8 fixed some seg faults 2017-06-04 00:27:19 +01:00
Tomas Groth
81492013ed Fixed songshowplus encoding issue.
Fixed issue where enable-chord settings was not setup correctly for tests.

bzr-revno: 2745
2017-05-30 22:50:26 +02:00
Tomas Groth
ad55a8d254 Fix issue where enable-chord settings was not setup correctly for tests. 2017-05-30 22:06:27 +02:00
Philip Ridout
78f38780ce head 2017-05-26 14:30:54 +01:00
Philip Ridout
cc705e1958 HEAD 2017-05-14 08:15:29 +01:00
Philip Ridout
353b2b3067 Implement a custom widget for editing paths 2017-05-12 22:05:50 +01:00
9b70fe44cf HEAD 2017-05-08 12:10:46 -07:00
aeabd498a0 Remove the now defunct version detection and imports 2017-05-08 11:33:11 -07:00
Philip Ridout
2747f370a4 Fixed up test 2017-05-06 11:34:56 +01:00
Philip Ridout
1100cd5a5b Fix segfault with QFormLayout in BibleImportForm\nAlso fix up a failing test 2017-05-06 10:22:34 +01:00
baa09a7dd6 Mock comes with Python as of 3.3, and I don't think there is anyone using lower than 3.3, so let's use Python's mock directly now 2017-04-23 22:17:55 -07:00
815c32b87f Fix a problem with loading Qt's translation files, bug #1676163
Fixes: https://launchpad.net/bugs/1676163
2017-03-27 17:36:54 -07:00
a2a51b95dd Various fixes:
- Fix PresentationManager importer to take weird XML into account
- Fix OpenLP importer to support author_types
- Fix opening the data folder in KDE where it was being misinterpreted as a SMB share
- Fix a problem with the media player no longer controlling the playlist
- Fix a problem where a timer would expire after the application had been torn down
- Fix song database upgrades by moving upgrades 4 and 5 into 6 and writing some damage control
- Add a CHANGELOG.rst file
2017-03-22 21:43:13 -07:00
cd7b18ef30 Cleanup BibleImportForm tests 2017-03-22 15:17:43 -07:00
05a39cb7ea Fix a test that was causing a segfault 2017-03-10 16:46:14 -07:00
324652c347 Port some bugfixes from 2.4 to trunk 2017-03-09 22:42:38 -07:00
Tim Bentley
699342c89d pep8 2017-03-05 17:07:21 +00:00
Tim Bentley
1bcb6415c1 fix tests 2017-03-05 16:55:58 +00:00
Tim Bentley
7a72b2cad4 download and deploy works 2017-03-05 09:23:28 +00:00
Tim Bentley
b3fb5764c6 fix years 2017-03-04 19:17:59 +00:00
Tim Bentley
f76e030ac9 more cleanups 2017-03-04 17:32:47 +00:00
Tim Bentley
5d917de2f8 Head 2017-03-03 19:27:31 +00:00
3bc6fc0b77 Fix bug #1666005 and bug #1668994 2017-03-01 21:34:24 -07:00
Tim Bentley
74ca42e220 Yet another year goes by 2016-12-31 11:01:36 +00:00
Tim Bentley
0d540ae40b Add remotes file checking 2016-12-24 09:10:13 +00:00
Tim Bentley
126c5462a0 Head 2016-12-22 15:12:03 +00:00