forked from openlp/openlp
This is a mirror of the main OpenLP repository at https://gitlab.com/openlp/openlp
c366e58683
In order to add an image to an existing group when no group was preselected, the user must currently choose the existing group name from the comboxbox and also select the Existing Group radio button. It should be assumed that by selecting a group name from the combobox, the user intendeds to add the image to an existing group, and the accompanying radio button should automatically be selected. This reduces the number of required clicks, and the likelihood of not actually adding the image to the correct group. Likewise, if a user enters text into the New Group field, the dialog should assume that the user's intent is to create a new group and auto select the appropriate radio button. Also removes some choosegroupdialog specific component logic from mediaitem, since it's now covered by the choosegroupdialog implementation. Better encapsulation, and improves testability. (Testing that the existing group radio button was selected when choosedialogform was initialized with a preselected group requires much more effort when the radio button selection logic spanned two components.) Adds simple test cases for the scenarios described above. |
||
|---|---|---|
| documentation | ||
| openlp | ||
| resources | ||
| scripts | ||
| tests | ||
| .bzrignore | ||
| CHANGELOG.rst | ||
| copyright.txt | ||
| LICENSE | ||
| MANIFEST.in | ||
| nose2.cfg | ||
| openlp.py | ||
| pylintrc | ||
| README.txt | ||
| setup.cfg | ||
| setup.py | ||
OpenLP
======
You're probably reading this because you've just downloaded the source code for
OpenLP. If you are looking for the installer file, please go to the download
page on the web site::
http://openlp.org/download
If you're looking for how to contribute to OpenLP, then please look at the
OpenLP wiki::
http://wiki.openlp.org/
Thanks for downloading OpenLP!