Commit Graph

14101 Commits

Author SHA1 Message Date
Tomas Groth
189b2dd400 Improve pylint testing, fixed a few issues. 2016-08-01 19:42:29 +02:00
second@tgc.dk
291c9c8902 Use BibleGateway standard site instead of the legacy site. Fixes bug 1562384.
Update Crosswalk webpage parser to match new layout. Fixes bug 1599999.
Make easyslide importer try to recover when reading non-standard xml. Fixes bug 1588822.
Fix handeling of control chars and escaped chars in VideoPsalm import. Fixes bug 1594945.

bzr-revno: 2683
Fixes: https://launchpad.net/bugs/1562384, https://launchpad.net/bugs/1588822, https://launchpad.net/bugs/1594945, https://launchpad.net/bugs/1599999
2016-07-27 21:11:22 +02:00
Tomas Groth
449b46ab3d merge trunk 2016-07-27 21:01:57 +02:00
39e6ba873f Fix the "ret_value" problem created by a little too much linting.
Add this to your merge proposal:
--------------------------------
lp:~raoul-snyman/openlp/fix-retvalue (revision 2684)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1666/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1577/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1515/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1280/
[SUCCESS] https://ci.openlp.io/job/Branch-0...

bzr-revno: 2682
2016-07-25 10:07:12 +02:00
0dcae022bc some pep8 fixes 2016-07-24 22:49:00 +02:00
ea455d9b32 Write some tests 2016-07-24 22:41:27 +02:00
Tomas Groth
031ae9ebc1 Use BibleGateway standard site instead of the legacy site. Fixes bug 1562384.
Fixes: https://launchpad.net/bugs/1562384
2016-07-24 21:49:29 +02:00
ebefc03674 Fix the disappearance of a variable :-) 2016-07-23 23:41:24 +02:00
second@tgc.dk
c426b8c1a2 "Added a test using pylint to test the code for the most serious issues.
Added pylintrc for finding more potential issues with pylint (not used in the test).
Made some fixes as suggested by pylint."

bzr-revno: 2681
2016-07-21 23:32:25 +02:00
0150291e4d "- Convert calls to md5_hash and qmd5_hash to use UTF-8 for non-ascii characters
- Fixed test to verify UTF-8 returns valid ASCII hash
- Switch back to qmd5_hash to stay within the Qt framework

--------------------------------
lp:~alisonken1/openlp/projector-cleanups (revision 2679)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1646/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1557/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1495/
[SUCCESS] https://ci.o..."

bzr-revno: 2680
2016-07-21 23:29:58 +02:00
0b8b88a587 "Fix a permission error that people keep on getting but we never actually log and fix.
Add this to your merge proposal:
--------------------------------
lp:~raoul-snyman/openlp/permission-error (revision 2682)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1656/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1567/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1505/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1271/
[SUCCESS] https://c..."

bzr-revno: 2679
2016-07-21 23:26:09 +02:00
785257020d Fix some linting issues 2016-07-17 21:46:06 +02:00
65fe62d69f Fix some linting issues 2016-07-17 21:33:10 +02:00
97d6586462 Fixed another part of the permission denied error 2016-07-17 21:12:00 +02:00
3cdd42bfe0 Catch the PermissionError too 2016-07-17 00:20:56 +02:00
de3f4046b7 Convert md5sum calls to utf-8 for non-ascii pins 2016-07-08 12:19:08 -07:00
Tomas Groth
93fc6e0145 Update Crosswalk webpage parser to match new layout. Fixes bug 1599999.
Fixes: https://launchpad.net/bugs/1599999
2016-07-07 22:56:50 +02:00
Tomas Groth
ba80fe653c Fix format error 2016-07-07 22:52:00 +02:00
Tomas Groth
f5da7e2a2b Make easyslide importer try to recover when reading non-standard xml. Fixes bug 1588822.
Fixes: https://launchpad.net/bugs/1588822
2016-07-07 22:51:25 +02:00
Tomas Groth
8009bfef85 forgot test file 2016-07-07 22:48:52 +02:00
Tomas Groth
69951133fe Fix handeling of control chars and escaped chars in VideoPsalm import. Fixes bug 1594945.
Fixes: https://launchpad.net/bugs/1594945
2016-07-07 22:47:57 +02:00
8fcf42cdc3 Bugfix 1593882 and 1593883 - projector authorization
- Fix exception when authenticated connection requested and pin is None
- Fix pjlink authentication (use python hash instead of qt hash)
- Fix md5_hash functions
- Fix qmd5hash functions
- Added tests for bugfixes
Tested with test server and Eiki XL200 projector

--------------------------------
lp:~alisonken1/openlp/bug-1593883-projector-authentication (revision 2684)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1629/
[SUCCESS] https...

bzr-revno: 2678
Fixes: https://launchpad.net/bugs/1596380
2016-07-07 22:36:55 +02:00
Tomas Groth
1992a51339 More pylint-fixes 2016-07-06 21:48:57 +02:00
Tomas Groth
99e6ab6657 Fix various issues as suggested by pylint 2016-07-05 22:31:29 +02:00
Tomas Groth
9294aadae9 Changes to pylint test 2016-07-05 22:30:33 +02:00
Tomas Groth
8aa917c89c A bunch of fixes suggested by pylint. 2016-07-01 23:17:20 +02:00
Tomas Groth
1cf078be76 Add pylintrc file 2016-07-01 23:14:24 +02:00
Tomas Groth
668f10a14b more pylint 2016-06-28 22:44:50 +02:00
Tomas Groth
04cb827911 Started work on using pylint for code analysing. 2016-06-27 23:19:53 +02:00
f911bdafa9 Format fix 2016-06-26 17:08:28 -07:00
8806a06ab9 Test cleanups 2016-06-17 19:45:02 -07:00
7cc56af2bb bugfix 1593883 pjlink authenticatino test 2016-06-17 19:02:53 -07:00
7e8eb21510 Pep8 and notes about hashing 2016-06-17 16:54:04 -07:00
d1ff2385ae bug 1593883 fix - switch from qmd5_hash to md5_hash 2016-06-17 16:48:32 -07:00
aaba690c97 Fix call to wrong signal on error 2016-06-17 16:05:26 -07:00
c64df391aa bug 1593882 fix 2016-06-17 15:46:21 -07:00
76ffe35621 bug 1593882 - fix authenticated connection but bin not set 2016-06-17 15:06:55 -07:00
second@tgc.dk
45d2640159 "Fix various pyodbc related issues. Fixes bug 1590657.
Fix of tracback during SongPro import. Fixes bug 1582152.
Fix traceback during songshowplus import. Fixes bug 1585489.
Skip PresentationManager files we do not support."

bzr-revno: 2677
Fixes: https://launchpad.net/bugs/1582152, https://launchpad.net/bugs/1585489, https://launchpad.net/bugs/1590657
2016-06-16 22:12:27 +02:00
f052cf99d9 Fix bug #1589815 by first reducing the string to digits only and then checking if there's anything left.
Add this to your merge proposal:
--------------------------------
lp:~raoul-snyman/openlp/bug-1589815 (revision 2675)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1603/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1514/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1452/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1225/
[SUCC...

bzr-revno: 2676
2016-06-14 22:07:18 +01:00
f20499b1af Convert htmlbuilder.py to use Template() strings for css
- Changed strings to use Template() instead of format() for css building
- Fix htmlbuilder strings tests
- Cleanup template variables and fix tests to match
- bug 1590386 - string format error in editbibledialog.py
- bug 1590475 - string format error in mediaitem.py
- Function call error in firsttimeform.py (missed label text variable)

--------------------------------
lp:~alisonken1/openlp/strings-templates2 (revision 2679)
[SUCCESS] ...

bzr-revno: 2675
Fixes: https://launchpad.net/bugs/1590386, https://launchpad.net/bugs/1590475
2016-06-14 22:05:51 +01:00
Tomas Groth
4fc4fa8969 pep8 fixes 2016-06-14 22:36:51 +02:00
Tomas Groth
41c0d3fcf9 Fix various pyodbc related issues. Fixes bug 1590657.
Fixes: https://launchpad.net/bugs/1590657
2016-06-14 21:11:57 +02:00
Tomas Groth
e89803a3ad merge trunk 2016-06-14 21:06:54 +02:00
aedcecc7ff String format oops 2016-06-08 19:57:21 -07:00
e222a11390 String format oops 2016-06-08 13:41:21 -07:00
b84dbb15a2 Oops in string format 2016-06-08 13:26:01 -07:00
828741ec84 Remove testing verbosity flag 2016-06-07 06:21:07 -07:00
5fe54b5907 Beauty spa for the htmlbuilder 2016-06-07 06:12:22 -07:00
0d2745a1d1 Fix bug #1589815 by first reducing the string to digits only and then checking if there's anything left. 2016-06-07 09:35:06 +02:00
2443b94eda Convert htmlbuilder strings to Template() 2016-06-06 08:16:09 -07:00